[Bug 31631] New: Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Bug ID: 31631 Summary: Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Public and tertiary libraries in New Zealand can claim back tax on purchases - see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461#c33 This means these NZ libraries want to input prices with tax included (as that is what is printed on their invoices), but want the amount removed from their Koha funds to be tax exclusive (as they will be claiming back the tax). Bug 13324 enforced that tax-included values were always used for calculating fund values (spent, ordered), for all supplier configurations. It would be useful for NZ libraries if they could globally choose for tax-exclusive values to be used for calculating fund values, with the behaviour introduced by 13324 continuing as the default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 141017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141017&action=edit Bug 31631: Add new system preference Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 141018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141018&action=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema <instance> 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order keeping all the default values 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 141019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141019&action=edit Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell <instance> prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31840 CC| |aleisha@catalyst.net.nz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840 [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142597&action=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 142661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142661&action=edit Screenshot - Receiving order - formatting and default values Testing notes and issues/query (tested using koha-testing-docker). Three things I noticed: 1. Tax Rate system preference warning message --------------------------------------------- Even though I defined the Tax Rate system preference as 0.15, when adding an item to a basket: for tax rate there is a message saying "Tax rate not defined in system preference TaxRates!". Despite the warning, everything is calculated correctly using the 15% tax rate. I've logged bug 31984 for this, as this was happening before the patches were applied (includes a screenshot to show what I mean). 2. Step 13 - Formatting things ------------------------------ When receiving order (see screenshot): - For the Retail price field: no space after value and the opening bracket; no space between comma and tax exclusive - For the Budgeted cost field: no space after value and the opening bracket 3. For step 13 - Query about using the default values ----------------------------------------------------- I received the order with the default values (see the screenshot). As the actual cost defaulted to $10 (as entered in step 6), then the 10.00 is the value excluding tax, so: - For step 14: spent = 10.00 - For step 15: subtotal = 10.00 - For step 17: spent = 11.50 - For step 18: subtotal = 11.50 These values are correctly calculated, but don't match up with the test plan. So should I have entered the actual costs as 8.00 (the $10 retail price less the 20% discount, tax exclusive)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks for testing David (In reply to David Nind from comment #6)
Created attachment 142661 [details] Screenshot - Receiving order - formatting and default values
Testing notes and issues/query (tested using koha-testing-docker).
Three things I noticed:
1. Tax Rate system preference warning message ---------------------------------------------
Unrelated (exists before patches), see bug 31984
2. Step 13 - Formatting things ------------------------------
Unrelated (exists before patches), maybe open another bug for this?
3. For step 13 - Query about using the default values -----------------------------------------------------
These values are correctly calculated, but don't match up with the test plan. So should I have entered the actual costs as 8.00 (the $10 retail price less the 20% discount, tax exclusive)?
Yes I think that's right sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141017|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 143156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143156&action=edit Bug 31631: Add new system preference Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141018|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 143157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143157&action=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema <instance> 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order keeping all the default values 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141019|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 143158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143158&action=edit Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell <instance> prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142597|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 143159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143159&action=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32106 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Unit tests are failing randomly: root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 526. Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 526. # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1243. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1247. # got: '169.44' # expected: '157.6' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1270. # got: '157.6' # expected: '147.36' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1272. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1276. # got: '169.44' # expected: '157.6' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1278. # got: '169.44' # expected: '157.6' # Looks like you failed 6 tests of 34. t/db_dependent/Budgets.t .. 154/154 # Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell FieldsForCalculatingFundValues tests' # at t/db_dependent/Budgets.t line 1290. # Looks like you failed 1 test of 154. t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/154 subtests Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1) Failed test: 154 Non-zero exit status: 1 Files=1, Tests=154, 4 wallclock secs ( 0.02 usr 0.00 sys + 3.43 cusr 0.65 csys = 4.10 CPU) Result: FAIL root@kohadevbox:koha(bug31631-qa)$ git log commit 2a3c15c91467b01802c31a65f3436c9175ef1103 (HEAD -> bug31631-qa) Author: Aleisha Amohia <aleisha@catalystacademy.net.nz> Date: Tue Oct 25 03:08:03 2022 +0000 Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind <david@davidnind.com> commit cc6bcfe54ea55691bd4ed749b58fac2f9331f8fd Author: Alex Buckley <alexbuckley@catalyst.net.nz> Date: Tue Sep 27 17:01:51 2022 +1300 Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell <instance> prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> commit a50a301eacde061376c6a3c0cafc03b56e8d1604 Author: Alex Buckley <alexbuckley@catalyst.net.nz> Date: Tue Sep 27 16:59:00 2022 +1300 Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema <instance> 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. t/db_dependent/Budgets.t .. ok All tests successful. Files=1, Tests=154, 4 wallclock secs ( 0.02 usr 0.01 sys + 2.99 cusr 0.54 csys = 3.56 CPU) Result: PASS root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 526. Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 526. # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1243. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1247. # got: '169.44' # expected: '157.6' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1270. # got: '157.6' # expected: '147.36' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1272. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1276. # got: '169.44' # expected: '157.6' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1278. # got: '169.44' # expected: '157.6' # Looks like you failed 6 tests of 34. t/db_dependent/Budgets.t .. 154/154 # Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell FieldsForCalculatingFundValues tests' # at t/db_dependent/Budgets.t line 1290. # Looks like you failed 1 test of 154. t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/154 subtests Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1) Failed test: 154 Non-zero exit status: 1 Files=1, Tests=154, 5 wallclock secs ( 0.02 usr 0.01 sys + 3.41 cusr 0.68 csys = 4.12 CPU) Result: FAIL root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 2/154 Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 526. Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515. Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 526. # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1243. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1247. # got: '169.44' # expected: '157.6' # Looks like you failed 2 tests of 34. t/db_dependent/Budgets.t .. 154/154 # Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell FieldsForCalculatingFundValues tests' # at t/db_dependent/Budgets.t line 1290. # Looks like you failed 1 test of 154. t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/154 subtests Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1) Failed test: 154 Non-zero exit status: 1 Files=1, Tests=154, 2 wallclock secs ( 0.02 usr 0.00 sys + 2.17 cusr 0.24 csys = 2.43 CPU) Result: FAIL root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 100/154 Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1270. # got: '157.6' # expected: '147.36' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1272. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1276. # got: '169.44' # expected: '157.6' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1278. # got: '169.44' # expected: '157.6' # Looks like you failed 4 tests of 34. t/db_dependent/Budgets.t .. 154/154 # Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell FieldsForCalculatingFundValues tests' # at t/db_dependent/Budgets.t line 1290. # Looks like you failed 1 test of 154. t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/154 subtests Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1) Failed test: 154 Non-zero exit status: 1 Files=1, Tests=154, 3 wallclock secs ( 0.03 usr 0.00 sys + 2.31 cusr 0.37 csys = 2.71 CPU) Result: FAIL root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 2/154 Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1270. # got: '157.6' # expected: '147.36' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1272. # got: '157.6' # expected: '147.36' # Failed test 'We expect this to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1276. # got: '169.44' # expected: '157.6' # Failed test 'We expect this value to be the tax exclusive value' # at t/db_dependent/Budgets.t line 1278. # got: '169.44' # expected: '157.6' # Looks like you failed 4 tests of 34. t/db_dependent/Budgets.t .. 154/154 # Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell FieldsForCalculatingFundValues tests' # at t/db_dependent/Budgets.t line 1290. # Looks like you failed 1 test of 154. t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/154 subtests Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1) Failed test: 154 Non-zero exit status: 1 Files=1, Tests=154, 2 wallclock secs ( 0.03 usr 0.00 sys + 2.09 cusr 0.28 csys = 2.40 CPU) Result: FAIL root@kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 2/154 Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. Use of uninitialized value in addition (+) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490. t/db_dependent/Budgets.t .. ok All tests successful. Files=1, Tests=154, 2 wallclock secs ( 0.01 usr 0.00 sys + 2.15 cusr 0.23 csys = 2.39 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147011&action=edit Bug 31631: Add new system preference Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147012&action=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema <instance> 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order keeping all the default values 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147013&action=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147014&action=edit Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell <instance> prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147014|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147015&action=edit Bug 31631: Unit tests Test plan: 1. Run tests in koha-shell sudo koha-shell <instance> prove t/db_dependent/Budgets.t Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #18 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147098&action=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema <instance> 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order keeping all the default values 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #19 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147099&action=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #20 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147100&action=edit Bug 31631: Unit tests Test plan: Run amended Budgets.t test and all existing unchanged Acquisition tests in koha-shell - sudo koha-shell <instance> - prove t/db_dependent/Budgets.t - prove t/db_dependent/Acquisition - prove t/db_dependent/Acquisition.t - prove t/db_dependent/Budgets Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #21 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147101&action=edit Bug 31631: (follow-up) Fixes for QA test tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147099|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147098|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #22 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147102&action=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema <instance> 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 - Ensure the basket belongs to a vendor with ("List prices" = "Don't include tax" and "Invoice prices" = "Don't include tax") 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order - change the 'Actual costs' = 8.00 (the $10 retail price less the 20% discount, tax exclusive) 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #23 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147103&action=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #24 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147104&action=edit Bug 31631: Unit tests Test plan: Run amended Budgets.t test and all existing unchanged Acquisition tests in koha-shell - sudo koha-shell <instance> - prove t/db_dependent/Budgets.t - prove t/db_dependent/Acquisition - prove t/db_dependent/Acquisition.t - prove t/db_dependent/Budgets Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #25 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 147105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147105&action=edit Bug 31631: (follow-up) Fixes for QA test tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Public and tertiary release notes| |libraries in New Zealand | |can claim tax back on | |purchases. | | | |This | |enhancement adds a new | |system preference | |'CalculateFundValuesIncludi | |ngTax'. | | | |When set to | |'Exclude' these libraries | |can input order prices with | |tax included (so vendor | |invoice prices - which do | |contain tax - can be | |entered directly into | |Koha). | | | |However, the order | |prices removed from the | |Koha funds are the tax | |exclusive values (NZ | |libraries claim tax back so | |it should not be removed | |from their funds). Status|Failed QA |Signed Off --- Comment #26 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Setting this back to 'Signed off'. I have done the following: 1. Corrected the test plan on the second patch so that it reflects the point David raised in comment #6 2. Submitted a fifth patch fixing QA test tool failures. I am still getting one failure for the template on ordered.tt, but I think that might just be my qa test tools. 3. Fixed the unit tests and expanded the unit test coverage - we now test both when vendors have listincgst/invoiceincgst set to 0 and 1. The unit tests now consistently pass: " kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in addition (+) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495. t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495. t/db_dependent/Budgets.t .. ok All tests successful. Files=1, Tests=156, 12 wallclock secs ( 0.05 usr 0.01 sys + 9.22 cusr 2.01 csys = 11.29 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495. t/db_dependent/Budgets.t .. ok All tests successful. Files=1, Tests=156, 11 wallclock secs ( 0.04 usr 0.02 sys + 9.10 cusr 1.50 csys = 10.66 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 520. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531. t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495. t/db_dependent/Budgets.t .. ok All tests successful. Files=1, Tests=156, 10 wallclock secs ( 0.02 usr 0.02 sys + 7.34 cusr 1.27 csys = 8.65 CPU) Result: PASS " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- # Looks like you failed 4 tests of 156. # Failed test 'total spent for budget1 is 160' # at t/db_dependent/Budgets.t line 436. # got: '0' # expected: '160' # Failed test 'total spent for budget11 is 100' # at t/db_dependent/Budgets.t line 437. # got: '0' # expected: '100' # Failed test 'total spent for budget111 is 20' # at t/db_dependent/Budgets.t line 438. # got: '0' # expected: '20' # Failed test 'total ordered price is 20' # at t/db_dependent/Budgets.t line 519. # got: '0' # expected: '20' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #28 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 150146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150146&action=edit Bug 31631: (follow-up) Fixes for failing unit test t/db_dependent/Budgets.t Test plan: 1. Set CalculateFundValuesIncludingTax = 'Include' 2. Run Budgets.t unit test sudo koha-shell kohadev prove t/db_dependent/Budgets.t 3. Set CalculateFundValuesIncludingTax = 'Exclude' 4. Run Budgets.t unit test sudo koha-shell kohadev prove t/db_dependent/Budgets.t Sponsored-By: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #27)
# Looks like you failed 4 tests of 156.
# Failed test 'total spent for budget1 is 160' # at t/db_dependent/Budgets.t line 436. # got: '0' # expected: '160'
# Failed test 'total spent for budget11 is 100' # at t/db_dependent/Budgets.t line 437. # got: '0' # expected: '100'
# Failed test 'total spent for budget111 is 20' # at t/db_dependent/Budgets.t line 438. # got: '0' # expected: '20'
# Failed test 'total ordered price is 20' # at t/db_dependent/Budgets.t line 519. # got: '0' # expected: '20'
Thanks Marcel. I've attached a followup fixing the Budgets.t unit test when CalculateFundValuesIncludingTax is set to 'Include' or 'Exclude'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34207 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147011|0 |1 is obsolete| | Attachment #147102|0 |1 is obsolete| | Attachment #147103|0 |1 is obsolete| | Attachment #147104|0 |1 is obsolete| | Attachment #147105|0 |1 is obsolete| | Attachment #150146|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156062&action=edit Bug 31631: Add new system preference Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156062|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156063&action=edit Bug 31631: Add new system preference Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156064&action=edit Bug 31631: Optionally use tax-exclusive values for calculating fund values Test plan: 1. Apply patches 2. sudo koha-upgrade-schema <instance> 3. Restart services 4. Set TaxRates syspref = 0.15 5. Create a new fund with amount = 1000 6. Add an order to a basket with the following values: - Fund = Choose the fund from step #5 - Quantity = 1 - Vendor price = 10 - Tax rate = 15% - Discount = 20% - Retail price = 10.00 - Replacement cost = 10.00 - Actual cost = 10.00 - Ensure the basket belongs to a vendor with ("List prices" = "Don't include tax" and "Invoice prices" = "Don't include tax") 7. Go to the Acquisitions home page 8. Confirm the 'Ordered' column for the step #5 fund contains 9.20 9. Click on the 9.20 link and confirm the ordered.pl page that loads also contains 9.20 as the 'Subtotal' 10. Change 'CalculateFundValuesIncludingTax' = 'Exclude' 11. On the Acquisitions home page confirm the 'Ordered' column now contains 8.00 12. Click on the 8.00 link and confirm the ordered.pl page also contains 8.00 as the 'Subtotal' 13. Close your basket and receive your order - change the 'Actual costs' = 8.00 (the $10 retail price less the 20% discount, tax exclusive) 14. Go to the Acquisitions home page and confirm the 'Spent' column now contains 8.00 15. Click on the 8.00 link and confirm the spent.pl page also contains 8.00 as the 'Subtotal' 16. Change 'CalculateFundValuesIncludingTax' = 'Include' 17. Confirm the 'Spent' column on the Acquisitions home page now shows 9.20 18. Click on the 9.20 link and confirm the spent.pl page also contains 9.20 as the 'Subtotal' Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156065&action=edit Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying existing order This patch depends on Bug 31840. To test: 1) Edit an order and increase the price so that you would expect it to trigger a warning that you will exceed the amount allowed for this Fund 2) Confirm the warning is triggered Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156066&action=edit Bug 31631: Unit tests Test plan: Run amended Budgets.t test and all existing unchanged Acquisition tests in koha-shell - sudo koha-shell <instance> - prove t/db_dependent/Budgets.t - prove t/db_dependent/Acquisition - prove t/db_dependent/Acquisition.t - prove t/db_dependent/Budgets Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156067&action=edit Bug 31631: (follow-up) Fixes for QA test tool Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156068&action=edit Bug 31631: (follow-up) Fixes for failing unit test t/db_dependent/Budgets.t Test plan: 1. Set CalculateFundValuesIncludingTax = 'Include' 2. Run Budgets.t unit test sudo koha-shell kohadev prove t/db_dependent/Budgets.t 3. Set CalculateFundValuesIncludingTax = 'Exclude' 4. Run Budgets.t unit test sudo koha-shell kohadev prove t/db_dependent/Budgets.t Sponsored-By: Waikato Institute of Technology, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156069&action=edit Bug 31631: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Public and tertiary |Public and tertiary release notes|libraries in New Zealand |libraries in New Zealand |can claim tax back on |can claim tax back on |purchases. |purchases. | | |This |This |enhancement adds a new |enhancement adds a new |system preference |system preference |'CalculateFundValuesIncludi |`CalculateFundValuesIncludi |ngTax'. |ngTax`. | | |When set to |When set to |'Exclude' these libraries |'Exclude' these libraries |can input order prices with |can input order prices with |tax included (so vendor |tax included (so vendor |invoice prices - which do |invoice prices - which do |contain tax - can be |contain tax - can be |entered directly into |entered directly into |Koha). |Koha). | | |However, the order |However, the order |prices removed from the |prices removed from the |Koha funds are the tax |Koha funds are the tax |exclusive values (NZ |exclusive values (NZ |libraries claim tax back so |libraries claim tax back so |it should not be removed |it should not be removed |from their funds). |from their funds). CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | CC| |aude.charillon@ptfs-europe. | |com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/950 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #40 from Aude Charillon <aude.charillon@ptfs-europe.com> --- New system preference added to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org