https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 128373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128373&action=edit Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl (the only places where it is used in the code even) instead of 'xsl_syspref' that is actually used and this is the cause of those warnings. Also added honeypot to check if other calls in same way happens. Honeypot probably not needed, review when QA in the Community. To reproduce: 1) Prepare some test list with items or use existing one. 2) Go to the lists page (koha/virtualshelves/shelves.pl), notice multitude of new warnings in the "intranet-error.log" log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Go back to same page and check it again, warns like that should not appear in the log file anymore. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_21_11_candidate Depends on| |12561 Severity|enhancement |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 [Bug 12561] Remove non-XSLT views -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128373|0 |1 is obsolete| | --- Comment #4 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 128544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128544&action=edit Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl (the only places where it is used in the code even) instead of 'xsl_syspref' that is actually used and this is the cause of those warnings. Also added honeypot to check if other calls in same way happens. Honeypot probably not needed, review when QA in the Community. To reproduce (shelves.pl): 1) Prepare some test list with items or use existing one. 2) Go to the lists page (koha/virtualshelves/shelves.pl), notice multitude of new warnings in the "intranet-error.log" log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Go back to same page and check it again, warns like that should not appear in the log file anymore. To reproduce (opac-tags.pl): 1) Go to the "my tags" page in OPAC and open "tag cloud". 2) Notice a bunch of new warnings in the log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Reload the page and check the log file again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128544|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128545&action=edit Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl (the only places where it is used in the code even) instead of 'xsl_syspref' that is actually used and this is the cause of those warnings. Also added honeypot to check if other calls in same way happens. Honeypot probably not needed, review when QA in the Community. To reproduce (shelves.pl): 1) Prepare some test list with items or use existing one. 2) Go to the lists page (koha/virtualshelves/shelves.pl), notice multitude of new warnings in the "intranet-error.log" log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Go back to same page and check it again, warns like that should not appear in the log file anymore. To reproduce (opac-tags.pl): 1) Go to the "my tags" page in OPAC and open "tag cloud". 2) Notice a bunch of new warnings in the log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Reload the page and check the log file again. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128545|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128566&action=edit Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl (the only places where it is used in the code even) instead of 'xsl_syspref' that is actually used and this is the cause of those warnings. Also added honeypot to check if other calls in same way happens. Honeypot probably not needed, review when QA in the Community. To reproduce (shelves.pl): 1) Prepare some test list with items or use existing one. 2) Go to the lists page (koha/virtualshelves/shelves.pl), notice multitude of new warnings in the "intranet-error.log" log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Go back to same page and check it again, warns like that should not appear in the log file anymore. To reproduce (opac-tags.pl): 1) Go to the "my tags" page in OPAC and open "tag cloud". 2) Notice a bunch of new warnings in the log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Reload the page and check the log file again. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.