[Bug 31917] New: Headings don't seem quite right for system preference search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Bug ID: 31917 Summary: Headings don't seem quite right for system preference search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 31886 When doing a system preference search we end up with two H2 headings directly after each other.. it doesn't feel quite right. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142407&action=edit Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142407|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142472&action=edit Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- +1 - looks better -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about this one. It removes one h1 and adds 3 new h1... but apart from this, we are currently not consistent: * Catalog search: What you searched for displays below the unchanged heading * Patron search: what you searched for displays as part of the altered heading. I'd like to get another set of eyes on this one, Owen or Lukas maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142472|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142532&action=edit Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- The template logic is a little more complex but I think the result is clearer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back to this one :) Thx, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142532|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142548&action=edit Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Bug 31917 depends on bug 31886, which changed state. Bug 31886 Summary: No side menu when searching for syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31917 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org