[Bug 20487] New: AddReturn should always clear item.onloan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Bug ID: 20487 Summary: AddReturn should always clear item.onloan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 73390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73390&action=edit Bug 20487: AddReturn should always clear items.onloan If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Realized by a simple change in AddReturn, moving the ModItem call outside the if-doreturn statement and testing if the change is needed. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AddReturn should always |AddReturn should always |clear item.onloan |clear items.onloan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Could you explain how this is supposed to relate to the doreturn logic in the code? Something seems not quite right about the move. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. Tompsett from comment #2)
Could you explain how this is supposed to relate to the doreturn logic in the code? Something seems not quite right about the move.
There are three triggers for doreturn==0 before this point: NotIssued Wrongbranch => exited already Withdrawn (depends on BlockReturnOfWithdrawnItems) Actually, NotIssued is my main target. So you are right that this change might adversely affect the Withdrawn case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AddReturn should always |AddReturn should clear |clear items.onloan |items.onloan for unissued | |items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 73409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73409&action=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73409|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74723&action=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial test count rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74723|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74995&action=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And another trivial rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74995|0 |1 is obsolete| | --- Comment #9 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 75290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75290&action=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Charles Farmer from comment #9)
Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about local use? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not we provide an update DB entry? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #11)
What about local use?
Can't imagine a working use in this scenario (without making much more changes). Does not seem something we should be dealing with here. If you have something in mind, please be more specific. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #12)
Should not we provide an update DB entry?
Yes, we could. Will add a few lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75290|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75694&action=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75695&action=edit Bug 20487: (QA follow-up) Requested db revision As requested in comment12, we can update these cases in a dbrev too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Checked out item, deleted issue record, ran dbrev. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased first patch too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Do we know how an item gets into this state in the first place? It feels like this solution may be hiding a bug further up the tree rather than resolving it...? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #18)
Do we know how an item gets into this state in the first place? It feels like this solution may be hiding a bug further up the tree rather than resolving it...?
I am not suspecting a bug here. Trigger might be related to database actions outside the interface ;) But what struck me is that checking in such an item did not clear the onload column. I think it just should; any user would expect it. I do not see an advantage in leaving it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75694|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76615&action=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75695|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76616&action=edit Bug 20487: (QA follow-up) Requested db revision As requested in comment12, we can update these cases in a dbrev too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Checked out item, deleted issue record, ran dbrev. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Simple rebase on Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76615|0 |1 is obsolete| | Attachment #76616|0 |1 is obsolete| | --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 78050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78050&action=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 78051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78051&action=edit Bug 20487: (QA follow-up) Requested db revision As requested in comment12, we can update these cases in a dbrev too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Checked out item, deleted issue record, ran dbrev. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Josef Moravec from comment #24)
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #28 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not to push to 17.11.x because UT changes does not apply easily and circulation is a hot module ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Fridolin SOMERS from comment #28)
I prefer not to push to 17.11.x because UT changes does not apply easily and circulation is a hot module ;)
What if I made it apply easy? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org