[Bug 15694] New: Date/time-last-modified not searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Bug ID: 15694 Summary: Date/time-last-modified not searchable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Searching Assignee: nengard@gmail.com Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org There is na index for Date/time-last-modified but the slash (/) can cause issues. This patch will add aliases for this field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 47398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47398&action=edit Bug 15694: Add aliases for date/time last modified This patch will add indexes for Date/time-last-modified. To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- This is my first ever patch like this so I welcome feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Maybe a better test plan for example: To reproduce the issue: -Choose a bib record and copy the date in 005 field -search under Date/time-last-modified:20160201094709.0 -No results found To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47398|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47512&action=edit [SIGNED-OFF]Bug 15694: Add aliases for date/time last modified This patch will add indexes for Date/time-last-modified. To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nicole, I think the files biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl need to be updated when a zebra index is added/deleted/modified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47561&action=edit Bug 15694: (followup)Update DOM index filter definitions Update for MARC21 biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl To test follow the previus test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Nicole, I think the files biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl need to be updated when a zebra index is added/deleted/modified.
Hi Jonathan and Nicole This really works without update the files. My question is why? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It does not work for me with only the first patch applied. The changes need to be made for normarc and unimarc as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Jonathan Druart from comment #8)
It does not work for me with only the first patch applied. The changes need to be made for normarc and unimarc as well.
Hi Jonathan It seems to be that NORMARC does not use this index. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #10 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47741&action=edit Bug 15694: (followup)Update DOM index for UNIMARC/biblios Update for UNIMARC biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl To test follow the first test plan in UNIMARC environment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Jason Burds <jburds@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jburds@dubuque.lib.ia.us --- Comment #11 from Jason Burds <jburds@dubuque.lib.ia.us> --- Tried a few times to get this to work. date-time-last-modified:DATE doesn't search for anything on the sandboxes. Are you able to search for a date modified on a record that's already there or does it require a reindex to fix the searching or just find new records? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jason, indexing patches are usually not testable on the sandboxes to my knowledge. On a dev installation you'd have to do a full reindex after copying index definition files into the correct place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #13 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Jason Burds from comment #11)
Tried a few times to get this to work.
date-time-last-modified:DATE doesn't search for anything on the sandboxes.
Are you able to search for a date modified on a record that's already there or does it require a reindex to fix the searching or just find new records?
Hi Jeson You need to reindex. For example I have a record in MARC21 with field 20160201110256.0 Apply patch reindex zebra and search again dtlm:20160201110256.0 or Date-time-last-modified:20160201110256.0 and the system retrieve my record. I don't know if you can reindex Zebra in sandboxes :( Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #14 from Frédéric Demians <frederic@tamil.fr> --- There is something wrong here. The 1st patch is enough. No reindexing is required since 'Date/time-last-modified' index is already defined. After adding an alias in ccl.properties (1st patch), and copying ccl.properties in the installed configuration, restarting the Zebra server is all you need to do to get working searches without prefix with ccl= -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #15 from Frédéric Demians <frederic@tamil.fr> --- You don't have to add a new index: <target_index>dtlm:w</target_index> 'dtlm' is just a CCL shortcut to the already existing index Date/time-last-modified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47561|0 |1 is obsolete| | --- Comment #16 from Frédéric Demians <frederic@tamil.fr> --- Comment on attachment 47561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47561 Bug 15694: (followup)Update DOM index filter definitions Not required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47741|0 |1 is obsolete| | --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- Comment on attachment 47741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47741 Bug 15694: (followup)Update DOM index for UNIMARC/biblios Not required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #18 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 48611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48611&action=edit Bug 15694: Add aliases for date/time last modified This patch will add indexes for Date/time-last-modified. To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm Hector signing-off. A simple Zebra server restart suffice to get working the searches on date-time-last-modified and dtlm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47512|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48611|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48991&action=edit Bug 15694: Add aliases for date/time last modified This patch will add indexes for Date/time-last-modified. To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm Hector signing-off. A simple Zebra server restart suffice to get working the searches on date-time-last-modified and dtlm. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Frédéric was right, sorry Héctor for the additional work :-/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #21 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org