[Bug 38155] New: Can't close invoices from invoices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Bug ID: 38155 Summary: Can't close invoices from invoices.pl Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Closing one or more invoices by using checkboxes at /acqui/invoices.pl isn't working on 24.05.03. To replicate: -In Acquisitions > Invoices, search for invoices using available filters or go go to a vendor's record and select Invoices -Select checkboxes for one or more open invoices, and click the 'Close selected invoices' button -Instead of closing the invoice(s), you're brought to one of the invoices you selected (not closed, and 'Close' checkbox isn't selected) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't close invoices from |Can't close invoices using |invoices.pl |checkboxes from invoices.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Joe Askins <jaskins@faylib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jaskins@faylib.org --- Comment #1 from Joe Askins <jaskins@faylib.org> --- Fayetteville Public Library noticed this issue shortly after our most recent upgrade. We would very much like this button's old functionality to return, as it's nice to be able to bulk-close invoices. We look forward to seeing this addressed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Version|24.05 |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Leann Craumer <lcraumer@aacpl.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lcraumer@aacpl.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu Status|NEW |CONFIRMED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Maura Stephens <maura.stephens@atu.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens@atu.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36246 Patch complexity|--- |Trivial patch Status|CONFIRMED |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36246 [Bug 36246] Have a centralized method for submitting a form via a link -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 175658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175658&action=edit Bug 38155: Fix Acquistions close selected invoices button This patch updates the data-op property of the button to be prefixed with cud- To test: 1. Add some invoices for a vendor 2. Got to Acquisitions->Invoices 3. Select multiple invoices using the checkbox 4. Click the 'Close selected invoices' button 5. Confirm it worked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org Blocks| |36192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #3 from David Nind <david@davidnind.com> --- Hi Brandan. I'm getting this error after the patch when I go to close the invoices: An error has occurred! Error 403 Programming error - op 'cud-close' must not start with 'cud-' for GET http://127.0.0.1:8081/intranet/acqui/invoice.pl?op=cud-close&invoiceid=3... (referer: http://127.0.0.1:8081/cgi-bin/koha/acqui/invoices.pl?invoicenumber=&shipmentdatefrom=&shipmentdateto=&billingdatefrom=&billingdateto=&isbneanissn=&title=&author=&publisher=&publicationyear=&branch=&op=do_search) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to David Nind from comment #3)
Hi Brandan.
I'm getting this error after the patch when I go to close the invoices:
An error has occurred! Error 403 Programming error - op 'cud-close' must not start with 'cud-' for GET
This is hard for me to test in ktd, do you have the steps to create invoices handy? I think for the link to work it needs some more attributes, probably at least data-method="post" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Brendan Lawlor from comment #4)
(In reply to David Nind from comment #3)
Hi Brandan.
I'm getting this error after the patch when I go to close the invoices:
An error has occurred! Error 403 Programming error - op 'cud-close' must not start with 'cud-' for GET
This is hard for me to test in ktd, do you have the steps to create invoices handy?
I think for the link to work it needs some more attributes, probably at least data-method="post"
I followed the test plan 8-) Steps to reproduce: 1. Apply the patch, restart everything (restart_all), clear your browser cache. 2. Acquisitions > go to a vendor page (click Search in the search vendors section). 3. Receive shipments 4. Create several invoices from here. (Even though the invoices have no data, I did check whether that was the issue by adding orders to a basket, closing the basket, and then receiving them properly, but I still got the same error.) 5. Acquisitions > Invoices > Search (no filter information entered). 6. Select a couple of the open invoices (tick boxes). 7. Click "Close selected invoices". 8. Error! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175658|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 175682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175682&action=edit Bug 38155: Fix Acquistions close selected invoices button This patch updates the closed selected invoices link button to use the form-submit.js method from bug 36246. The link needs to have a single data-invoiceid parameter, so the js on invoices.tt creates a comma separated list from the checkboxes. The list of invoiceid is split into an array in invoice.pl To test: 1. Add some invoices for a vendor using the 'receive shipments' button 2. Go to Acquisitions->Invoices 3. Select multiple invoices using the checkbox 4. Click the 'Close selected invoices' button 5. Confirm it works 6. Confirm closing individual invoices from the Actions button still works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 175683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175683&action=edit Bug 38155: Fix Acquisitions Reopen selected invoices button This patch updates the reopen selected invoices link button to use the form-submit.js method from bug 36246. The link needs to have a single data-invoiceid parameter, so the js on invoices.tt creates a comma separated list from the checkboxes. The list of invoiceid is split into an array in invoice.pl To test: 1. Add some invoices for a vendor using the 'receive shipments' button 2. Go to Acquisitions->Invoices 3. Select multiple invoices using the checkboxes 4. Click the 'Close selected invoices' button 5. Confirm it works 6. Go to the Closed invoices tab 7. Select multiple invoices using the checkboxes 8. Click the 'Reopen selected invoices' button 9. Confirm it works 6. Confirm reopening individual invoices from the Actions button still works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175682|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175777&action=edit Bug 38155: Fix Acquistions close selected invoices button This patch updates the closed selected invoices link button to use the form-submit.js method from bug 36246. The link needs to have a single data-invoiceid parameter, so the js on invoices.tt creates a comma separated list from the checkboxes. The list of invoiceid is split into an array in invoice.pl To test: 1. Add some invoices for a vendor using the 'receive shipments' button 2. Go to Acquisitions->Invoices 3. Select multiple invoices using the checkbox 4. Click the 'Close selected invoices' button 5. Confirm it works 6. Confirm closing individual invoices from the Actions button still works Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175683|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175778&action=edit Bug 38155: Fix Acquisitions Reopen selected invoices button This patch updates the reopen selected invoices link button to use the form-submit.js method from bug 36246. The link needs to have a single data-invoiceid parameter, so the js on invoices.tt creates a comma separated list from the checkboxes. The list of invoiceid is split into an array in invoice.pl To test: 1. Add some invoices for a vendor using the 'receive shipments' button 2. Go to Acquisitions->Invoices 3. Select multiple invoices using the checkboxes 4. Click the 'Close selected invoices' button 5. Confirm it works 6. Go to the Closed invoices tab 7. Select multiple invoices using the checkboxes 8. Click the 'Reopen selected invoices' button 9. Confirm it works 6. Confirm reopening individual invoices from the Actions button still works Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175777|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 175846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175846&action=edit Bug 38155: Fix Acquistions close selected invoices button This patch updates the closed selected invoices link button to use the form-submit.js method from bug 36246. The link needs to have a single data-invoiceid parameter, so the js on invoices.tt creates a comma separated list from the checkboxes. The list of invoiceid is split into an array in invoice.pl To test: 1. Add some invoices for a vendor using the 'receive shipments' button 2. Go to Acquisitions->Invoices 3. Select multiple invoices using the checkbox 4. Click the 'Close selected invoices' button 5. Confirm it works 6. Confirm closing individual invoices from the Actions button still works Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175778|0 |1 is obsolete| | --- Comment #11 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 175847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175847&action=edit Bug 38155: Fix Acquisitions Reopen selected invoices button This patch updates the reopen selected invoices link button to use the form-submit.js method from bug 36246. The link needs to have a single data-invoiceid parameter, so the js on invoices.tt creates a comma separated list from the checkboxes. The list of invoiceid is split into an array in invoice.pl To test: 1. Add some invoices for a vendor using the 'receive shipments' button 2. Go to Acquisitions->Invoices 3. Select multiple invoices using the checkboxes 4. Click the 'Close selected invoices' button 5. Confirm it works 6. Go to the Closed invoices tab 7. Select multiple invoices using the checkboxes 8. Click the 'Reopen selected invoices' button 9. Confirm it works 6. Confirm reopening individual invoices from the Actions button still works Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #12 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 175848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175848&action=edit Bug 38155: (QA follow-up) Fix TT filters and scalar context data-referer is the url for the current search page, to redirect back after performing the operation. Since it is a url, variables within this link all need to use the uri filter, not html or KohaDates. Also specify scalar context when splitting the input parameter to prevent param in list context warnings. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Cleaned up a few things in a follow-up, but otherwise it looks good! Thanks, Brendan! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #14 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Emily Lamancusa (emlam) from comment #13)
Cleaned up a few things in a follow-up, but otherwise it looks good! Thanks, Brendan! Passing QA
variables within this link all need to use the uri filter, not html or KohaDates.
Thanks for this info. I got this from copying the link formatting from the Actions drop down link (line 109) for close because the data-referer wasn't working because it was url encoded. It needed to be encoded before because it used window.location.href for the redirect. Should I file a new bug to change the filters in those Actions links to use uri instead of html?
Also specify scalar context when splitting the input parameter I need to read up on this and learn more Perl :)
Thanks, Emily! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #15 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Brendan Lawlor from comment #14)
(In reply to Emily Lamancusa (emlam) from comment #13)
variables within this link all need to use the uri filter, not html or KohaDates.
Thanks for this info. I got this from copying the link formatting from the Actions drop down link (line 109) for close because the data-referer wasn't working because it was url encoded. It needed to be encoded before because it used window.location.href for the redirect.
Should I file a new bug to change the filters in those Actions links to use uri instead of html?
Ah...yes, those are wrong too, though I think | html and | uri give the same output if the data doesn't have any special characters? More importantly, use uri instead of $KohaDates in the referer link - otherwise, the redirect after performing the operation will break if the original search included dates. For example, you'll get an internal server error if you do the following without my follow-up: 1. Add some vendor invoices 2. Go to Acquisitions > Invoices 3. Specify search filters for shipment to/from dates (that match at least some of your invoices) and search for invoices 4. Select some invoices and click "Close selected invoices" --> Internal server error! "The given date <date> does not match the date format (iso)" There seem to be a lot of places in invoices.tt that are passing locally-formatted dates as parameters, but they've been that way for years...I wonder if the processing changed at some point? Or have the internal server errors just gone quietly unnoticed until now? =/
Also specify scalar context when splitting the input parameter I need to read up on this and learn more Perl :)
Thanks, Emily!
:) Thank you too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #16 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Also full disclosure, it helps to have a general understanding of what scalar context vs list context means in Perl...but mostly I caught that last bit because I found bug 29771 while checking if we had precedent for sending multiple values as a single comma-separated parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 [Bug 38766] Opening, closing, or deleting and invoice from the Action drop-down can cause internal server error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes closing and release notes| |reopening of invoices | |(Acquisitions > [Vendor] > | |Invoices). Previously, the | |invoices you selected | |weren't closed or reopened | |when clicking on the | |"Close/Reopen selected | |invoices" button - one of | |the selected invoices was | |opened instead. (This is | |related to the CSRF changes | |added in Koha 24.05 to | |improve form security.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #18 from mteal@greenvillelibrary.org --- It would be great if this could be backported to 24.11. Closing invoices individually takes significantly longer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #19 from Joe Askins <jaskins@faylib.org> --- Seconding Greenville's desire to see this backported. This loss of functionality negatively affected our workflow, so we'd love to get it back ASAP. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 --- Comment #20 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes closing and |This fixes closing and release notes|reopening of invoices |reopening of invoices |(Acquisitions > [Vendor] > |(Acquisitions > [Vendor] > |Invoices). Previously, the |Invoices). Previously, the |invoices you selected |invoices you selected |weren't closed or reopened |weren't closed or reopened |when clicking on the |when clicking on the |"Close/Reopen selected |"Close/Reopen selected |invoices" button - one of |invoices" button - all that |the selected invoices was |happened was that one of |opened instead. (This is |the selected invoices was |related to the CSRF changes |displayed instead. (This is |added in Koha 24.05 to |related to the CSRF changes |improve form security.) |added in Koha 24.05 to | |improve form security.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Pushed to oldstable Version(s)|25.05.00,24.11.02 |25.05.00,24.11.02,24.05.09 released in| | --- Comment #21 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Applied to 24.05.x for 24.05.09-1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36246 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #23 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix (for a regression too), nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org