[Bug 9935] New: Social icons missing in CSSR theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Bug ID: 9935 Summary: Social icons missing in CSSR theme Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolyn.somers@biblibre.com When using CSSR theme, opac.css is missing css rules for social networks Facebook, LinkedIn ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16926&action=edit Proposed patch See commit comment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16926|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 16954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16954&action=edit Bug 9935 - Social icons missing in CSSR theme When using CSSR theme, opac.css is missing css rules for social networks Facebook, LinkedIn ... This patch copies css rules related to social netxork from prog theme to cssr theme. Also copies social-sprite.png image. Test plan : - Set CSSR theme : syspref opacthemes=ccsr and opaccolorstylesheet=colors.css - Set syspref SocialNetworks=Enable - Go to a detail page at OPAC => check that social links are icons : Facebook, LinkedIn, Delicious, Send by email, Google Plus and Tweeter Signed-off-by: Liz Rea <liz@catalyst.net.nz> Social icons now showing, thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Add missing icons for the social networks feature using CSSR theme. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16954|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16973&action=edit Bug 9935 - Social icons missing in CSSR theme When using CSSR theme, opac.css is missing css rules for social networks Facebook, LinkedIn ... This patch copies css rules related to social netxork from prog theme to cssr theme. Also copies social-sprite.png image. Test plan : - Set CSSR theme : syspref opacthemes=ccsr and opaccolorstylesheet=colors.css - Set syspref SocialNetworks=Enable - Go to a detail page at OPAC => check that social links are icons : Facebook, LinkedIn, Delicious, Send by email, Google Plus and Tweeter Signed-off-by: Liz Rea <liz@catalyst.net.nz> Social icons now showing, thanks! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9935 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- *** Bug 9193 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org