[Bug 24588] New: Prevent e-mails from Koha to be flagged as spam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Bug ID: 24588 Summary: Prevent e-mails from Koha to be flagged as spam Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: ulrich.kleiber@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Set the e-mail headers Mailer-X und MessageID by Koha, to gain a better positive score from the spam filter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #1 from Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> --- Created attachment 98430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98430&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Assignee|koha-bugs@lists.koha-commun |ulrich.kleiber@bsz-bw.de |ity.org | Status|ASSIGNED |Needs Signoff CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98430|0 |1 is obsolete| | --- Comment #2 from Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> --- Created attachment 98441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98441&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Please add a commit message with a test plan: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98441|0 |1 is obsolete| | --- Comment #4 from Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> --- Created attachment 98484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98484&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam Set the e-mail headers Mailer-X and MessageID by Koha, to gain a better positive score from the spam filter. To test: 1) Let Koha send an e-mail message. 2) Check the header of this e-mail message with your e-mail client. There shoud be no X-Mailer header with value 'Koha'. If there is an MessageID header, it is probably set by the MSA, e.g. Exim. Example: Message-Id: <E1iyZRY-0006XT-0t@FQDN> 3) Apply patch. 4) Repeat step 1. 5) Check the header of the new e-mail message with your e-mail client. There shoud be a X-Mailer header with value 'Koha' and a MessageID header with a value set by Koha. Example: X-Mailer: Koha Message-Id: <15807387030.B731e.18490@FQDN> 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98484|0 |1 is obsolete| | --- Comment #5 from Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> --- Created attachment 98489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98489&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam Set the e-mail headers Mailer-X and MessageID by Koha, to gain a better positive score from the spam filter. To test: 1) Let Koha send an e-mail message. 2) Check the header of this e-mail message with your e-mail client. There should be no X-Mailer header with value 'Koha'. If there is an MessageID header, it is probably set by the MSA, e.g. Exim. Example: Message-Id: <E1iyZRY-0006XT-0t@FQDN> 3) Apply patch. 4) Repeat step 1. 5) Check the header of the new e-mail message with your e-mail client. There should be a X-Mailer header with value 'Koha' and a MessageID header with a value set by Koha. Example: X-Mailer: Koha Message-Id: <15807387030.B731e.18490@FQDN> 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Ulrich :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98489|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98518&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam Set the e-mail headers Mailer-X and MessageID by Koha, to gain a better positive score from the spam filter. To test: 1) Let Koha send an e-mail message. 2) Check the header of this e-mail message with your e-mail client. There should be no X-Mailer header with value 'Koha'. If there is an MessageID header, it is probably set by the MSA, e.g. Exim. Example: Message-Id: <E1iyZRY-0006XT-0t@FQDN> 3) Apply patch. 4) Repeat step 1. 5) Check the header of the new e-mail message with your e-mail client. There should be a X-Mailer header with value 'Koha' and a MessageID header with a value set by Koha. Example: X-Mailer: Koha Message-Id: <15807387030.B731e.18490@FQDN> 6) Sign off. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, no regressions found and it moves us closer to the ever-moving target that is 'email best practice'. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #9 from Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> --- Thanks Martin :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Should not we want the X-Mailer value to be more specific? Like with the library name for instance? 2. I suspect Email::MessageID to be "buggy" under plack. My understanding (may be wrong!): "my %uniq" is supposed to contain " $epoch => $nb_occ " with $nb_occ the number of time $epoch has been associated to an id. Say the following Message-ID generated by the module: 15822877730.63BC8.7268@df2c0b4bf86c 1582287773 is $epoch, 0 is the first occurrence 63BC8 is a random value 7268@df2c0b4bf86c is the hostname The next ID generated in the same second will be 15822877731. If another script is ran at the same time, we will have this "uniq" 15822877730 used several time. Short version: All of that to say that we are safe as there is the random value that is concatenated, it will be bad luck to get twice the same generated random value, in the same second, with 2 scripts . But it is possible :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #10) You can really forget 2. as the same behavior exists without Plack (the variable will obviously not be shared). I guess that's why the author added the randomly generated string. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found this explanation: "the X-Mailer line in the email header tells you what program was used to draft and send the original email" Example: X-Mailer: Mozilla 4.05 [de] (Win95; I) Koha seems accurate enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98518|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99384&action=edit Bug 24588: Prevent e-mails from Koha to be flagged as spam Set the e-mail headers Mailer-X and MessageID by Koha, to gain a better positive score from the spam filter. To test: 1) Let Koha send an e-mail message. 2) Check the header of this e-mail message with your e-mail client. There should be no X-Mailer header with value 'Koha'. If there is an MessageID header, it is probably set by the MSA, e.g. Exim. Example: Message-Id: <E1iyZRY-0006XT-0t@FQDN> 3) Apply patch. 4) Repeat step 1. 5) Check the header of the new e-mail message with your e-mail client. There should be a X-Mailer header with value 'Koha' and a MessageID header with a value set by Koha. Example: X-Mailer: Koha Message-Id: <15807387030.B731e.18490@FQDN> 6) Sign off. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent e-mails from Koha |Set `Mailer-X` and |to be flagged as spam |`MessageID` mail headers to | |reduce the likelihood of | |Koha mail being marked as | |spam. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set `Mailer-X` and |Set `Mailer-X` and |`MessageID` mail headers to |`MessageID` mail headers to |reduce the likelihood of |reduce the likelihood of |Koha mail being marked as |Koha mail being marked as |spam. |spam -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24588 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Notices |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org