[Bug 39864] New: Cannot save Automatic item modifications by age rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Bug ID: 39864 Summary: Cannot save Automatic item modifications by age rules Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 38714 To reproduce: 1. Go to Cataloging > Automatic item modifications by age 2. Click Edit rules 3. Click Add rule 4. Enter some values, such as: age -> 365 age field -> items.dataaccessioned substitution -> items.withdrawn = 1 5. Click Save --> Nothing happens, and the save button remains highlighted Git bisect points to bug 38714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714 [Bug 38714] Adjust templates for prettier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Ah, it's because there are two separate TT sections that check if op = edit_form, with the "save" button in the first section and the actual form fields in the second section. The opening <form> tag was in the first TT IF block, and the closing </form> tag was in the second TT IF block farther down the page. This is not allowed as of 38714, so the opening <form> tag was moved into the second TT IF block...which left the save button out of the form! Hopefully this won't be too big of a refactor to fix... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority Summary|Cannot save Automatic item |Cannot save automatic item |modifications by age rules |modifications by age rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182172&action=edit Bug 39864: Move save button back into form The save button for automatic item modification rules got moved outside of the form during the refactor for bug 38714. This happened because the form was spread between two separate IF blocks that checked the same condition, which is no longer allowed as of 38714. This patch consolidates the conditional blocks and moves the submit button back inside its form. To test: 1. Go to Cataloguing > Item modifications by age 2. Click Add Rules, and then Add Rule to create a new rule 3. Fill in some reasonable values, for example: Age in days: 365 Age field: items.itemlost_on Substitutions: items.withdrawn = 1 4. Click save --> Nothing happens! 5. Apply patch, refresh, the page, and fill values in again if needed 6. Click save again --> The rule is saved! 7. Confirm the Edit rules, Add rule, and Cancel buttons still work i. Click Edit rules --> The rule you just created should now be editable ii. Click Add rule --> A new form for a second rule should be added to the page iii. Click Cancel --> The change is cancelled and the page returns to "List of rules" view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182172|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182226&action=edit Bug 39864: Move save button back into form The save button for automatic item modification rules got moved outside of the form during the refactor for bug 38714. This happened because the form was spread between two separate IF blocks that checked the same condition, which is no longer allowed as of 38714. This patch consolidates the conditional blocks and moves the submit button back inside its form. To test: 1. Go to Cataloguing > Item modifications by age 2. Click Add Rules, and then Add Rule to create a new rule 3. Fill in some reasonable values, for example: Age in days: 365 Age field: items.itemlost_on Substitutions: items.withdrawn = 1 4. Click save --> Nothing happens! 5. Apply patch, refresh, the page, and fill values in again if needed 6. Click save again --> The rule is saved! 7. Confirm the Edit rules, Add rule, and Cancel buttons still work i. Click Edit rules --> The rule you just created should now be editable ii. Click Add rule --> A new form for a second rule should be added to the page iii. Click Cancel --> The change is cancelled and the page returns to "List of rules" view Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182226|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182251&action=edit Bug 39864: Move save button back into form The save button for automatic item modification rules got moved outside of the form during the refactor for bug 38714. This happened because the form was spread between two separate IF blocks that checked the same condition, which is no longer allowed as of 38714. This patch consolidates the conditional blocks and moves the submit button back inside its form. To test: 1. Go to Cataloguing > Item modifications by age 2. Click Add Rules, and then Add Rule to create a new rule 3. Fill in some reasonable values, for example: Age in days: 365 Age field: items.itemlost_on Substitutions: items.withdrawn = 1 4. Click save --> Nothing happens! 5. Apply patch, refresh, the page, and fill values in again if needed 6. Click save again --> The rule is saved! 7. Confirm the Edit rules, Add rule, and Cancel buttons still work i. Click Edit rules --> The rule you just created should now be editable ii. Click Add rule --> A new form for a second rule should be added to the page iii. Click Cancel --> The change is cancelled and the page returns to "List of rules" view Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182251|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182252&action=edit Bug 39864: Move save button back into form The save button for automatic item modification rules got moved outside of the form during the refactor for bug 38714. This happened because the form was spread between two separate IF blocks that checked the same condition, which is no longer allowed as of 38714. This patch consolidates the conditional blocks and moves the submit button back inside its form. To test: 1. Go to Cataloguing > Item modifications by age 2. Click Add Rules, and then Add Rule to create a new rule 3. Fill in some reasonable values, for example: Age in days: 365 Age field: items.itemlost_on Substitutions: items.withdrawn = 1 4. Click save --> Nothing happens! 5. Apply patch, refresh, the page, and fill values in again if needed 6. Click save again --> The rule is saved! 7. Confirm the Edit rules, Add rule, and Cancel buttons still work i. Click Edit rules --> The rule you just created should now be editable ii. Click Add rule --> A new form for a second rule should be added to the page iii. Click Cancel --> The change is cancelled and the page returns to "List of rules" view Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Haha, we clashed.. I'll obsolete mine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182251|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- I dont reproduce on 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix to restore expected behaviour. Noting to add or edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org