https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33349 --- Comment #1 from paxed <pasi.kallinen@koha-suomi.fi> --- Created attachment 148792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148792&action=edit Bug 33349: Patron Attributes don't have identifying information in intranet Bug 33349: Patron Attributes don't have identifying information in intranet Patron Attributes have no identifying info in the template page, no stable ID to style or effect with javascript, so when new patron attributes are added or removed, their order may change, requiring extra work to make sure CSS and javascript don't change the wrong patron attributes. Test plan: 0) in intranet: 1) create patron attribute types with different codes: "TESTPA", "test2 PA", and "At%tr:X" 2) add those patron attributes to a patron, with some values 3) in a browser, go to a patron information page, and inspect the page source where the patron attributes are 4) note how the PA entries have no identifying information usable to css or javascript 5) apply patch 6) inspect the page source, note how the patron attributes have data-pa_code -value with the following values: "TESTPA", "test2PA", and "AttrX" (The attribute codes are sanitized to remove possibly problematic characters; those shouldn't be used in PA codes anyway) 7) Go to the page where you edit the patron's Additional attributes and identifiers, and repeat 6 for that page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33349 paxed <pasi.kallinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26206 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33349 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148792|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148811&action=edit Bug 33349: Patron Attributes don't have identifying information in intranet Patron Attributes have no identifying info in the template page, no stable ID to style or effect with javascript, so when new patron attributes are added or removed, their order may change, requiring extra work to make sure CSS and javascript don't change the wrong patron attributes. Test plan: 0) in intranet: 1) create patron attribute types with different codes: "TESTPA", "test2 PA", and "At%tr:X" 2) add those patron attributes to a patron, with some values 3) in a browser, go to a patron information page, and inspect the page source where the patron attributes are 4) note how the PA entries have no identifying information usable to css or javascript 5) apply patch 6) inspect the page source, note how the patron attributes have data-pa_code -value with the following values: "TESTPA", "test2PA", and "AttrX" (The attribute codes are sanitized to remove possibly problematic characters; those shouldn't be used in PA codes anyway) 7) Go to the page where you edit the patron's Additional attributes and identifiers, and repeat 6 for that page. Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33349 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148811|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148987&action=edit Bug 33349: Patron Attributes don't have identifying information in intranet Patron Attributes have no identifying info in the template page, no stable ID to style or effect with javascript, so when new patron attributes are added or removed, their order may change, requiring extra work to make sure CSS and javascript don't change the wrong patron attributes. Test plan: 0) in intranet: 1) create patron attribute types with different codes: "TESTPA", "test2 PA", and "At%tr:X" 2) add those patron attributes to a patron, with some values 3) in a browser, go to a patron information page, and inspect the page source where the patron attributes are 4) note how the PA entries have no identifying information usable to css or javascript 5) apply patch 6) inspect the page source, note how the patron attributes have data-pa_code -value with the following values: "TESTPA", "test2PA", and "AttrX" (The attribute codes are sanitized to remove possibly problematic characters; those shouldn't be used in PA codes anyway) 7) Go to the page where you edit the patron's Additional attributes and identifiers, and repeat 6 for that page. Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron Attributes don't |Patron attributes don't |have identifying info in |have identifying info in |intranet |the staff interface -- You are receiving this mail because: You are watching all bug changes.