[Bug 21018] New: OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Bug ID: 21018 Summary: OPAC Resource URL Broken if Tracklinks is enabled Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mkpelletier@gmail.com QA Contact: testopia@bugs.koha-community.org With Tracklinks enabled in configuration (anonymous or otherwise), URI's in 952u return a koha 404 error. However, if the link is also recorded in 856u, the 952u link works. As soon as you turn off tracklinks, 952u URI's function normally. I tested the above only on https URI's. Perhaps this is related to #18714 earlier marked as invalid? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19847 [Bug 19847] tracklinks.pl accepts any url from a parameter for proxying -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76569&action=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76569|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76601&action=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Important note: We certainly need to add an index on this column to boost this query. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #3)
Important note: We certainly need to add an index on this column to boost this query.
Do you mean items.uri and deleteditems.uri? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
Important note: We certainly need to add an index on this column to boost this query.
Koha::Items->search( { uri => $uri } )->count You need to add biblionumber to limit the results. No need to scan the whole table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76863&action=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #4)
(In reply to Jonathan Druart from comment #3)
Important note: We certainly need to add an index on this column to boost this query.
Do you mean items.uri and deleteditems.uri?
only items.uri, but with the last patch it's not needed. (In reply to Marcel de Rooy from comment #5)
(In reply to Jonathan Druart from comment #3)
Important note: We certainly need to add an index on this column to boost this query.
Koha::Items->search( { uri => $uri } )->count
You need to add biblionumber to limit the results. No need to scan the whole table.
Oops, yes you are right. It's itemnumber actually. Maybe we should add more tests here, items.uri check should only be if itemnumber is passed. But I would prefer to not complexity it now as it's improvement and not bug fixing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21088 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- This isn't working for me. I'm still getting a 404 error after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Mathieu Pelletier <mkpelletier@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Mathieu Pelletier <mkpelletier@gmail.com> --- This does work for me using the second patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 21088 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76601|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77413&action=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76863|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77414&action=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With both patches it works for me as well. I have the 404 for before applying the patch and correct redirects after. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77413|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77519&action=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77414|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77520&action=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well for me and I can't see any regressions.. passes the qa scripts too. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #20 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for 17.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22703 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org