https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- BTW : This JavaScript code is a mix of JQuery and old style. It seams it is not very solid and several parts are repeated, like :

var re = new RegExp('^subfield' + subfield_name,'g'); var subfields = $(field_start).children('ul').children('li').filter( function() { return this.id.match(re); }); This would need a big revamping.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123819&action=edit Bug 28853: Fix authority plugin when textarea in biblio record editor In biblio record editor, when subfield value contains more than 100 characters the editor uses a textarea instead of an input. On a field using authority plugin, this breaks the JavaScript because it only searches for input tags : In /koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt :

this.getElementsByTagName('input')[1].value = values[i];

Test plan : 1) Prepare : 1.1) Create a new biblio record this a field using authority plugin, for example 606 1.2) Do not use authority plugin but enter in 606$x more than 100 chars 1.3) Save record 1.4) Create a new autority for 606 biblio field with $a and a $x containing more than 100 chars 2) Test 1 : 2.1) Edit again the biblio record, you see a text area for 606$x 2.2) Use authority plugin on field 606 2.3) Search and choose the new autority 2.4) Check $a,$x and $9 are well filled 3) Test 2 : 3.1) Empty field 606 3.2) Create a second $x subfield and fill it with a random value 3.3) Use authority plugin again on field 606 3.4) Search and choose the new autority 3.5) Check $a and $9 are well filled 3.6) Check first $x contains the value from autority and second $x is empty -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps@biblibre.c | |om --- Comment #4 from Florian <florian.bontemps@biblibre.com> --- I know Fridolin and i work in the same company but this patch has gone unattended for a couple months now. Feel free to ask for another signoff if needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127348|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128161&action=edit Bug 28853: Fix authority plugin when textarea in biblio record editor In biblio record editor, when subfield value contains more than 100 characters the editor uses a textarea instead of an input. On a field using authority plugin, this breaks the JavaScript because it only searches for input tags : In /koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt :

this.getElementsByTagName('input')[1].value = values[i];

Test plan : 1) Prepare : 1.1) Create a new biblio record with a field using authority plugin, for example 606 1.2) Do not use authority plugin but enter in 606$x more than 100 chars 1.3) Save record 1.4) Create a new autority for 606 biblio field with $a and a $x containing more than 100 chars 2) Test 1 : 2.1) Edit again the biblio record, you see a text area for 606$x 2.2) Use authority plugin on field 606 2.3) Search and choose the new autority 2.4) Check $a,$x and $9 are well filled 3) Test 2 : 3.1) Empty field 606 3.2) Create a second $x subfield and fill it with a random value 3.3) Use authority plugin again on field 606 3.4) Search and choose the new autority 3.5) Check $a and $9 are well filled 3.6) Check first $x contains the value from autority and second $x is empty Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes.