[Bug 42259] New: Accessing deleted ILL is 500 error & not 404
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42259 Bug ID: 42259 Summary: Accessing deleted ILL is 500 error & not 404 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com I noticed this because I saw a "request to delete ILL request" email and clicked the link to view the request, but another staff member had already deleted it. You receive a 500 server error due to a missing template: Template process failed: file error - : not found at /kohadevbox/koha/C4/Templates.pm line 146 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 146 in C4::Output::output_and_exit at /kohadevbox/koha/C4/Output.pm line 384 in (eval) at /kohadevbox/koha/ill/ill-requests.pl line 127 ... This is the `output_and_exit()` call passing an 'unknown_ill_request' error after checking that the request doesn't exist. I see a `[% CASE 'unknown_ill_request' %]` line in koha-tmpl/intranet-tmpl/prog/en/includes/blocking_errors.inc so it seems like Koha should be set up to handle this error gracefully. Perhaps an issue with the ill-requests.tt template. Ideally, the response would both say "ILL request not found" and be a 404. I looked at how other templates handle this but couldn't quite figure it out. I see that some missing objects (biblio, patron) return HTTP 200 which seems semantically incorrect. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42259 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Duplicate of bug 41944? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42259 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- *** This bug has been marked as a duplicate of bug 41944 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org