[Bug 12150] New: Use more placeholders in translatable javascript strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Bug ID: 12150 Summary: Use more placeholders in translatable javascript strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Created attachment 27697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27697&action=edit Make more translatable javascript strings in intranet use the js string formatter. Make more translatable javascript strings in intranet use the js string formatter. This is continuation from bug 12138, which missed some translatable javascript strings. Also fixes couple untranslatable js strings (in datatables.js), and two translation marker mistakes (in datatables.js and preferences.js) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Is ready to be signed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Bernardo Gonzalez Kriegel from comment #1)
Is ready to be signed?
Yes, sorry, forgot to change the status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@pttk.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This needs a detailed test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27697|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28733&action=edit [SIGNED-OFF] Bug 12150 - Use more javascript string formatting in intranet for translated strings. http://bugs.koha-community.org/show_bug.cgi?id=12150 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No bug number on description No commit message No test plan No koha-qa errors I only signed this because it's useful for translations but we can live without it, so is up to QA now Tested some easy messages (e.g. syspref saving), and updated PO files to check new strings. Inspected the code, I think that there are no errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28733|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28774&action=edit Bug 12150 - Use more javascript string formatting in intranet for translated strings. http://bugs.koha-community.org/show_bug.cgi?id=12150 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No bug number on description No commit message No test plan No koha-qa errors I only signed this because it's useful for translations but we can live without it, so is up to QA now Tested some easy messages (e.g. syspref saving), and updated PO files to check new strings. Inspected the code, I think that there are no errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28775&action=edit Bug 12150: Add missing space and correct innerHTML typo The previous patch forgot to add a space between the string "Edit action" and the placeholder. Trying to test it, I found a typo: innerhtml does not exist, it should be innerHTML. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- I didn't test everything, but all looks good. It would be great to have the same kind of patch for the opac bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- No regressions found, patches pushed to master. Thanks paxed! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org