[Bug 29882] New: remove unrequired package definitions in list-deps script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Bug ID: 29882 Summary: remove unrequired package definitions in list-deps script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com to test... - apply patch, rebuild new package - install new koha-common pkg on successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 129462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129462&action=edit Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129462|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 139814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139814&action=edit Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully Signed-off-by: Magnus Enger <magnus@libriotech.no> I did not build packages, just grep'ed the source to check that these modules are no longer used. Please set back to "Needs signoff" if this is not considered good enough. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|remove unrequired package |Remove unrequired package |definitions in list-deps |definitions in list-deps |script |script -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Had a look, but cannot build a package to try and removing Mojolicious and Swagger appears a little counter-intuitive. Leaving to another QA person! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I take it that this is due to these deps being picked up out of the cpanfile? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to David Cook from comment #4)
I take it that this is due to these deps being picked up out of the cpanfile?
yes correct, both modules are referenced the cpanfile requires 'Mojolicious', '8.12'; requires 'Mojolicious::Plugin::OpenAPI', '2.16'; ps: swagger2 has been renamed to openapi :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139814|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140176&action=edit Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully Signed-off-by: Magnus Enger <magnus@libriotech.no> I did not build packages, just grep'ed the source to check that these modules are no longer used. Please set back to "Needs signoff" if this is not considered good enough. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org