[Bug 38216] New: Objects.t failing on D10 and U20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 Bug ID: 38216 Summary: Objects.t failing on D10 and U20 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org t/db_dependent/Koha/REST/Plugin/Objects.t .. 18/18 # Failed test 'No tests run for subtest "date handling"' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 1041. Can't locate object method "rfc3339" via package "DateTime" at t/db_dependent/Koha/REST/Plugin/Objects.t line 1024. # Looks like your test exited with 255 just after 18. t/db_dependent/Koha/REST/Plugin/Objects.t .. Dubious, test returned 255 (wstat 65280, 0xff00) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37902 [Bug 37902] Timezone ignored when passing rfc3339 formatted date (search 'q') -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- DateTime->rfc3339 has been added to DateTime 1.53 https://github.com/houseabsolute/DateTime.pm/blob/master/Changes """ 1.53 2020-11-08 - Added a $dt->rfc3339 method. Based on discussion in GH #109 by worthmine. """ D10 has 1.50 U20 has 1.51 D10 - "Buster also has benefited from Long Term Support (LTS) until 30th June, 2024." Ubuntu 20.04 Focal has standard support until April 2025 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Only the tests are failing. We could add a silly test to skip those tests if DateTime does not have rfc3339. Another, better, idea? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So the Debian version is end of life and the Ubuntu has a bit more support to go, right? So we don't need to worry about Debian then. What happens in the GUI if one encounters one of these cases? And should we mark the patches for not backporting to stable releases? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #3)
So the Debian version is end of life and the Ubuntu has a bit more support to go, right? So we don't need to worry about Debian then.
What happens in the GUI if one encounters one of these cases?
By "Only the tests are failing." I meant that this only impacts the tests. Nothing else if using ->rfc3339 *yet*.
And should we mark the patches for not backporting to stable releases?
I don't think it should be backported too fast anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Isn't Bug 37905 - Correctly fix the "last hour" filter on the job list using it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #5)
Isn't Bug 37905 - Correctly fix the "last hour" filter on the job list using it?
Where? There are only 2 occurrences % git grep '\->rfc3339' t/db_dependent/Koha/REST/Plugin/Objects.t: my $q = encode_json( { enqueued_on => $one_hour_ago->rfc3339, borrowernumber => $patron->id } ); t/db_dependent/Koha/REST/Plugin/Objects.t: enqueued_on => [ { '>' => $now->rfc3339 }, { '=' => $one_hour_ago->rfc3339 } ], -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #6)
(In reply to Katrin Fischer from comment #5)
Isn't Bug 37905 - Correctly fix the "last hour" filter on the job list using it?
Where?
There are only 2 occurrences
% git grep '\->rfc3339' t/db_dependent/Koha/REST/Plugin/Objects.t: my $q = encode_json( { enqueued_on => $one_hour_ago->rfc3339, borrowernumber => $patron->id } ); t/db_dependent/Koha/REST/Plugin/Objects.t: enqueued_on => [ { '>' => $now->rfc3339 }, { '=' => $one_hour_ago->rfc3339 } ],
Interesting, it was a dependency, I hadn't check the code (too busy today) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Bug 37902 fixed the tz handling server-side. Bug 37905 corrected how to request the server (using a rfc3339 formatted date). The DateTime->rfc3339 method is only used in tests for comparison. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #8)
Bug 37902 fixed the tz handling server-side. Bug 37905 corrected how to request the server (using a rfc3339 formatted date).
The DateTime->rfc3339 method is only used in tests for comparison.
"Fixing" the tests for now seems valid then. But maybe we should add some kind of note to not use it ... before 25.05? Strange situation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38216 Bug 38216 depends on bug 37902, which changed state. Bug 37902 Summary: Timezone ignored when passing rfc3339 formatted date (search 'q') https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37902 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org