[Bug 7157] New: Improve the j2a.pl cronjob
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Bug #: 7157 Summary: Improve the j2a.pl cronjob Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Command-line Utilities AssignedTo: gmcharlt@gmail.com ReportedBy: wizzyrea@gmail.com QAContact: koha-bugs@lists.koha-community.org The existing cronjob for transitioning juvenile patron types to adult patron types is limited to the point of uselessness. It needs to do the following: - Calculate update date based on the upper age limit defined in the patron categories. - Allow libraries to work on all branches or only one. - Allow libraries to specify which patron category to update child categories to. - Allow libraries to specify a single Child patron category to update to an adult category. Nice to have, but not essential: - Have a test mode to display what transforms would be done on the database without executing the changes. - email changes completed to the admin email address for the branch upon job execution. - allow more granular transitions - a "toddler" category to a "child" category, for example - one wouldn't need to change the patron type to A in this case. - allow specifying multiple from and to categories. - a way to do this from the UI, working in about the same way. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> 2011-11-04 18:41:17 UTC --- Created attachment 6209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6209 Bug 7157 - Improve the j2a.pl cronjob - Calculates updates date based on the upper age limit defined in the patron categories. - Allows libraries to work on all branches or only one. - Allows libraries to specify which Adult patron category to update child categories to. - Allows libraries to specify a single Child patron category to update to an adult category. - Has a test mode to display what transforms would be done on the database without executing the changes. Includes improved help, copyright statement, and uses warnings. To test: Create two patron categories, a child and an adult category. Make sure they have an upper age limit. Create or modify some patrons in multiple branches that fall into the category of "my birthdate is less than or equal to today's date minus the upper age limit" 1. Run the script with no flags - nothing should happen, it will suggest you try the -help flag. 2. Run the script with the -help flag - you should see the help 3. Run the script with the -fromcat=<child category> -tocat=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are. 4. Run the script with the -fromcat=<child category> -tocat=<adult category> -branch=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are. 5. Run the script with the -fromcat=<child category> -tocat=<adult category> -v -branch=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated. 6. Run the script with the -fromcat=<child category> -tocat=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches. 7. Run the script without the -v flag, if you care what the non-verbose output looks like. There is more this script could do, please feel free to take it and run. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |wizzyrea@gmail.com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |wizzyrea@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6209|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-07 23:36:09 UTC --- Created attachment 6250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6250 Bug 7157 - Improve the j2a.pl cronjob - Calculates updates date based on the upper age limit defined in the patron categories. - Allows libraries to work on all branches or only one. - Allows libraries to specify which Adult patron category to update child categories to. - Allows libraries to specify a single Child patron category to update to an adult category. - Has a test mode to display what transforms would be done on the database without executing the changes. Includes improved help, copyright statement, and uses warnings. To test: Create two patron categories, a child and an adult category. Make sure they have an upper age limit. Create or modify some patrons in multiple branches that fall into the category of "my birthdate is less than or equal to today's date minus the upper age limit" 1. Run the script with no flags - nothing should happen, it will suggest you try the -help flag. 2. Run the script with the -help flag - you should see the help 3. Run the script with the -fromcat=<child category> -tocat=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are. 4. Run the script with the -fromcat=<child category> -tocat=<adult category> -branch=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are. 5. Run the script with the -fromcat=<child category> -tocat=<adult category> -v -branch=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated. 6. Run the script with the -fromcat=<child category> -tocat=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches. 7. Run the script without the -v flag, if you care what the non-verbose output looks like. There is more this script could do, please feel free to take it and run. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|rel_3_8 |master QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Signed Off |Passed QA --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-12 13:00:16 UTC --- QA Comment: Code looks good. Did not test it, but has a solid signoff. Marked as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-12 13:00:55 UTC --- (In reply to comment #3)
QA Comment: Code looks good. Did not test it, but has a solid signoff. Marked as Passed QA. Applies, but with whitespace errors.
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Passed QA |Failed QA --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-12 14:47:44 UTC --- A small problem not noticed by Marcel or Chris: the syntax of the parameters: http://search.cpan.org/~jv/Getopt-Long-2.38/lib/Getopt/Long.pm => 1 character parameters are called with a single -, others are with -- the -man means in fact -m -a -n the -help means -h -e -l -p You should have written --help and --man Your script is working, but: * a new option/parameter may result in strange results that will be hard to understand * cronjob scripts are with -- for long options So, please resubmit your patch with help=s and updated documentation (great script though !) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> 2011-12-12 23:01:44 UTC --- Created attachment 6723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6723 Bug 7157 - Improve the j2a.pl cronjob - Calculates updates date based on the upper age limit defined in the patron categories. - Allows libraries to work on all branches or only one. - Allows libraries to specify which Adult patron category to update child categories to. - Allows libraries to specify a single Child patron category to update to an adult category. - Has a test mode to display what transforms would be done on the database without executing the changes. Includes improved help, copyright statement, and uses warnings. Also incorporates Paul's suggestions regarding --help and --man. To test: Create two patron categories, a child and an adult category. Make sure they have an upper age limit. Create or modify some patrons in multiple branches that fall into the category of "my birthdate is less than or equal to today's date minus the upper age limit" 1. Run the script with no flags - nothing should happen, it will suggest you try the -help flag. 2. Run the script with the -help flag - you should see the help 3. Run the script with the -fromcat=<child category> -tocat=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are. 4. Run the script with the -fromcat=<child category> -tocat=<adult category> -branch=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are. 5. Run the script with the -fromcat=<child category> -tocat=<adult category> -v -branch=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated. 6. Run the script with the -fromcat=<child category> -tocat=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches. 7. Run the script without the -v flag, if you care what the non-verbose output looks like. Known limitation - if you give it an unknown tocat, it will fail with a rather ugly error. I'm going to fix that but in another patch. There is more this script could do, please feel free to take it and run. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6250|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6723|0 |1 is obsolete| | --- Comment #7 from Liz Rea <wizzyrea@gmail.com> 2011-12-12 23:02:52 UTC --- Comment on attachment 6723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6723 Bug 7157 - Improve the j2a.pl cronjob Gah. Too late in the day and I did it wrong. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> 2011-12-12 23:05:22 UTC --- Created attachment 6724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6724 Bug 7157 - Improve the j2a.pl cronjob - Calculates updates date based on the upper age limit defined in the patron categories. - Allows libraries to work on all branches or only one. - Allows libraries to specify which Adult patron category to update child categories to. - Allows libraries to specify a single Child patron category to update to an adult category. - Has a test mode to display what transforms would be done on the database without executing the changes. Includes improved help, copyright statement, and uses warnings. Also incorporates Paul's suggestions regarding --help and --man. To test: Create two patron categories, a child and an adult category. Make sure they have an upper age limit. Create or modify some patrons in multiple branches that fall into the category of "my birthdate is less than or equal to today's date minus the upper age limit" 1. Run the script with no flags - nothing should happen, it will suggest you try the -help flag. 2. Run the script with the -help flag - you should see the help 3. Run the script with the -fromcat=<child category> -tocat=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are. 4. Run the script with the -fromcat=<child category> -tocat=<adult category> -branch=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are. 5. Run the script with the -fromcat=<child category> -tocat=<adult category> -v -branch=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated. 6. Run the script with the -fromcat=<child category> -tocat=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches. 7. Run the script without the -v flag, if you care what the non-verbose output looks like. Known limitation - if you give it an unknown tocat, it will fail with a rather ugly error. I'm going to fix that but in another patch. There is more this script could do, please feel free to take it and run. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> 2011-12-13 17:32:06 UTC --- Created attachment 6757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6757 Bug 7157 - followup - error catching for nonexistent categories. This applies on top of the original patch - may not be the best implementation ever, suggestions are welcome. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-31 07:19:53 UTC --- Sorry liz The script still has -branch -fromcat -tocat which should either be -b -f -t or --branch --fromcat --tocat -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #11 from Liz Rea <wizzyrea@gmail.com> 2012-01-01 17:56:31 UTC --- Before I submit making them all -b -t -f Is there a preference for which way they go? No landmines? ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6724|0 |1 is obsolete| | Attachment #6757|0 |1 is obsolete| | --- Comment #12 from Liz Rea <wizzyrea@gmail.com> 2012-01-01 18:02:28 UTC --- Created attachment 7004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7004 Bug 7157 - Improve the j2a.pl cronjob - Calculates updates date based on the upper age limit defined in the patron categories. - Allows libraries to work on all branches or only one. - Allows libraries to specify which Adult patron category to update child categories to. - Allows libraries to specify a single Child patron category to update to an adult category. - Has a test mode to display what transforms would be done on the database without executing the changes. Includes improved help, copyright statement, and uses warnings. Also incorporates Paul's suggestions regarding --help and --man. To test: Create two patron categories, a child and an adult category. Make sure they have an upper age limit. Create or modify some patrons in multiple branches that fall into the category of "my birthdate is less than or equal to today's date minus the upper age limit" 1. Run the script with no flags - nothing should happen, it will suggest you try the -help flag. 2. Run the script with the -help flag - you should see the help 3. Run the script with the -f=<child category> -t=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are. 4. Run the script with the -f=<child category> -t=<adult category> -b=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are. 5. Run the script with the -f=<child category> -t=<adult category> -v -b=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated. 6. Run the script with the -f=<child category> -t=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches. 7. Run the script without the -v flag, if you care what the non-verbose output looks like. Fixed in this revision: Known limitation - if you give it an unknown tocat, it will fail with a rather ugly error. There is more this script could do, please feel free to take it and run. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7004|0 |1 is obsolete| | --- Comment #13 from Liz Rea <wizzyrea@gmail.com> 2012-01-01 18:08:26 UTC --- Created attachment 7005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7005 Bug 7157 - Improve the j2a.pl cronjob - Calculates updates date based on the upper age limit defined in the patron categories. - Allows libraries to work on all branches or only one. - Allows libraries to specify which Adult patron category to update child categories to. - Allows libraries to specify a single Child patron category to update to an adult category. - Has a test mode to display what transforms would be done on the database without executing the changes. Includes improved help, copyright statement, and uses warnings. Also incorporates Paul's suggestions regarding --help and --man. To test: Create two patron categories, a child and an adult category. Make sure they have an upper age limit. Create or modify some patrons in multiple branches that fall into the category of "my birthdate is less than or equal to today's date minus the upper age limit" 1. Run the script with no flags - nothing should happen, it will suggest you try the --help flag. 2. Run the script with the --help flag - you should see the help 3. Run the script with the -f=<child category> -t=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are. 4. Run the script with the -f=<child category> -t=<adult category> -b=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are. 5. Run the script with the -f=<child category> -t=<adult category> -v -b=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated. 6. Run the script with the -f=<child category> -t=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches. 7. Run the script without the -v flag, if you care what the non-verbose output looks like. Fixed in this revision: Known limitation - if you give it an unknown tocat, it will fail with a rather ugly error. Minor changes to the commit message to reflect new longopts (which I missed the last time) There is more this script could do, please feel free to take it and run. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7005|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 08:05:19 UTC --- Created attachment 7131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7131 Bug 7157 - Improve the j2a.pl cronjob - Calculates updates date based on the upper age limit defined in the patron categories. - Allows libraries to work on all branches or only one. - Allows libraries to specify which Adult patron category to update child categories to. - Allows libraries to specify a single Child patron category to update to an adult category. - Has a test mode to display what transforms would be done on the database without executing the changes. Includes improved help, copyright statement, and uses warnings. Also incorporates Paul's suggestions regarding --help and --man. To test: Create two patron categories, a child and an adult category. Make sure they have an upper age limit. Create or modify some patrons in multiple branches that fall into the category of "my birthdate is less than or equal to today's date minus the upper age limit" 1. Run the script with no flags - nothing should happen, it will suggest you try the --help flag. 2. Run the script with the --help flag - you should see the help 3. Run the script with the -f=<child category> -t=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are. 4. Run the script with the -f=<child category> -t=<adult category> -b=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are. 5. Run the script with the -f=<child category> -t=<adult category> -v -b=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated. 6. Run the script with the -f=<child category> -t=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches. 7. Run the script without the -v flag, if you care what the non-verbose output looks like. Fixed in this revision: Known limitation - if you give it an unknown tocat, it will fail with a rather ugly error. Minor changes to the commit message to reflect new longopts (which I missed the last time) There is more this script could do, please feel free to take it and run. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 08:06:59 UTC --- Created attachment 7132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7132 Bug 7157 : Follow up, fixing FSF address -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7132|0 |1 is obsolete| | --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-13 14:09:34 UTC --- Created attachment 7137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7137 [SIGNED] Followup for FSF address -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-13 14:20:58 UTC --- QA: On the first patch I see this construct a few times: SET categorycode='A', guarantorid ='0', categorycode =? Could you correct that please? You only need to update the code once ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-13 14:27:40 UTC --- Sorry, but yet another "dumb" question: Couldn't this be done easier: AND categorycode IN (select categorycode from categories where category_type='C' and categorycode=?)|; Don't you mean categorycode=? Do you still need the check on type=C? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7131|0 |1 is obsolete| | Attachment #7137|0 |1 is obsolete| | --- Comment #19 from Liz Rea <wizzyrea@gmail.com> 2012-01-17 16:45:50 UTC --- Created attachment 7201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7201 Bug 7157 - Improve the j2a.pl cronjob - Calculates updates date based on the upper age limit defined in the patron categories. - Allows libraries to work on all branches or only one. - Allows libraries to specify which Adult patron category to update child categories to. - Allows libraries to specify a single Child patron category to update to an adult category. - Has a test mode to display what transforms would be done on the database without executing the changes. Includes improved help, copyright statement, and uses warnings. Also incorporates Paul's suggestions regarding --help and --man, changes -fromcat and -tocat to -f and -t, and removes a redundant update to categorycode (per M. deRooy). To test: Create two patron categories, a child and an adult category. Make sure they have an upper age limit. Create or modify some patrons in multiple branches that fall into the category of "my birthdate is less than or equal to today's date minus the upper age limit" 1. Run the script with no flags - nothing should happen, it will suggest you try the --help flag. 2. Run the script with the --help flag - you should see the help 3. Run the script with the -f=<child category> -t=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are. 4. Run the script with the -f=<child category> -t=<adult category> -b=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are. 5. Run the script with the -f=<child category> -t=<adult category> -v -b=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated. 6. Run the script with the -f=<child category> -t=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches. 7. Run the script without the -v flag, if you care what the non-verbose output looks like. Fixed in this revision: Known limitation - if you give it an unknown tocat, it will fail with a rather ugly error. Minor changes to the commit message to reflect new longopts (which I missed the last time) There is more this script could do, please feel free to take it and run. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Bug 7157 : Follow up, fixing FSF address Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |Signed Off --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-19 11:10:56 UTC --- QA Comment: Thank you, Liz, for patiently resubmitting new versions. I am marking it again as Passed QA. Hopefully, Paul agrees too now ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-20 14:22:45 UTC --- mmm... the patch changes the permissions of this script and remove the x (executable). Could you confirm it's a mistake, (I can fix it when pushing, no problem) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 --- Comment #22 from Liz Rea <wizzyrea@gmail.com> 2012-01-20 19:38:28 UTC --- I am sure that is a mistake. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cookie.wolfrom@liblime.com --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 3410 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org