[Bug 13227] New: Display856uAsImage displays images in OPAC in original size
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Bug ID: 13227 Summary: Display856uAsImage displays images in OPAC in original size Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33396&action=edit Bug 13227: Display856uAsImage displays images in OPAC in original size To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. Patch changes the XSLT to restore the former behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33396|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 33403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33403&action=edit Bug 13227: Display856uAsImage displays images in OPAC in original size To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. Patch changes the XSLT to restore the former behaviour. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33403|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 33470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33470&action=edit [Passed QA] Bug 13227: Display856uAsImage displays images in OPAC in original size To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. Patch changes the XSLT to restore the former behaviour. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passes all my tests and qa script. Passing QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13227 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org