https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 [Bug 22276] Add client storage of user-selected DataTables configuration -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149445&action=edit Bug 33484: Revert template change introduced in bug 22276 With the globalisation of the stateSave handling introduced by bug 22276 we can remove the localised changes to the template in branches.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- To Test. 1) Confirm the test plan for bug 22276 still passes. 2) Check other instances where KohaTable is used and table_settings (i.e. you can choose what columns to display) is passed.. all should now save and restore state upon navigating back to them I'm not 100% sure about the original patch.. I feel it does more than expected in so much as saveState also saves and restores pagination, search filters etc etc. Secondly.. whilst I do this for the KohaTable (found in column_settings.inc).. I haven't added it to the DT REST wrapper.. or Vue components.. we should really do all three... but I wanted to start getting feedback first. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149444|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149447&action=edit Bug 33484: Make saveState column handling global This patch updates the handling for saveState added in bug 22276 to work globally for all KohaTables that pass a table_settings hash. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149449&action=edit Bug 33484: Revert template change on suggestion.tt This reverts commit 2b0693dbfd6aa2dd2c7c91428b23aba717ccc0af as it's no longer required once we globalise the logic as we do in this patchset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- This works on some pages, but not on others. I have a meeting in a few minutes and so can't test them all at the moment, but this is what I've found so far: Pages that work: pendingreserves.pl suggestions.pl Pages that don't retain the save state: branches.pl members-home.pl (table id: memberresults) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emily, thanks for your comments! I hope I won't get myself into trouble for this... but could it be a flag we set on the column configuration page? But that would bring us back to having a different behaviour for column controlled vs. column uncontrolled tables... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com --- Comment #10 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Would it be possible to have it save as part of the saveState an option for keeping or clearing filters and have it clear filters by default, but someone could turn it on for a table if they wanted? Lisette -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149447|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149925&action=edit Bug 33484: Make saveState column handling global This patch updates the handling for saveState added in bug 22276 to work globally for all KohaTables that pass a table_settings hash. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149449|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149927&action=edit Bug 33484: Revert template change on suggestion.tt This reverts commit 2b0693dbfd6aa2dd2c7c91428b23aba717ccc0af as it's no longer required once we globalise the logic as we do in this patchset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149929&action=edit Bug 33484: Add save state option to table settings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- PS, you'll need to run the DB update ;P -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I can't replicate that I'm afraid.. I just freshly applied the bug and it's all working for me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149926|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149975&action=edit Bug 33484: Revert template change introduced in bug 22276 With the globalisation of the stateSave handling introduced by bug 22276 we can remove the localised changes to the template in branches.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149928|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149977&action=edit Bug 33484: Add support to kohaTable (AJAX Tables) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149930|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149979&action=edit Bug 33484: Schema Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #29 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- I can't reproduce the error on KTD either. Lisette, can you give more information about how to reproduce it? I am noticing so far a few other unexpected behaviors so far, though: - Holds to Pull saves the client-side state regardless of the configuration on the admin table settings page - Holds Queue appears to be working correctly for the most part. If you disable state saving from the admin table settings page, the table will continue to save the client-side state for the rest of the session, but will respect the configuration if you start a new session. (I'm not sure if that's an error or if it's the expected behavior.) - memberresultst and branches.pl (both of which use the kohaTable API wrapper rather than the KohaTable wrapper) appear to be working correctly for the most part. However, if the admin table settings hide a column by default, that column stays hidden even when state saving is enabled. Other aspects of client-side state saving (hiding columns that are shown by default, entries per page) work, though. Also, this was the case for branches.pl in master, too, so it wasn't introduced by this patch. I really like where this is going - but I think it's going to need more thorough/systematic testing than what I've done so far to catch any anomalies. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #31 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- I wrote up a test plan to keep myself organized while testing different tables and states...sharing in case someone else gets to it before me and would like to use it. (also open to feedback :) ) Considerations: - test a variety of tables - must include both tables that use KohaTable (column_settings.inc) and kohaTable (datatables.js) For reference: tables that use kohaTable (based on a git grep): - patron search (patrons_table) - acqui/parcel.tt (pending_orders) - admin/background_jobs.tt (table_jobs) - admin/branches.tt (libraries) - admin/cities.tt (table_cities) - admin/identity_provider_domains.tt (identity_provider_domains) - admin/identity_providers.tt (identity_providers) - admin/search_filters.tt (search_filters_table) - admin/smtp_servers.tt (smtp_servers) - catalogue/detail.tt (table_concerns) - catalogue/detail.tt (bundle_table) - cataloguing/concerns.tt (table_concerns) - pos/register.tt (table_cashups) - tools/quotes.tt (quotes) Test plan per table: 1. Edit the config to hide some columns and disable "save state" 2. Test that the "clean" page matches the config settings 3. Make some client-side changes a. Hide one or more showing columns b. Show one or more hidden columns c. Change number of results to display d. Add a search filter 4. Navigate away from that page and back 5. Confirm that the state was not saved and the page matches the config settings 6. Navigate away from that page 7. Edit the config to enable "save state" 8. Return to the page and confirm that it matches the config settings 9. Make some client-side changes a. Hide one or more showing columns b. Show one or more hidden columns c. Change number of results to display d. Add a search filter 10. Navigate away from the page and back 11. Confirm that all of the changes were retained -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #32 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Taking another stab at testing this. I'm still getting a few tables (holds to pull and saved SQL reports, at least) that will continue to save the local configuration indefinitely if a local save state was ever created, even if it was later disabled in the configuration. I couldn't figure out why it happens with some tables and not others, but it did clear up when I tried moving the block that clears the local save state (if configured not to save) to occur before trying to load the local save state: Lines ~21-53 (columns_settings.inc): + if ( table_settings.hasOwnProperty('default_save_state') && table_settings['default_save_state'] === 0 ) { + localStorage.removeItem(table_key); + } + // enable stateSave dt_parameters['stateSave'] = true; dt_parameters['stateSaveCallback'] = function( settings, data ) { localStorage.setItem( table_key, JSON.stringify(data) ) } dt_parameters['stateLoadCallback'] = function(settings) { return JSON.parse( localStorage.getItem(table_key) ) } // merge stateSave for column settings var local_settings = localStorage.getItem(table_key); var system_settings = table_settings['columns']; var columns_settings = get_columns_saved_state(local_settings, system_settings); $(columns_settings).each( function() { var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); var used_id = dt_parameters.bKohaColumnsUseNames ? named_id : counter; if ( used_id == -1 ) return; if ( this['is_hidden'] == "1" ) { hidden_ids.push( used_id ); } if ( this['cannot_be_toggled'] == "0" ) { included_ids.push( used_id ); } counter++; }); - if ( table_settings.hasOwnProperty('default_save_state') && table_settings['default_save_state'] === 0 ) { - localStorage.removeItem(table_key); - } -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35569 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |jonathan.druart@gmail.com |.com | Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 16881 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149978|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38114 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Pushed new patches, ready for testing. We have different tables to test: * kohaTable (datatables.js) ** with filters - catalogue detail, holding tables - main patron search - item search (I didn't test this one) - cities ** without filters - acqui/edifactmsgs (didn't test, not familiar with edifact) - admin/branches.pl * KohaTable (columns_settings.inc) ** with filters - only reports/itemslost.tt ** without filters - catalogue detail page, tab "Comments" ** with search form - Overdue report (might need adjustments) - others? * Vue tables (using kohaTable but differ a bit) The "Copy conditions" buttons should only appear if table settings are defined (ie. there is an entry in the columns_settings.yml file). For each table you can try to: * Play with the two new options from the settings: - "Save configuration state on page change": will save the column visibility, length and order (ON by default) - "Save search state on page change": will save the search (OFF by default) * See if the state is correctly restored and not, depending on the settings. * Use the "Copy conditions" button and reuse it to confirm that is restore the table properly. Note that it will ofc erase the localStorage entry with this state. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 27467 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could make the bug description a bit less technical to draw more attention. Maybe something like "Remember user's table settings for all tables"? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Going further: * "clear state" button * "Do not keep state for this page" - we could store in localstorage => any librarians can decide what to do. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Brendan Lawlor from comment #41)

I'm interested in testing this patch, but I have'nt ever tested a patch from a remote branch before, so I need to figure out how to do that first.

% git remote add joubu https://gitlab.com/joubu/koha.git % git fetch joubu bug_33484

I'm also curious would this fix an issue with certain tables, where if a column is hidden by default in table settings, it still briefly flashes when the table first loads before it is hidden? Specifically this happens in the 'checkedintable'

Nope, but I can have a look at this issue later. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #45 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #44)

Thank you Joubu for this very important work. My 2 cents:

1) QA script has several FAIL

Fixed.

2) t/db_dependent/TablesSettings.t syntax error -> is missing a comma on line 196. Tests fail after correcting that.

Fixed.

3) atomicupdate does not follow skeleton.pl Output

Please clarify, I am using the usual `say $out`, what is in skeleton. There is no clear definition for the uses of the other success/failure. The output for 24.11 is not consistent at all for the moment, that's a discussion for somewhere else.

4) Testing suggestions table at /cgi-bin/koha/suggestion/suggestion.pl: - Created 2 suggestions with random title each - Did a search keyword for 'staff' - Clicked 'Copy conditions' - Opened new tab, pasted -> BOOM Error 500 with the following error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'DataTables_acqui_suggestions_suggestions_state' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 403 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

Those ugly scripts, erk. Fixed. ugly fix ofc... There is more to do to make it work on this table however.

Non-blockers / too hard for now: 1) "Copy conditions" button does not consider left-side filters on the patron search (and I suspect the same for ILL requests even though I have not tested, it works pretty much the same way i.e. left-side filters live outside of the datatable).

I will write something to exclude some tables from the first iteration. Especially the ones with "additional filters" (ie. when some filters are outside of the table).

- I suggest a new label for "Copy conditions". The item search button that does the same thing has "Copy shareable link" which I think it's much better/obvious to what it does.

Correct, done. I've also added a tooltip "Copied!" when the button is clicked (like on the item search).

- "Save configuration state on page change" is this about columns configuration display only? If so, I suggest renaming this label to "Keep columns visibility state on page change".

There is a tooltip, it's the column visibility, number of results, sort order.

- Likewise "Save search state on page change:" I would suggest "Keep search state on page change" instead. We're "keeping" the state between page hops, no actual "saving" is happening.

It's actually saving in the localStorage. But you are correct, for the end user it's more about keeping/restoring. I will adjust when we agree on a wording for the 2 entries. Changes from today: git range-diff joubu/old/20241017-bug_33484~27..joubu/old/20241017-bug_33484 joubu/bug_33484~32..joubu/bug_33484 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #48)

Obs (other bugs, not here, if you agree): 1) Libraries search does not search on address1 (or address2/address3) despite it being shown.

Yes, it deserves its own bug.

2) ILL requests table needs to adopt external_filter_nodes to have external filters included in the "Copy shareable link".

Should be done here. Almost done, there is only the value for "Backend" and "Status" dropdown lists that are not restored. It seems that both are fetched in AJAX and I guess there is a race between DT that is loading its state (and selecting the options) and those requests. I've tried to move the code (populateStatusFilter) before the kohaTable init but it still does not work. Could you have look maybe? See commits Bug 33484: External filter into state - support flatpickr Bug 33484: External filter into state - ill requests

3) qa script complains about console.logs in datatables.js and columns_settings.inc but I don't consider these blockers

console.log("Tag '%s' not supported yet for DT state".format(tag_name)) They are there on purpose. False positives.

Blocker: t/db_dependent/selenium/patrons_search.t .. # Failed test 'Searching in standard brings back correct results' # at t/db_dependent/selenium/patrons_search.t line 285. # got: 'No entries to show (filtered from 80 total entries)' # expected: 'Showing 1 to 15 of 26 entries (filtered from 80 total entries)'

# Failed test 'Filtering on library works in combination with main search' # at t/db_dependent/selenium/patrons_search.t line 289. # got: 'No entries to show (filtered from 80 total entries)' # expected: 'Showing 1 to 15 of 25 entries (filtered from 80 total entries)' # Looks like you planned 7 tests but ran 1.

# Failed test 'remember_search' # at t/db_dependent/selenium/patrons_search.t line 407. # Looks like you planned 28 tests but ran 27. # Looks like you failed 3 tests of 27 run.

Fixed! Fixed! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38242 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38242 [Bug 38242] ILL table status and backend fitler are not remember when using table's copied sharing link -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37395, 38191, 38192, 38240 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37395 [Bug 37395] Cannot hide columns in ERM tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38191 [Bug 38191] Suggestions filters do not expand https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 [Bug 38192] DT - State not restored correctly on suggestion tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 [Bug 38240] Filtering resulting in no result will hide filters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #53 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #52)

(In reply to Pedro Amorim from comment #51)

...

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Added to the remote branch, thanks!

4f8d1b5ca00 (HEAD -> bug_33484, gitlab/bug_33484) Bug 33484: (follow-up) Fix category select f2b268b978f Bug 33484: Fix selenium/patrons_search.t dac59ead863 Bug 33484: External filter into state - ill requests 2814b1e998a Bug 33484: External filter into state - support flatpickr 5ae78fe19c6 Bug 33484: External filter into state - catalogue concerns a40fb3ab004 Bug 33484: External filter into state - support checkboxes 995e10fdba9 Bug 33484: External filter into state - patron search 0464ba6a917 Bug 33484: Store external filters into state ef16a39424f Bug 33484: Fix for suggestions cfac4b84e55 Bug 33484: Allow several tables using the same table settings - columns_settings 0121c20b395 Bug 33484: Add 'Copied!' tooltip when the button is clicked 9897e254a2c Bug 33484: Rename 'Copy conditions' => 'Copy shareable link' 7a02ce991a0 Bug 33484: Fix TablesSettings.t 14e71798f7f Bug 33484: Add new columns as boolean in schema file c83226b3010 Bug 33484: Fix libraries table 9b5d3c6557e Bug 33484: Fix bookings 3b3db7f4596 Bug 33484: Fix Vue tables 24f85535e5b Bug 33484: Fix pending orders fe1646bec37 Bug 33484: Adjust columns_settings.inc 50c8ba82597 Bug 33484: Early return in add_filters if node does not exist 62a9da0552e Bug 33484: Do not defer loading if state is loaded from localStorage 5bea1604a6c Bug 33484: Fix category select f60f5b68766 Bug 33484: Fix patron search form f6fded1d4d2 Bug 33484: Fix patrons search d2045474ff9 Bug 33484: Redraw columns filters when column visibility is modified 2620e01756b Bug 33484: Remove localStorage on logout 5c6a1546531 Bug 33484: (Bug 27467) Fix patrons search 0a69f25bc64 Bug 33484: (Bug 27467) Ability to share a link 7f20a93f27a Bug 33484: Always save but restore on demand only 3271b62ca23 Bug 33484: Implement Vue KohaTable 79ade6e3eb4 Bug 33484: DBIC Schema change f221690d365 Bug 33484: Add tables_settings.default_save_state_search 82cdcee4473 Bug 33484: Clearly separate search and configuration 46332707da2 Bug 33484: Add table settings to pending orders 3f86d437d05 Bug 33484: Make default_save_state default to 1 a124435e8de Bug 33484: Add save state option to table settings a45695301e0 Bug 33484: Schema Update b5394d9ab01 Bug 33484: Add support to kohaTable (AJAX Tables) 70204f43c3c Bug 33484: Revert template change on suggestion.tt 71d39685d8d Bug 33484: Revert template change introduced in bug 22276 87d9ecc5e52 Bug 33484: Make saveState column handling global Also has: 2651447aa58 Bug 38240: Do not hide columns if no items to display d87b4bb2c12 Bug 38192: Fix restoration of table state for suggestion tables 597000dbb10 Bug 38191: Restore collapse/expand of filters on the suggestions page 6d48ab25b24 Bug 37395: Fix columns visibility on Vue tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #55 from Jonathan Druart <jonathan.druart@gmail.com> --- New commit "Bug 33484: Include patron search code if no patron selected yet" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I've just spend a chunk of time working through this playing with various tables.. I'm happy to throw my QA stamp on.. going to make the bug PQA and let Jonathan add the SO lines to his branch ready for Katrin to merge. Great work here, thanks for jumping on and getting it applied everywhere Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173443&action=edit Bug 33484: Make saveState column handling global This patch updates the handling for saveState added in bug 22276 to work globally for all KohaTables that pass a table_settings hash. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #61 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173445&action=edit Bug 33484: Revert template change on suggestion.tt This reverts commit 2b0693dbfd6aa2dd2c7c91428b23aba717ccc0af as it's no longer required once we globalise the logic as we do in this patchset Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #63 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173447&action=edit Bug 33484: Schema Update Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #65 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173449&action=edit Bug 33484: Make default_save_state default to 1 Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #67 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173451&action=edit Bug 33484: Clearly separate search and configuration We want to make distinguish the search terms and the configuration/option of the table (number of entries, column visibility, etc.) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #69 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173453&action=edit Bug 33484: DBIC Schema change Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #71 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173455&action=edit Bug 33484: Always save but restore on demand only And remove get_columns_saved_state. I am not sure this what really helpful, maybe in case the yml or config in the DB changed, but I don't think we should complicate the code. If something is wrong, logout to clear localStorage... We will see later if we really need it. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #73 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173457&action=edit Bug 33484: (Bug 27467) Fix patrons search Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #75 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173459&action=edit Bug 33484: Redraw columns filters when column visibility is modified This seems to be the most sensible approach, we redraw the whole th when the column visibility is modified. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #77 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173461&action=edit Bug 33484: Fix patron search form Reset DT's filters if we are searching again using the search form. If you use the form on the left we need to reset the different filters that could have been set from a previous state we loaded. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #79 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173463&action=edit Bug 33484: Do not defer loading if state is loaded from localStorage Squashing Revert "Bug 33484: (Bug 27467) Fix patrons search" This reverts commit 0d21ff768b97bc8393a01b0ad881961a3252f2cf. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #81 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173465&action=edit Bug 33484: Adjust columns_settings.inc Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #83 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173467&action=edit Bug 33484: Fix Vue tables datatables.net-vue3 does not use a specific id, and does not let us pass one. It is generated, like: DataTables_Table_0 (and increment when a new table is created). So it's not possible to use this id: it can change and so is not reliable. I have tried to pass "data-koha-table-id" with a specific id (KohaTable_agreements). Which was working, but actually we could simply use the table settings key to identify the tables in the URL. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #85 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173469&action=edit Bug 33484: Fix libraries table We added columns to the table but never displayed them, and they were not part of the columns settings. I am not sure what was the purpose of that but it looks completely wrong. If we want to restore them it should be done correctly (ie. add them back to the column list and add the new ones to the columns settings). Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #87 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173471&action=edit Bug 33484: Fix TablesSettings.t Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #89 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173473&action=edit Bug 33484: Add 'Copied!' tooltip when the button is clicked Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #91 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173475&action=edit Bug 33484: Fix for suggestions This ugly fix is retrieving all CGI params and consider them attributes for suggestions. So we need to exclude other ones... There is more to make it works properly on this table. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #93 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173477&action=edit Bug 33484: External filter into state - patron search Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #95 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173479&action=edit Bug 33484: External filter into state - catalogue concerns Use a checkbox to store the state. It does not make the code better but make possible to keep and restore and state of the filter. Not sure it's working correct on the cataloguing/concerns.pl page but the behaviour was already not good before. At least I think it fixes the filter/include icon in some situation. On main I managed to get the "include resolved" link with the "filter" icon and the resolved concerns were already displayed... Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #97 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173481&action=edit Bug 33484: External filter into state - ill requests Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #99 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173483&action=edit Bug 33484: (follow-up) Fix category select Lower everything or broken for library Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #101 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173485&action=edit Bug 33484: Include patron search code if no patron selected yet When placing a hold we should not display the patron search code (html+js) if we have picked a patron already, otherwise a get a JS error Uncaught TypeError: table_dt.settings()[0] is undefined koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc 781 let table_dt = patrons_table.DataTable(); 782 let loaded_from_state = table_dt.settings()[0].loaded_from_state; Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Are we ready to push? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #104 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- On this now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #106 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forgot one (only cosmetics again): 4) Phrasing Save configuration state on page change: Save search state on page change: I wonder if "state" is easy to understand here for the local admins and translators. A suggestion (to be discussed): Save table settings on page change: Save selected search filters and options on page change: -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #108 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #105)

OK, doing my best here, so some notes :)

1) Copy shareable link

This is a tad long. Could we go with "Link" or "Copy link" and a longer tooltip like on the other buttons?

It's consistent with the "item search" feature. We can adjust but should we then adjust the existing one as well?

2) Links are really really long

A shareable link for "Borrowers that start with D" is:

Is there a trick we could imagine (maybe as a future improvement) to create a shorter shareable link?

Possibly. It's base64 encoded so not supposed to reduce the size of the original string.

3) I got trapped :( (please follow-up)

For testing purposes I set the patron search table to save the search state. I entered "ace" in the name column, which returns one result. No every time I got o patron search it immediately sends me to old Henry's account and I have no way to get out of that loop and change my settings.

Fixed, see "Bug 33484: Do not redirect if loaded from state" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #109 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #110 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this may have broken regresions.t: # Failed test 'Checkouts table must be correctly aligned' # at t/db_dependent/selenium/regressions.t line 243. # got: '' # expected: '1' # thead: 18 ; tfoot: 17 ; tbody: 18 # Looks like you failed 1 test of 1. not ok 6 - Display circulation table correctly Please check! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #111 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173606&action=edit Bug 33484: Remove state settings from column level default_save_state and default_save_state_search were added at the column level, it's not needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38296 [Bug 38296] Investigate DataTables's extension StateRestore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #113 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173985&action=edit Bug 33484: (follow-up) checkouts - Move visibility handling to table_setting table_settings_issues_table must be defined before we include checkouts.js -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Ewa Gózd <ewa.gozd@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ewa.gozd@gmail.com --- Comment #115 from Ewa Gózd <ewa.gozd@gmail.com> --- Pushed (follow-up) to main. Is it possible that columns hidden by default and set to visible are not remembered when moving between pages? (they re-hide) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Ewa Gózd <ewa.gozd@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_24_11_candidate | --- Comment #117 from Ewa Gózd <ewa.gozd@gmail.com> --- (In reply to Jonathan Druart from comment #116)

(In reply to Ewa Gózd from comment #115)

...

Is it possible that columns hidden by default and set to visible are not remembered when moving between pages? (they re-hide)

Which ones exactly? It is possible that renew, checkin and export are hidden even if shown before, because their visibility depends on sysprefs (AllowCirculate, ClaimReturnedLostValue).

But it should work correctly for other tables.

Agreed, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #118 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174219&action=edit Bug 33484: Redraw columns filters when column visibility is modified - Vue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38433 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38433 [Bug 38433] Conflicting behaviour of the columns visibility on the items table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38482 [Bug 38482] Disable save state for items tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Bug 33484 depends on bug 38191, which changed state. Bug 38191 Summary: Suggestions filters do not expand https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38191 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com --- Comment #121 from Jessie Zairo <jzairo@bywatersolutions.com> --- Testing this on 24.11.00 I noticed when you set your columns on a holdings page cgi-bin/koha/catalogue/detail.pl?biblionumber= and then search for another title, your columns settings are not remembered on cgi-bin/koha/catalogue/detail.pl?biblionumber= -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 ayoung <ayoung@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ayoung@oslri.net --- Comment #123 from ayoung <ayoung@oslri.net> --- Could I get more clarity on why the holdings table was excluded from this new feature? I was excited for this feature specifically because of this table! I see in the comments that it wasn't possible because of search filters not transferring across bibs correctly...would it be possible to have the option to only save the configuration state and not the search state on page change? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #125 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to ayoung from comment #123)

Could I get more clarity on why the holdings table was excluded from this new feature? I was excited for this feature specifically because of this table!

I see in the comments that it wasn't possible because of search filters not transferring across bibs correctly...would it be possible to have the option to only save the configuration state and not the search state on page change?

Part of it is also that the holdings table is more complicated than the rest, because it automatically hides a column if there are no visible items that have data in that column. The problem is that the table can't tell the difference between a column that was auto-hidden because it was empty, and a column that you hid on purpose - it just "knows" which columns were hidden and which ones were showing the last time it was used. So, for example, if some of your titles have Materials Specified but many do not, then the Materials Specified column would get secretly hidden when you loaded a title that didn't have Materials Specified, and then it would not show again even when it should unless you noticed it was missing and turned it back on manually. (Or worse, say the first 20 items on a record were missing their call number - then the call number column would get hidden until you noticed it was missing and turned it back on.) I think the long-term goal is to find a way to solve that problem and add the feature back to the item holdings table, but it's tricky and there are a lot of moving pieces, so we had to remove the feature from the item holdings table to avoid secretly hiding columns the user doesn't want hidden in the meantime. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #127 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to ayoung from comment #123)

Could I get more clarity on why the holdings table was excluded from this new feature? I was excited for this feature specifically because of this table!

I see in the comments that it wasn't possible because of search filters not transferring across bibs correctly...would it be possible to have the option to only save the configuration state and not the search state on page change?

Hello, please see this commit message: Bug 38482: Remove save state for the holdings tables On the holdings table of the bibliographic record detail page, we have a special behaviour: we hide columns if there is no data to display. Indeed we have a lot of column and we want to limit the number of columns displayed. This behaviour conflicts with "Save state": when the columns are hidden the state is modified. If you leave the page and come back, the column will stay hidden, even if the global settings does not have it as hidden and even if the user didn't explicitly hide it. We want to implement something correctly to prevent a conflict with those 2 behaviours, but 24.11.00 is coming and we need a quick fix: here we are going to remove save state for these 2 tables. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Bug 33484 depends on bug 38240, which changed state. Bug 38240 Summary: Filtering resulting in no result will hide filters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39930 [Bug 39930] Saved configuration states on tables are lost overnight -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 [Bug 41314] Column visibility broken on the checkouts table -- You are receiving this mail because: You are watching all bug changes.