http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Title notes: Add a system |Add a system preference to |preference to set which |set which notes fields |notes fields appears on |appears on title |title notes/description |notes/description separator |separator | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 --- Comment #1 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 13730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13730&action=edit BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list, -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Vitor, for future reference you are not allowed to use tab characters in Koha code. In particular, the system preferences files are broken by tabs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- My blacklisted fields still display on the record details in the OPAC and Intranet. Please provide a test plan, I may be testing this incorrectly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 --- Comment #6 from Vitor Fernandes <vfernandes@keep.pt> --- Hi Kyle, Sorry for the tab and XXX version problems. These are my first patches so it's normal to have some errors. I'll try to avoid those in the future. Problem: - All notes fields are shown in the 'title notes' separator on OPAC record details - All notes fields are shown in the 'description' separator on intranet record details Test plan: - Search for a record that has a note field (3XX in UNIMARC or 5XX in MARC21) - Check if that note appears in the separator 'title notes' of OPAC record details - Add the note field tag in the created system preference - Refresh the record detail page and check if the note stills appears - Check if that note appears in the separator 'description' of intranet record details - Add the note field tag in the created system preference - Refresh the record detail page and check if the note stills appears -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13916|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14121&action=edit [SIGNED-OFF] BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list, Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: The proposed patch works well. However if all existing fields are blacklisted, the biblio.notes field is displayed. So if you blacklist the 300$a and if it is mapped with this db field, it will be displayed. Possible improvement : Perhaps some libraries would like to blacklist some fields for the opac and fewer fields for the intranet (required 1 syspref by interface). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14264|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14265&action=edit BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list, Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> FIX some indentation in C4/Biblio.pm +FIX 1 end of parentheses in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9162 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9495 -- You are receiving this mail because: You are watching all bug changes.