[Bug 39896] New: Syspref AuthorLinkSortBy is not working for Unimarc or custom XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Bug ID: 39896 Summary: Syspref AuthorLinkSortBy is not working for Unimarc or custom XSLT Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: marion.durand@biblibre.com QA Contact: testopia@bugs.koha-community.org The syspref AuthorLinkSortBy and AuthorLinkSortOrder depend on code in XSLT files. Currently, the code is only present in the default MARC21 files but it is not present in any UNIMARC files. Plus, if a library uses customs XSLT files (with syspref OPACXSLTDetailsDisplay, OPACXSLTResultsDisplay, XSLTDetailsDisplay, or XSLTResultsDisplay) they will not be able to use this functionality (unless they also updated their files but they have no way to know they need to do that). This is inevitable and is okay, but I think we should mention somewhere that these syspref depend on XSLT. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33217 [Bug 33217] Allow different default sorting when click author links -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As you write it cannot really be changed unless they implement it, which they could. Maybe a hint: If you are using custom XSLT you need to make sure the system preference check is implemented. ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Marion Durand <marion.durand@biblibre.com> --- I think there is two part (maybe I should have files tow bug ?) : default UNIMARC files (provided in Koha code) and libraries using custom XSLT files. I will try to provide a patch for the default UNIMARC files. (In reply to Katrin Fischer from comment #1)
As you write it cannot really be changed unless they implement it, which they could. Maybe a hint: If you are using custom XSLT you need to make sure the system preference check is implemented. ? Yes, I think we could add a hint either on the syspref description or in the manuel. It would help understand why the syspref has no effect in certains cases.
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Syspref AuthorLinkSortBy is |System preference |not working for Unimarc or |AuthorLinkSortBy is not |custom XSLT |working for UNIMARC or | |custom XSLT --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marion, if you want to split, that's fine, but I think a textual hint would be OK as part of the UNIMARC patch as well being low risk. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #4 from Marion Durand <marion.durand@biblibre.com> --- Hi Katrin, If it can be done with the UNIMARC patch, I can do that too. Thank you for your help :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #5 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 182479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182479&action=edit Bug 39896: Add UNIMARC support for AuthorLinkSortBy This patch add support for AuthorLinkSortBy and AuthorLinkSortOrder in the default UNIMARC XSLT files. The description of the syspref is also slighly updated to hint users of custom XSLT file about the need to update their template. To test: 0. On a UNIMARC database 1. Set AuthorLinkSortBy to 'title' and AuthorLinkSortORder to 'descending' 2. On the intranet and OPAC, search for an author you have multiple titles from and click on a result 3. Click on a link one a name for an author 4. Note a new search is performed, sorted by field from defaultSortField preference and not by title descending 5. Apply the patch 6. restart_all 7. Check that the syspref description now include a note about custom XSLT files 8. Repeat step 2 and 3 9. Note a new search is performed, sorted by title descending 10. Test other values - confirm links are updated in both staff and opac -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|koha-bugs@lists.koha-commun |marion.durand@biblibre.com |ity.org | --- Comment #6 from David Nind <david@davidnind.com> --- Added assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182479|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 182884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182884&action=edit Bug 39896: Add UNIMARC support for AuthorLinkSortBy This patch add support for AuthorLinkSortBy and AuthorLinkSortOrder in the default UNIMARC XSLT files. The description of the syspref is also slighly updated to hint users of custom XSLT file about the need to update their template. To test: 0. On a UNIMARC database 1. Set AuthorLinkSortBy to 'title' and AuthorLinkSortORder to 'descending' 2. On the intranet and OPAC, search for an author you have multiple titles from and click on a result 3. Click on a link one a name for an author 4. Note a new search is performed, sorted by field from defaultSortField preference and not by title descending 5. Apply the patch 6. restart_all 7. Check that the syspref description now include a note about custom XSLT files 8. Repeat step 2 and 3 9. Note a new search is performed, sorted by title descending 10. Test other values - confirm links are updated in both staff and opac Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the default release notes| |UNIMARC XSLT files so that | |the AuthorLinkSortBy and | |AuthorLinkSortOrder system | |preferences now work with | |UNIMARC, not jsut MARC21. | | | |A note was also added to | |the system preference for | |those that use custom XSLT | |(for | |OPACXSLTDetailsDisplay, | |OPACXSLTResultsDisplay, | |XSLTDetailsDisplay, and | |XSLTResultsDisplay) - they | |need to update their | |templates to support these | |features for both MARC21 | |and UNIMARC. | | | |(These | |preferences were added in | |Koha 23.11 by Bug 33217 - | |Allow different default | |sorting when click author | |links, but only the default | |XSLT files for MARC21 were | |updated.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To start up KTD with UNIMARC, edit your .env file and set KOHA_MARC_FLAVOUR=unimarc 2. An author with multiple records: Louis Gardel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just wondering here about: -rw-r--r-- 1 root root 107578 Jul 15 16:07 MARC21slim2intranetDetail.xsl -rw-r--r-- 1 root root 55899 Jun 11 14:04 MARC21slim2intranetResults.xsl -rw-r--r-- 1 root root 21525 Jul 18 09:29 UNIMARCslim2intranetDetail.xsl -rw-r--r-- 1 root root 3304 Jun 11 14:04 UNIMARCslim2intranetResults.xsl What is actually the current status of UNIMARCslim2intranetResults.xsl ? It is adjusted in MARC21 for the AuthorLinkSort stuff too.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Although the code looks good to me, I would appreciate a response about the current status of using XSLT for OPAC and intranet on UNIMARC installs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #11 from Marion Durand <marion.durand@biblibre.com> --- (In reply to Marcel de Rooy from comment #10)
Although the code looks good to me, I would appreciate a response about the current status of using XSLT for OPAC and intranet on UNIMARC installs.
I'm not sure to understand your question, we often use XSLT in UNIMARC installation. Sometimes with community file, sometimes with custom file. This patch adjusted the following files to add support for the syspref in default UNIMARC XSLT. prog/en/xslt/UNIMARCslim2intranetDetail.xsl prog/en/xslt/UNIMARCslimUtils.xsl bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl bootstrap/en/xslt/UNIMARCslimUtils.xsl (plus /en/modules/admin/preferences/searching.pref to add a hint in the syspref for custom file). I did not updated the following files as the author search link is not present in the first place (so no need to add parameters to this link) prog/en/xslt/UNIMARCslim2intranetResults.xsl bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the default |This fixes the default release notes|UNIMARC XSLT files so that |UNIMARC XSLT files so that |the AuthorLinkSortBy and |the AuthorLinkSortBy and |AuthorLinkSortOrder system |AuthorLinkSortOrder system |preferences now work with |preferences now work with |UNIMARC, not jsut MARC21. |UNIMARC, not just MARC21. | | |A note was also added to |A note was also added to |the system preference for |the system preference for |those that use custom XSLT |those that use custom XSLT |(for |(for |OPACXSLTDetailsDisplay, |OPACXSLTDetailsDisplay, |OPACXSLTResultsDisplay, |OPACXSLTResultsDisplay, |XSLTDetailsDisplay, and |XSLTDetailsDisplay, and |XSLTResultsDisplay) - they |XSLTResultsDisplay) - they |need to update their |need to update their |templates to support these |templates to support these |features for both MARC21 |features for both MARC21 |and UNIMARC. |and UNIMARC. | | |(These preferences were |(These preferences were |added in Koha 23.11 by Bug |added in Koha 23.11 by Bug |33217 - Allow different |33217 - Allow different |default sorting when click |default sorting when click |author links, but only the |author links, but only the |default XSLT files for |default XSLT files for |MARC21 were updated.) |MARC21 were updated.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marion Durand from comment #11)
(In reply to Marcel de Rooy from comment #10)
Although the code looks good to me, I would appreciate a response about the current status of using XSLT for OPAC and intranet on UNIMARC installs.
I'm not sure to understand your question, we often use XSLT in UNIMARC installation. Sometimes with community file, sometimes with custom file.
Looking at the UNIMARC community files, I wonder why they are so small (as compared to their MARC21 counterparts). Are they actually used somewhere, or generally replaced by customization? I listed staff above, here is OPAC: -rw-r--r-- 1 root root 123416 Jul 15 16:07 MARC21slim2OPACDetail.xsl -rw-r--r-- 1 root root 86887 Jul 15 16:07 MARC21slim2OPACResults.xsl -rw-r--r-- 1 root root 40052 Jul 15 16:07 MARC21slimUtils.xsl -rw-r--r-- 1 root root 25784 Jul 18 09:51 UNIMARCslim2OPACDetail.xsl -rw-r--r-- 1 root root 19112 Jun 11 14:04 UNIMARCslim2OPACResults.xsl -rw-r--r-- 1 root root 20546 Jul 18 09:51 UNIMARCslimUtils.xsl For instance OPACDetail is 5x smaller. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #13 from Marion Durand <marion.durand@biblibre.com> --- (In reply to Marcel de Rooy from comment #12)
(In reply to Marion Durand from comment #11)
(In reply to Marcel de Rooy from comment #10)
Although the code looks good to me, I would appreciate a response about the current status of using XSLT for OPAC and intranet on UNIMARC installs.
I'm not sure to understand your question, we often use XSLT in UNIMARC installation. Sometimes with community file, sometimes with custom file.
Looking at the UNIMARC community files, I wonder why they are so small (as compared to their MARC21 counterparts). Are they actually used somewhere, or generally replaced by customization?
I listed staff above, here is OPAC: -rw-r--r-- 1 root root 123416 Jul 15 16:07 MARC21slim2OPACDetail.xsl -rw-r--r-- 1 root root 86887 Jul 15 16:07 MARC21slim2OPACResults.xsl -rw-r--r-- 1 root root 40052 Jul 15 16:07 MARC21slimUtils.xsl -rw-r--r-- 1 root root 25784 Jul 18 09:51 UNIMARCslim2OPACDetail.xsl -rw-r--r-- 1 root root 19112 Jun 11 14:04 UNIMARCslim2OPACResults.xsl -rw-r--r-- 1 root root 20546 Jul 18 09:51 UNIMARCslimUtils.xsl
For instance OPACDetail is 5x smaller.
They are used but, as it was the case here, many functionalities are added in MARC21 but not in UNIMARC. These files might also be simpler with less information (or link) displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182884|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184424&action=edit Bug 39896: Add UNIMARC support for AuthorLinkSortBy This patch add support for AuthorLinkSortBy and AuthorLinkSortOrder in the default UNIMARC XSLT files. The description of the syspref is also slighly updated to hint users of custom XSLT file about the need to update their template. To test: 0. On a UNIMARC database 1. Set AuthorLinkSortBy to 'title' and AuthorLinkSortORder to 'descending' 2. On the intranet and OPAC, search for an author you have multiple titles from and click on a result 3. Click on a link one a name for an author 4. Note a new search is performed, sorted by field from defaultSortField preference and not by title descending 5. Apply the patch 6. restart_all 7. Check that the syspref description now include a note about custom XSLT files 8. Repeat step 2 and 3 9. Note a new search is performed, sorted by title descending 10. Test other values - confirm links are updated in both staff and opac Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thx for your feedback. Passing QA. Just wondering if + - "<br /><strong>NOTE:</strong> If you are using custom XSLT you need to make sure the system preference check is implemented." this is clear enough. But can be improved later. What a dev probably needs to do, is pass those pref values to the relevant template (showAuthor or tag_7xx etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39896 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #19 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org