[Bug 10423] New: Date not well formatted on 'print summary' from patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Bug ID: 10423 Summary: Date not well formatted on 'print summary' from patron account Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 18690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18690&action=edit screenshot The due date printed on the account summary printed from the patron account using the 'print summary' option is not well formatted (see screenshot) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 JaTara Barnes <jendayi30@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37907&action=edit Bug 10423: Show date due with time if it's a hourly loan On printing the summary from the patron account, the hours are not displayed if needed. The as_date_due flag should be set to display it correctly. Problem, GetPendingIssues modify the value retrieved from the database. In order to not add regression and check all calls to GetPendingIssues, this patch backup the value before the change. Test plan: Check some items out, specify a hourly loan for some. Click on print > print summary and confirm the date due are correctly formatted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- The original issue is fixed, but hourly loan are not correctly displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37907|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37947&action=edit Bug 10423: Show date due with time if it's a hourly loan On printing the summary from the patron account, the hours are not displayed if needed. The as_date_due flag should be set to display it correctly. Problem, GetPendingIssues modify the value retrieved from the database. In order to not add regression and check all calls to GetPendingIssues, this patch backup the value before the change. Test plan: Check some items out, specify a hourly loan for some. Click on print > print summary and confirm the date due are correctly formatted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37955&action=edit [ALTERNATIVE PATCH] Bug 10423: Prevent race condition on printing a ReserveSlip The problem has been well described by Kyle and Nicole on bug 7255 description and comment 1. With this counter patch, I suggest to popup AFTER the return has been confirmed. This will remove the race condition and avoid to pass itemnumber to the pl file as in the patch submitted by Olli. Only the borrowernumber and biblionumber are needed (transfer and op are never used by circ/hold-transfer-slip.pl). Test plan: It is very hard to know all cases (at least 6) where the popup is displayed. Try at least to get the hold and the transfer confirmation messages. You should get the popup if you click on "print slip" button. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 38005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38005&action=edit [Signed-off] Bug 10423: Show date due with time if it's a hourly loan On printing the summary from the patron account, the hours are not displayed if needed. The as_date_due flag should be set to display it correctly. Problem, GetPendingIssues modify the value retrieved from the database. In order to not add regression and check all calls to GetPendingIssues, this patch backup the value before the change. Test plan: Check some items out, specify a hourly loan for some. Click on print > print summary and confirm the date due are correctly formatted. Followed test plan. Date + time display as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are quite similar changes in bug 12847 - just noting in case of conflict. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38005|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38109&action=edit [PASSED QA] Bug 10423: Show date due with time if it's a hourly loan On printing the summary from the patron account, the hours are not displayed if needed. The as_date_due flag should be set to display it correctly. Problem, GetPendingIssues modify the value retrieved from the database. In order to not add regression and check all calls to GetPendingIssues, this patch backup the value before the change. Test plan: Check some items out, specify a hourly loan for some. Click on print > print summary and confirm the date due are correctly formatted. Followed test plan. Date + time display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13601 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org