[Bug 30519] New: Regression: using sys pref CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Bug ID: 30519 Summary: Regression: using sys pref CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com With the addition of bug 25261, utilizing the sys pref CircConfirmItemParts and materials specified 952$3, you can no longer use the Check In column on either the morememeber.pl or circulation.pl. To test: --set sys pref to require confirmation --add a materials specified note to an item --check item out to a patron, confirming the note --go to patron record, either moremember or circulation --using the Check In column, attempt to check in the item --notice no confirmation box, and item is not checked in -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master Depends on| |25261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 [Bug 25261] Multiple parts handling - confirmation alert -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #1 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- This regression is still present and still frustrating. Check-ins fail with no message to the user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure this is a regression as it was introduced with a new and optional feature. I am not sure how hard it is to fix this as we don't trigger any modals or alerts from the checkouts/details right now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: using sys pref |Using sys pref |CircConfirmItemParts |CircConfirmItemParts |prevents checkin from |prevents checkin from |moremember.pl and |moremember.pl and |circulation.pl |circulation.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.torin@univ-renne | |s2.fr --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 169522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169522&action=edit Bug 30519: Show Checkin box even if CircConfirmParts is enabled To test: 1. Set the system preference CircConfirmItemParts to require confirmation 2. Add a materials specified note to an item. 3. Check the item out to a patron, confirming the note. 4. Go to patron record, either moremember or circulation 5. Using the Check In column, attempt to check in the item. Notice no confirmation box, and item is not checked in. 6. Apply the patch and restart_all. Also clear your cache. 7. Make sure you have the item with the material specified note still checked out. 8. The Check In column now shows a visible checkin box. Next to the checkin box you will see the material specified note. 9. Click on the checkin box. The “Check in selected items” button now becomes usable. Click on it and notice that the item is now successfully checked in. 10. Sign off and have an amazing day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169522|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 169558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169558&action=edit Bug 30519: Show Checkin box even if CircConfirmParts is enabled To test: 1. Set the system preference CircConfirmItemParts to require confirmation 2. Add a materials specified note to an item. 3. Check the item out to a patron, confirming the note. 4. Go to patron record, either moremember or circulation 5. Using the Check In column, attempt to check in the item. Notice no confirmation box, and item is not checked in. 6. Apply the patch and restart_all. Also clear your cache. 7. Make sure you have the item with the material specified note still checked out. 8. The Check In column now shows a visible checkin box. Next to the checkin box you will see the material specified note. 9. Click on the checkin box. The “Check in selected items” button now becomes usable. Click on it and notice that the item is now successfully checked in. 10. Sign off and have an amazing day! :D Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I'm signing off on this because it accomplishes the stated goal. It does not explicitly force the user to confirm that they have read the materials specified note. It makes the user check the box for the item they wish to check in, and the materials specified note is right next to that box, but that does feel a little bit less explicit. If my patron has multiple items checked out and only one of them has a materials specified note it seems really easy to just click "Select all" and check all those items in without thinking about the note at all. But I feel like I might be over-worrying. So I'm signing off but putting this in a comment for others to ponder while I have my amazing day, as directed:) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Failed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- This solution does seem to present a loophole to the stated purpose of CircConfirmItemParts. The intended behavior when the user attempts to check in an item with specified materials from the checkout table was to reload the table with a warning on that item, highlighted in yellow with a checkbox to explicitly confirm the included materials (see bug 25261#c75). Seems like that error handling got lost somewhere (see bug 25261#c211 and bug 34302), but adding it back in should fix this bug while preserving the intent of CircConfirmItemParts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using sys pref |Using CircConfirmItemParts |CircConfirmItemParts |prevents checkin from |prevents checkin from |patron account in staff |moremember.pl and |interface |circulation.pl | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with Emily that we expect a confirmation step here and that this previous behavior should be brought back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- I will work on updating this and will get a new patch out soon! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org