[Bug 35368] New: "Add a checkout" shows up twice in online documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Bug ID: 35368 Summary: "Add a checkout" shows up twice in online documentation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de CC: tomascohen@gmail.com https://api.koha-community.org/Development.html#tag/checkouts/operation/addC... https://api.koha-community.org/Development.html#tag/checkouts/operation/addC... I think we should add (public) to one of the headings. ... also should we maybe have it read: "check out an item"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 161013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161013&action=edit Bug 35368: Add public to "Add a new checkout" in API documentation Without this patch the "Add a new checkout" label showed up twice in the Checkouts section of the API documentation. This adds (public) to the end of one, to make it possible to distinguish them. To test (ON YOUR HOST MACHINE): 1. Run: $ cd api/v1/swagger $ docker run --rm -v $(pwd):/api --workdir /api redocly/cli \ build-docs swagger.yaml --output index.html 2. Open the generated index.html in your browser 3. Verify doubled up headings 4. Apply patch 5. Re-run docker command form 1. 6. Verify there are now 2 different labels and "(public)" is on the right one. Note: if you have wrong permissions on the file, chown it to your own user to open it in the browser. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161013|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161353&action=edit Bug 35368: Add public to "Add a new checkout" in API documentation Without this patch the "Add a new checkout" label showed up twice in the Checkouts section of the API documentation. This adds (public) to the end of one, to make it possible to distinguish them. To test (ON YOUR HOST MACHINE): 1. Run: $ cd api/v1/swagger $ docker run --rm -v $(pwd):/api --workdir /api redocly/cli \ build-docs swagger.yaml --output index.html 2. Open the generated index.html in your browser 3. Verify doubled up headings 4. Apply patch 5. Re-run docker command form 1. 6. Verify there are now 2 different labels and "(public)" is on the right one. Note: if you have wrong permissions on the file, chown it to your own user to open it in the browser. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161353|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161561&action=edit Bug 35368: Add public to "Add a new checkout" in API documentation Without this patch the "Add a new checkout" label showed up twice in the Checkouts section of the API documentation. This adds (public) to the end of one, to make it possible to distinguish them. To test (ON YOUR HOST MACHINE): 1. Run: $ cd api/v1/swagger $ docker run --rm -v $(pwd):/api --workdir /api redocly/cli \ build-docs swagger.yaml --output index.html 2. Open the generated index.html in your browser 3. Verify doubled up headings 4. Apply patch 5. Re-run docker command form 1. 6. Verify there are now 2 different labels and "(public)" is on the right one. Note: if you have wrong permissions on the file, chown it to your own user to open it in the browser. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org