[Bug 22473] New: Use koha-conf.xml modification time as cache key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 Bug ID: 22473 Summary: Use koha-conf.xml modification time as cache key Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: robin@kallisti.net.nz QA Contact: testopia@bugs.koha-community.org Target Milestone: ---
From this IRC conversation:
<fridolin> rkrimme1: did you flush memcached ? <magnuse> can't hurt :-) <magnuse> and yeah, i think you have to, for changes to koha-conf.xml to be picked up if this is the case, when creating and accessing memcached for koha-conf values, the actual modification time of the koha-conf should be appended to the key values. This means that if the file is updated, the cache is automatically invalid. It requires running stat on each request, but as the koha-conf file isn't actually being opened and parsed, this will be very fast. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 Robin Sheat <robin@kallisti.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86628&action=edit Bug 22473: flush in psgi - V1 Here we are checking on each request That could work, but do not feel robust Moreover it will not affect scripts outside of plack -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86629&action=edit Bug 22473: Two other places that do not work - V2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86630&action=edit Bug 22473: Handle config expiration in C4::Context->new - V3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86631&action=edit Bug 22473: Example of watcher to invalidate config cache - V4 Test plan: perl watchfile.pl then update the config Note that we do not handle everything, for instance the DB credentials will not be taken into account. I guess we could call C4::Context->dbh({ new => 1 }) as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |tomascohen@gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Here are 4 versions (to apply and test separately) that could work. Only the last one (V4) is, in my opinion, viable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not forgotten about this, it's just in a long queue to take a look.. Thanks for all the alternations to look at Jonathan.. I hope to come back to this soon and take a proper look :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org