[Bug 18094] New: Patron search filters are broken by searchable attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Bug ID: 18094 Summary: Patron search filters are broken by searchable attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When using searchable patron attributes they seem to be added to all searches as a contain To recreate: Add a new patron attrbute and mark it searchable Populate a new patron with 'potato' in that field Add/edit another patron to have email potato@invalidemail.com' Perform a patron search with filters 'Email' and 'Starts with' and query 'potato' You will see both patrons in your results Remove the potato email Perform search again You will be directed to the patron containing the potato attribute -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60212&action=edit Bug 18094: Add tests to highlight the problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60213&action=edit Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato@invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60212|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 61111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61111&action=edit Bug 18094: Add tests to highlight the problem Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60213|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 61112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61112&action=edit Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato@invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61111|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61291&action=edit Bug 18094: Add tests to highlight the problem Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61112|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61292&action=edit Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato@invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the 17.05 Release. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.06 . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63015&action=edit [16.05.x] Bug 18094: Add tests to highlight the problem Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63016&action=edit [16.05.x] Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato@invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #13 from Mason James <mtj@kohaaloha.com> --- this patchset currently fails for me on 16.05.x $ prove t/db_dependent/Utils/Datatables_Members.t t/db_dependent/Utils/Datatables_Members.t .. 1/30 # Failed test ''Dupont' is contained in 2 surnames and a patron attribute. Patron attribute one should not be displayed if searching in specific fields (Bug 18094)' # at t/db_dependent/Utils/Datatables_Members.t line 407. # got: '2' # expected: '1' # Looks like you failed 1 test of 2. # Failed test 'ExtendedPatronAttributes' # at t/db_dependent/Utils/Datatables_Members.t line 409. # Looks like you failed 1 test of 30. t/db_dependent/Utils/Datatables_Members.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/30 subtests Test Summary Report ------------------- t/db_dependent/Utils/Datatables_Members.t (Wstat: 256 Tests: 30 Failed: 1) Failed test: 30 Non-zero exit status: 1 Files=1, Tests=30, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.74 cusr 0.22 csys = 2.00 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You need the 2 patches, not just the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #15 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I've tried to use this in 3.22.20 but I can't manage to search on a attribute that I've marked as searchable. I'm wondering if I miss something.. After checking "searchable" for an attribute, could I launch a search directly or should I do another action (restart plack, modify my patron using this attribute ?) Attributes are searchable in the "standard search fields" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Koha Team Lyon 3 from comment #15)
I've tried to use this in 3.22.20 but I can't manage to search on a attribute that I've marked as searchable. I'm wondering if I miss something.. After checking "searchable" for an attribute, could I launch a search directly or should I do another action (restart plack, modify my patron using this attribute ?) Attributes are searchable in the "standard search fields" ?
Nope you do not have to do anything like that. Attributes are only searchable in standard search fields. Tested ok on 3.22.21. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #17 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Thanks Jonathan ! Ok, I got it. I have tried with attributes which have Authorized value category. I tryed to search with the description (which I can read in patron detail) but in fact the search only works with Authorized value Code ! I will open a new bug for this. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ha yes indeed, good catch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- At first glance I'd say it will not that easy to fix and may be a performance killer change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 [Bug 33428] Should only search in searchable patron attributes if searching in standard fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33428 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 [Bug 33428] Should only search in searchable patron attributes if searching in standard fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 vijayakumar <esiasclib2016@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esiasclib2016@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org