[Bug 14670] New: add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Bug ID: 14670 Summary: add 'cite' option to detail page in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 41441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41441&action=edit cite option & pop up It would be nice if we could add a 'cite' option to the menu on the right of the opac detail pages like in some other discovery interfaces - see attached. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |martin@bugs.koha-community. | |org.xinxidi.net Assignee|oleonard@myacpl.org |martin@bugs.koha-community. | |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #1 from Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> --- Created attachment 42971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42971&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42971|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 43508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43508&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> I love it, I'd recommend adding an icon to the menu next to it, but this patch works as described so I'm signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comments: 1/ New subroutines have to be covered by tests 2/ You should provide the related change for opac.less Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #4 from Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> --- Created attachment 43770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43770&action=edit Bug 14670: add related css changes to opac.less -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #5 from Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> --- Created attachment 43771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43771&action=edit Bug 14670: add test for C4::Record::marc2cites -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Failed QA |Signed Off --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Martin, it's usually ok to switch back to signed off once you have provided patches fixing the QA issues - this way it will get reviewed again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please launch the QA script before submitting patches: FAIL C4/Record.pm FAIL critic # ControlStructures::ProhibitMutatingListFunctions: Got 1 violation(s). FAIL valid "my" variable @authors masks earlier declaration in same scope use perl -wc and perlcritic to get more info. There is something wrong with the css/less files, but it already exists on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #8 from Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> --- Sorry about that, didn't know about the QA test tool. Issues are fixed, attaching two patches below. What is wrong with the css/less? Is it something introduced with any of the 14670 patches? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #9 from Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> --- Created attachment 43828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43828&action=edit Bug 14670: Fix earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #10 from Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> --- Created attachment 43829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43829&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Stenberg <martin@bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't feel like this is ready to be pushed quite yet. I will give some examples: 1) If a record (serials?) don't have a publication year, the styles will look like this: APA (). Handelsblatt. Düsseldorf: Verl.-Gruppe Handelsblatt. Chicago . Handelsblatt. Düsseldorf: Verl.-Gruppe Handelsblatt. Harvard (). Handelsblatt. Düsseldorf: Verl.-Gruppe Handelsblatt. MLA Handelsblatt. Düsseldorf: Verl.-Gruppe Handelsblatt. . So it doesn't cover for the case the publication year doesn't exist in the record. Another case are articles - the citation will miss the host item information, which is very vital for those: APA Schweizer K., . (2010). 100 Jahre Internationaler Frauentag. : . Chicago Schweizer Karl, . 2010. 100 Jahre Internationaler Frauentag. : . Harvard Schweizer K., . (2010). 100 Jahre Internationaler Frauentag. : . MLA Schweizer Karl, . 100 Jahre Internationaler Frauentag. : . 2010. I think this needs more testing with different type of media. Also one small thing, that I had fixed for a follow-up, but will put here as a comment now: - place => $record->subfield("260", "a") || "", + place => $record->subfield("264", "a") || $record->subfield("260", "a") || "", publisher => $record->subfield("264", "b") || $record->subfield("260", "b") || "", Last but not least: I am reattaching the patches with a follow up taking care of a conflict in the opac.css. I have removed it from the first patch and put the fixed file into a separate patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43508|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43919&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43770|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43920&action=edit Bug 14670: add related css changes to opac.less -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43771|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43921&action=edit Bug 14670: add test for C4::Record::marc2cites -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43828|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43922&action=edit Bug 14670: Fix earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43829|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43923&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43924&action=edit Bug 14670: QA follow-up: Regenerated opac.css The first patch originally contained the changes opac.css. I removed the file to fix the conflict. This patch readds the opac.css changes generated from the changes to the .less file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #18 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Thanks for all the feedback and help! We sort of hoped that this would be more of a good "warm up" patch and with time running out for Martin in our project I have to point him in other directions so we're abandoning this one. We may be able to pick it up later, but I don't dare to make any such promises. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org