[Bug 11298] New: Renewal due date won't take specified time into account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Bug ID: 11298 Summary: Renewal due date won't take specified time into account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: - Check out an item that is renewable - Renew setting a manual renwal due date, change the time from 23:59 to something else - Renew - Verify that the time is set to 23:59 instead of your chosen time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- It seems to be fixed, please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but this still appears to be an issue for me - retested in current master. My renewal date shows as 07/31/2015 10:59, but the renewal is only made to 07/31/2015 23:59. The time is not taken into account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41356&action=edit Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 [Bug 11703] Convert checkouts table to ajax datatable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Hi, I tested it on a sand box and I do not have good results. The commands fails and nothing happens. See video here https://owncloud.ccsr.qc.ca/index.php/s/jxTIuf3cq0cl5j9/download Regards Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry Marjorie but I don't manage to watch the video, vlc simply displays an image, nothing moves. Could you please describe the problem? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #6 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- (In reply to Jonathan Druart from comment #5)
Sorry Marjorie but I don't manage to watch the video, vlc simply displays an image, nothing moves. Could you please describe the problem?
Hi Jonathan, When i choose a renewal due date, it just hang forever, nothing happens. See capture attached. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #7 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Created attachment 43254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43254&action=edit renewal due date -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you check the log file? Looks good here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #9 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- (In reply to Jonathan Druart from comment #8)
Could you check the log file? Looks good here.
Sorry Jonathan, I tested it again and it do not work. I don't know if you want logs of action_logs or logs of browser? I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an error in console like: Uncaught SynthaxError : Unexpected token circulation.pl:180 Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marjorie Barry-Vila from comment #9)
(In reply to Jonathan Druart from comment #8)
Could you check the log file? Looks good here.
Sorry Jonathan, I tested it again and it do not work.
I don't know if you want logs of action_logs or logs of browser?
I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an error in console like: Uncaught SynthaxError : Unexpected token circulation.pl:180
Marjorie
I was asking for the Koha log file, on the server. Could you confirm you don't get this error without the patch and that your pref IntranetUserJS is empty? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #11 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- (In reply to Jonathan Druart from comment #10)
(In reply to Marjorie Barry-Vila from comment #9)
(In reply to Jonathan Druart from comment #8)
Could you check the log file? Looks good here.
Sorry Jonathan, I tested it again and it do not work.
I don't know if you want logs of action_logs or logs of browser?
I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an error in console like: Uncaught SynthaxError : Unexpected token circulation.pl:180
Marjorie
I was asking for the Koha log file, on the server. Could you confirm you don't get this error without the patch and that your pref IntranetUserJS is empty?
I don't know how see koha log file on the server, action_logs? In my version 3.18.04, when I make a renewal, it works and I have no error in console but hour of date is not considered. Sorry. Maybe someone else can test on a sandbox? The problem may come from me. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41356|0 |1 is obsolete| | --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 43341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43341&action=edit Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used. Followed test plan. It works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off --- Comment #13 from Marc Véron <veron@veron.ch> --- Note: I tested on current master (3.21.00.034) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43341|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43569&action=edit [PASSED QA] Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used. Followed test plan. It works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #17 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org