[Bug 18869] New: Patron clubs and templates tables look strange when empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Bug ID: 18869 Summary: Patron clubs and templates tables look strange when empty Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Created attachment 64684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64684&action=edit Patron clubs interface showing tables The tables for patron clubs and club templates should not show at all if they are empty. Also the clubs table is slightly broken. See screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64687&action=edit Bug 18869: Fixing display of patron clubs tables This patch 1) Hides the club templates table if there are no club templates, shows an appropriate message 2) Hides the clubs table if there are no clubs. Shows an appropriate message for whether templates exist 3) Puts the actions in one column, or a dropdown menu Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Keywords| |Academy Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |In Discussion --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- It looks good. REPRODUCE OUTPUT QUESTION: Add a template Add a club Delete a club Just quick question. If there are no templates or clubs, should it not revert to this new style of nothing? Or is this okay? If it is okay, then I'll sign off. If it should revert to the initial nothing style, then this needs a tweak. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64936&action=edit Bug 18869: [FOLLOW-UP] Make page reload after club or template delete If deleting the last club or template in a table, the row is deleted from the webpage by ajax so the nice blue bubble message does not show. This patch forces the page to reload so the blue bubble message shows instead of the empty table. To test: Confirm that the blue message shows when tables are empty. Add a template and a club, then delete a club. Confirm the page reloads and the message shows. Test with template Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64946&action=edit Bug 18869: [FOLLOW-UP] Show enrollments as disabled link if club has no enrolled patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64687|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65443&action=edit [SIGNED-OFF] Bug 18869: Fixing display of patron clubs tables This patch 1) Hides the club templates table if there are no club templates, shows an appropriate message 2) Hides the clubs table if there are no clubs. Shows an appropriate message for whether templates exist 3) Puts the actions in one column, or a dropdown menu Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65444&action=edit [SIGNED-OFF] Bug 18869: [FOLLOW-UP] Make page reload after club or template delete If deleting the last club or template in a table, the row is deleted from the webpage by ajax so the nice blue bubble message does not show. This patch forces the page to reload so the blue bubble message shows instead of the empty table. To test: Confirm that the blue message shows when tables are empty. Add a template and a club, then delete a club. Confirm the page reloads and the message shows. Test with template Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65445&action=edit [SIGNED-OFF] Bug 18869: [FOLLOW-UP] Show enrollments as disabled link if club has no enrolled patrons Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64936|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64946|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- I figured I wouldn't let it languish. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65443|0 |1 is obsolete| | Attachment #65444|0 |1 is obsolete| | Attachment #65445|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66650&action=edit Bug 18869: Fixing display of patron clubs tables This patch 1) Hides the club templates table if there are no club templates, shows an appropriate message 2) Hides the clubs table if there are no clubs. Shows an appropriate message for whether templates exist 3) Puts the actions in one column, or a dropdown menu Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66651&action=edit Bug 18869: [FOLLOW-UP] Make page reload after club or template delete If deleting the last club or template in a table, the row is deleted from the webpage by ajax so the nice blue bubble message does not show. This patch forces the page to reload so the blue bubble message shows instead of the empty table. To test: Confirm that the blue message shows when tables are empty. Add a template and a club, then delete a club. Confirm the page reloads and the message shows. Test with template Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66652&action=edit Bug 18869: [FOLLOW-UP] Show enrollments as disabled link if club has no enrolled patrons Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 [Bug 19215] Typo in URL when editing a patron club template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org