[Bug 43965] New: xt/check-thead-tt-tags.t requires a new entry when a new table is added to a Vue app
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 Bug ID: 43965 Summary: xt/check-thead-tt-tags.t requires a new entry when a new table is added to a Vue app Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 42332 Target Milestone: --- The list of the tables from Vue apps are listed in xt/check-thead-tt-tags.t, so we can skip them for the check. It's not good, we don't want to edit this file everytime we add a new table to a Vue app. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 [Bug 42332] Remove conditional TT tags from tables thead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30557 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 210080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210080&action=edit Bug 43965: Detect Vue tables automatically in xt/check-thead-tt-tags.t Instead of adding an entry to @vue_tables each time a table is added to a Vue component, detect them: the TT file hosting the Vue app includes a bundle with [% Asset.js("js/vue/dist/<name>.js") | $raw %] and passes the table settings with TablesSettings.GetTableSettings( module, page, table_id, 'json' ). Test plan prove xt/check-thead-tt-tags.t should still return green. Note that you will need those 2 commits pushed first: Bug 31391: Remove conditional TT tag from thead Bug 30557: Fix xt/check-thead-tt-tags.t failures Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #210080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 210089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210089&action=edit Bug 43965: Detect Vue tables automatically in xt/check-thead-tt-tags.t Instead of adding an entry to @vue_tables each time a table is added to a Vue component, detect them: the TT file hosting the Vue app includes a bundle with [% Asset.js("js/vue/dist/<name>.js") | $raw %] and passes the table settings with TablesSettings.GetTableSettings( module, page, table_id, 'json' ). Test plan prove xt/check-thead-tt-tags.t should still return green. Note that you will need those 2 commits pushed first: Bug 31391: Remove conditional TT tag from thead Bug 30557: Fix xt/check-thead-tt-tags.t failures Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #210089|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 210143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210143&action=edit Bug 43965: Detect Vue tables automatically in xt/check-thead-tt-tags.t Instead of adding an entry to @vue_tables each time a table is added to a Vue component, detect them: the TT file hosting the Vue app includes a bundle with [% Asset.js("js/vue/dist/<name>.js") | $raw %] and passes the table settings with TablesSettings.GetTableSettings( module, page, table_id, 'json' ). Test plan prove xt/check-thead-tt-tags.t should still return green. Note that you will need those 2 commits pushed first: Bug 31391: Remove conditional TT tag from thead Bug 30557: Fix xt/check-thead-tt-tags.t failures Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43965 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Adding my sign off, in case Andrew's can count for the QA. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org