[Bug 37199] New: Incorrect "waiting holds" notification for staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37199 Bug ID: 37199 Summary: Incorrect "waiting holds" notification for staff Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: slavashishkin@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 34668 There is an issue with the "WaitingNotifyAtCheckout" system preference, where staff receive incorrect "This patron has waiting holds" pop-up notifications for users during checkout. Steps to reproduce: 1. Set the system preference "WaitingNotifyAtCheckout" to "Notify". 2. Place a hold on one of the available items for patron (A). 3. Check out another available item from the same bibliographic record to patron (B). 4. Verify that staff receive a pop-up notification "This patron has waiting holds", even if patron (B) has no holds from the same bibliographic record. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 [Bug 34668] Notify staff with a pop-up about waiting holds for a patron when checking out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37199 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37199 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 168154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168154&action=edit Bug 37199: Incorrect "waiting holds" notification for staff - Modified `circ/circulation.pl` to ensure the `waiting_holds` search results are correctly processed using `as_list`. Previously, the search results were passed as an object, which always evaluated to true. By converting the search results to a list, we ensure proper handling and checking of waiting holds. Test Plan: 1. Apply the patch. 2. Set the system preference "WaitingNotifyAtCheckout" to "Notify". 3. Place a hold on one of the available items for a patron (A). 4. Check out another available item from the same bibliographic record to a patron (B). 5. Verify that staff do not receive the incorrect notification when checking out items to patron (B). 6. Ensure the functionality works as expected when checking out items to patron (A). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37199 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Thanks for adding this bug to report this issue, and adding a patch! It looks like this is a duplicate of bug 37055, which is signed off and waiting for quality assurance review. I've marked your bug as a duplicate. Thanks again. David Nind *** This bug has been marked as a duplicate of bug 37055 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37199 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34668 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37199 Bug 37199 depends on bug 34668, which changed state. Bug 34668 Summary: Notify staff with a pop-up about waiting holds for a patron when checking out https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org