[Bug 20740] New: Update two-column templates with Bootstrap grid: Administration part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Bug ID: 20740 Summary: Update two-column templates with Bootstrap grid: Administration part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 20668 Blocks: 20654 This patch will convert yet more administration templates to use the Bootstrap grid: - currency.tt - didyoumean.tt - edi_accounts.tt - edi_ean_accounts.tt - items_search_field.tt - items_search_fields.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Bug 20740 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77017&action=edit Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 This patch modifies several administration templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Administration -> Currencies and exchange rates - View and edit currencies - Administration -> Did you mean? - Administration -> EDI accounts - View and edit accounts - Administration -> Library EANs - View and edit EANs - Administration -> Item search fields - View and edit item search fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- In currencies and exchange rates the table appears to the right of the Column visibility etc buttons. Should it be below rather than next to? Other pages are all fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Claire Gravely from comment #2)
In currencies and exchange rates the table appears to the right of the Column visibility etc buttons. Should it be below rather than next to?
I have fixed this in a separate bug as it is unrelated to the changes in this patch. Bug 21234. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77017|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 77927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77927&action=edit Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 This patch modifies several administration templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Administration -> Currencies and exchange rates - View and edit currencies - Administration -> Did you mean? - Administration -> EDI accounts - View and edit accounts - Administration -> Library EANs - View and edit EANs - Administration -> Item search fields - View and edit item search fields Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77927|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77941&action=edit Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 This patch modifies several administration templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Administration -> Currencies and exchange rates - View and edit currencies - Administration -> Did you mean? - Administration -> EDI accounts - View and edit accounts - Administration -> Library EANs - View and edit EANs - Administration -> Item search fields - View and edit item search fields Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have rebased the patch on top of bug 13618 as it should be the next one to be pushed. Also found bug 21239 while testing (not caused by this patch). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org