https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79255&action=edit Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79255|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23@gmail.com> --- Created attachment 79407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79407&action=edit Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79407|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79486&action=edit Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6)

(In reply to Martin Renvoize from comment #5)

...

Pushed to 18.05.x for 18.05.05

This one causes the failing test on Jenkins koha_1 | Undefined subroutine &C4::Items::ModZebra called at /kohadevbox/koha/C4/Items.pm line 302.

See bug 21133, I have attached a version for 18.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #8)

Bug 19191 nor Bug 20631 in 17.11.x but must it be pushed anyway ?

If there is the call to ReturnLostItem, yes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ok there is ReturnLostItem, Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79486|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81981&action=edit [17.11.x] Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #11)

(In reply to Fridolin SOMERS from comment #10)

...

Ok there is ReturnLostItem,

Pushed to 17.11.x for 17.11.12

Ok not OK, it brakes UT t/db_dependent/Members/GetOverdues.t t/db_dependent/Members/GetPendingIssues.t

I dont understand why, I revert.

These test files do no longer exist in master, and so have not been modified by bug 21133. -- You are receiving this mail because: You are watching all bug changes.