[Bug 18244] New: Patron card creator does not take in account fields with underscore ( B_address etc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Bug ID: 18244 Summary: Patron card creator does not take in account fields with underscore (B_address etc.) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. <surname><B_address> ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |veron@veron.ch |u | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 60984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60984&action=edit Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. <surname><B_address> ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org Status|Needs Signoff |Failed QA --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- I have applied the patch on two different computers, confirmed the changes in the patch, but I see no difference. I still get the field name instead of the value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 61590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61590&action=edit Patron card layout settings to test B_address (In reply to Christopher Brannon from comment #2)
I have applied the patch on two different computers, confirmed the changes in the patch, but I see no difference. I still get the field name instead of the value.
I re-tested with the settings for a test layout, see screenshot attached. Field <B_address> displays it's contents as expected. - What are your settings? - Restart Plack? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- I've cleared cache, restarted apache2, restarted memcache, restarted all (restart_all), no luck. I'm using the demo layout that installed with Koha, and just editing the 2nd field to read "Address: <B_address>" I go to manage Card batches and on my one patron I click Export. When I open the pdf, I still see <B_address>. I will attach my screen shots. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 61591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61591&action=edit My card layout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 61592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61592&action=edit My card export with field name showing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 61611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61611&action=edit Re-testing same settings as in screenshot comment #5 (In reply to Christopher Brannon from comment #4)
I've cleared cache, restarted apache2, restarted memcache, restarted all (restart_all), no luck.
I'm using the demo layout that installed with Koha, and just editing the 2nd field to read "Address: <B_address>"
I go to manage Card batches and on my one patron I click Export. When I open the pdf, I still see <B_address>.
I will attach my screen shots.
I repeated with your settings, it works as expected (see screenshot attached). After taking the screenshots, I tested with other B_-fields as well, e.g. <B_city>, they display as expected. It did not work immediately after applying the patch, I had to re-start Plack and to reload the page for batch management. Tested with single export and with export of entire batch. Hmm, where is the difference...? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> ---
I repeated with your settings, it works as expected (see screenshot attached). After taking the screenshots, I tested with other B_-fields as well, e.g. <B_city>, they display as expected.
It did not work immediately after applying the patch, I had to re-start Plack and to reload the page for batch management. Tested with single export and with export of entire batch.
Hmm, where is the difference...?
Don't know. I've tried everything I know. Don't know why loading a patch should be this difficult. I even tried another browser. If it is sticking anywhere, it is on the server side, not the browser, since the change is not reflected in a new browser. I'll keep beating up on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Are you testing the patch on a dedicated test server, or are you using kohadevbox? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #10 from Marc Véron <veron@veron.ch> --- Not kohadevbox. It's a VM with an install from packets that I gitified. Current version is 16.12.00.015 Just an idea because I remember a similar situation: What happens if you edit the patched C4/Patroncards/Patroncard.pm file and intentionally insert some errors in order to make it crash? - Can you provoke the crash or does export still behave as before? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- Throwing stray text into the file you patched doesn't seem to effect anything. I know my test environment is working, as I can apply another patch and see the effects of it right away. We're missing something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #12 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 61629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61629&action=edit [SIGNED OFF] Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. <surname><B_address> ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected Works as expected. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- Note to kohadevbox testers: disable plack. Kohadevbox is not pointing to all the files in the kohaclone environment with plack enabled. This is an issue with kohadevbox, not the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60984|0 |1 is obsolete| | Attachment #61629|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61701&action=edit Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. <surname><B_address> ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18244 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #18 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org