[Bug 17315] New: Can't add entry to lists using link in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Bug ID: 17315 Summary: Can't add entry to lists using link in result list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When adding a record to a list using the links in the result list, the link contains the biblionumber, but in the window the URL ends 'biblionumber=' and the entry is not added to the list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Confirmed. It seems that the param is removed by the 'Dopop' JavaScript function. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17210 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 [Bug 17210] Remove use of onclick from biblio detail sidebar in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55713&action=edit Bug 17315: (Bug 17210 follow-up) Fix "Save to lists" links from the result page On bug 17210, the selector .addtoshelf should not have caught the .addtoshelf nodes from the result list. To fix this, we just need to make the selector more specific (and cannot reuse it without more changes, the biblionumber variable is not the same - vs SEARCH_RESULT.biblionumber). Test plan: Make sure the 2 links (from detail and search result) "Save to lists" and "Save to your lists" work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55713|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 55716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55716&action=edit Bug 17315: (Bug 17210 follow-up) Fix "Save to lists" links from the result page On bug 17210, the selector .addtoshelf should not have caught the .addtoshelf nodes from the result list. To fix this, we just need to make the selector more specific (and cannot reuse it without more changes, the biblionumber variable is not the same - vs SEARCH_RESULT.biblionumber). Test plan: Make sure the 2 links (from detail and search result) "Save to lists" and "Save to your lists" work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55716|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55801&action=edit [PASSED QA] Bug 17315: (Bug 17210 follow-up) Fix "Save to lists" links from the result page On bug 17210, the selector .addtoshelf should not have caught the .addtoshelf nodes from the result list. To fix this, we just need to make the selector more specific (and cannot reuse it without more changes, the biblionumber variable is not the same - vs SEARCH_RESULT.biblionumber). Test plan: Make sure the 2 links (from detail and search result) "Save to lists" and "Save to your lists" work as expected. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org