https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142720&action=edit Bug 32019: Add option to makr items returned via batch modification Ther are options that allow avoiding marking an issue returned when se tot lost. Libraries do this to tie a lost item to a patron clearly. Eventually, after the patron has paid, or after some time, the library may wish to delete the item. When doing so, they do not wish to check the item in and affect any statuses or fines. This is also true for withdrawn items It would be helpful to have a way to mark issues returned in bulk, when they have not been marked returned in the past To test: 1 - Apply patches 2 - Restart all 3 - Set 'MarkLostItemsAsReturned' system preferences to 'None' 4 - Check out some items that have replacement fees set 5 - Mark them lost 6 - Check out more items, mark them withdrawn 7 - Set system preference 'BlockReturnOfWithdrawnItems' to block 8 - Enter item barcodes into batch modification 9 - Leave 'Mark items returned as blank 10 - Verify nothing was checked in 11 - Repeat but set 'Mark items as returned' to 'No' 12 - Verify nothing was checked in 13 - Repeat, but set 'Mark items as returned' to 'Yes' 14 - Verify items are returned 15 - Verify no fines have been adjusted 16 - Verify withdrawn items are sitll withdrawn 17 - Verify you can now delete the items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31031 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142719|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 142764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142764&action=edit Bug 32019: Unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #5 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 142766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142766&action=edit options display The dropdown is a little disconnected from itself. The way the explanatory text is to the left of the heading "Mark items returned" is somewhat visually confusing, and will become more so if further options are added. Can that text go under the heading instead? Also, please add periods to "This option allows returning items to remove them from patron accounts" and "This feature is intended to allow removal and deletion of items without affecting fines or other statuses" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)

Sorry, ending up with some questions here:

0) Terminology

I have several terminology issues here in the GUI, but also in the code, we are still horribly inconsistent all over. Please update at least the note on the form and use . for ending sentences :)

What statuses would remain untouched? It's used several times as an explanation, but I am not sure what is meant actually.

I added some explanation and added periods - it is wierd here because we are not really doing a normal check in - we are just moving the item to old issues. By not affecting statuses I mean that normal check in things won't happen - we don't see if check in is allowed, we don't update fines, we don't change shelving location or holding branch

1) I assume we skip here, because they will be re-indexed when the job is processed later on?

+ skip_record_index => 1, + skip_holds_queue => 1,

If we don't update the index, the item would still show as checked out in the result list.

The reindex happens to all items affected by batch mod in a single operation at the end

2) Options on the form are misaligned in the form in the new staff interface design.

Should be improved

3) Why the empty setting? Wouldn't it make sense to preset to 'No'?

Ok

4) You said this is to allow the library to delete the item.

"Eventually, after the patron has paid, or after some time, the library may wish to delete the item. When doing so, they do not wish to check the item in and affect any statuses"

Why not add this option to the item batch delete form then?

While that is one use, I don't think it is the only use - some libraries simply want the option to get these items off a patrons account without triggering all the things a check in does. If a library chooses not to 'MarkLostItemsReturned' they have no way to recreate that action later. This is to fill that gap -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142824&action=edit Bug 32019: Add option to mark items returned via batch modification Ther are options that allow avoiding marking an issue returned when se tot lost. Libraries do this to tie a lost item to a patron clearly. Eventually, after the patron has paid, or after some time, the library may wish to delete the item. When doing so, they do not wish to check the item in and affect any statuses or fines. This is also true for withdrawn items It would be helpful to have a way to mark issues returned in bulk, when they have not been marked returned in the past To test: 1 - Apply patches 2 - Restart all 3 - Set 'MarkLostItemsAsReturned' system preferences to 'None' 4 - Check out some items that have replacement fees set 5 - Mark them lost 6 - Check out more items, mark them withdrawn 7 - Set system preference 'BlockReturnOfWithdrawnItems' to block 8 - Enter item barcodes into batch modification 9 - Leave 'Mark items returned as blank 10 - Verify nothing was checked in 11 - Repeat but set 'Mark items as returned' to 'No' 12 - Verify nothing was checked in 13 - Repeat, but set 'Mark items as returned' to 'Yes' 14 - Verify items are returned 15 - Verify no fines have been adjusted 16 - Verify withdrawn items are sitll withdrawn 17 - Verify you can now delete the items Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 26835 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142823|0 |1 is obsolete| | Attachment #142824|0 |1 is obsolete| | Attachment #142825|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145294&action=edit Bug 32019: Unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145296&action=edit Bug 32019: (follow-up) Fix terminology and styling This patch adds periods to description on batch mod form and alters language to follow proper terminology Styling is fixed to align forms Blank option is removed, No made default Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk --- Comment #17 from Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> --- We'd like to be able to use the batch editor to checkin items in bulk. We had assumed this was possible but the existing function does seem to work in the way we had expected. We want to be able to checkin in a batch for items in transit -- You are receiving this mail because: You are watching all bug changes.