[Bug 6895] New: Diacritics in Pootle/po files are broken in source text
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Bug #: 6895 Summary: Diacritics in Pootle/po files are broken in source text Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Created attachment 5491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5491 pootle screenshot In Pootle diacritics in terms that are to be translated are broken. (See screenshot for example) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|enhancement |normal --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-05 02:10:45 UTC --- Definitely a bug not a new feature, looking into this now, with the hope of getting it fixed before string freeze -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-05 03:18:17 UTC --- I have found the problem binmode( OUTPUT, ":utf8" ); In xgettext.pl is causing the problems, without it though we get this Wide character in print at ./xgettext.pl line 230. Wide character in print at ./xgettext.pl line 230. /tmp/chKkLCrt0N:53997:14: invalid multibyte sequence /tmp/chKkLCrt0N:77820:9: invalid multibyte sequence msgmerge: found 2 fatal errors Will look into fixing the wide characters now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-05 03:41:21 UTC --- Created attachment 5709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5709 Bug 6895 : First attempt at fixing the diacritics bug This is a fairly hacky solution, a counter patch would be more than welcome -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-05 06:33:41 UTC --- I am testing this and a first test with 3.4.5 looks very promising. I have updated the German po files using 'perl translate update de-DE'. Not a lot of strings need retranslating and all the 'candidates' like names with diacritics from the about page seem to show up in my list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5709|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-06 06:55:23 UTC --- Created attachment 5730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5730 signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 15:38:26 UTC --- Created attachment 5858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5858 Bug 6895 : First attempt at fixing the diacritics bug This is a fairly hacky solution, a counter patch would be more than welcome Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Updated, translated and installed German po files after applying this patch. No problems found. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5730|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 15:46:37 UTC --- QA comment * it used to work in 3.2-, so it must have been caused by the switch to T::T. Investigating xgettext.pl history, it seems it has been added by a patch from chris, in april. * I don't know what kind of counter-patch should be sent, the patch switches back to the previous behaviour that was OK * diacritics in english version are almost only in about.pl, in the contributor list. It means they are not translated, but names does not need to be translated, so the problem is not a major one (that's why noone spotted it before) * why is there -<p class="submit"><input id="submit" type="submit" value="Login »" tabindex="4" /></p> +<p class="submit"><input id="submit" type="submit" value="Login" tabindex="4" /></p> and -<p class="submit"><input id="submit" type="submit" value="Login »" tabindex="4" /></p> +<p class="submit"><input id="submit" type="submit" value="Login" tabindex="4" /></p> in the patch ? If i'm not mistaking it's not related to this problem. (the macles.tt has probably be used for testing purposes. Chris, please resubmit a patch removing those lines, i'll mark passed QA, as it fixes the problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-12 19:57:03 UTC --- No those characters break the translation, along with the fixed diacritics, changing the to actual utf8 characters makes the string translatable. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-13 06:57:44 UTC --- OK, passed QA then -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |frederic@tamil.fr Version|rel_3_4 |rel_3_6 Patch Status|Passed QA |Patch Pushed AssignedTo|frederic@tamil.fr |chris@bigballofwax.co.nz --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-04 07:09:53 UTC --- Patch pushed, please test (my 1st push!!!) (cced the translation manager) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-24 11:51:13 UTC --- It seems this bug has reoccured in 3.6.4. The diacritics are broken again in the source files, requiring to be retranslated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 --- Comment #12 from Frédéric Demians <frederic@tamil.fr> 2012-02-24 12:09:01 UTC --- Created attachment 7851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7851 Proposed patch Apply on HEAD/3.6.x Very needed for next 3.6.x (3.6.5) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5858|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-24 19:59:06 UTC --- (In reply to comment #12)
Created attachment 7851 [details] Proposed patch
Apply on HEAD/3.6.x Very needed for next 3.6.x (3.6.5)
I wonder how it crept back in? Ah ha! Commit 263dded8 For bug 6752 Yep this patch undoes the accidental regression. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7851|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-24 20:00:04 UTC --- Created attachment 7865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7865 Bug 6895 Diacritics in Pootle/po files are broken in source text To test: git checkout 3.6.x cd misc/translator ./tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/prog/en/ \ -s ./po/fr-FR-i-opac-t-prog-v-3006000.po -r po/fr-FR-i-opac-t-prog-v-3006000.po contains broken diacritics for NORMARC strings for example Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P1 - high Status|Needs Signoff |Signed Off Severity|normal |blocker -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #15 from Ian Walls <koha.sekjal@gmail.com> 2012-02-24 20:19:46 UTC --- Simple patch to fix one-line regression caused by blanket changes in bug 6752. As noted on that bug, there could be such regressions, but we'd have time to catch them. So here's catching. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Depends on| |6752 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6895 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org