[Bug 20259] New: Shorter JS and CSS rewrite rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Bug ID: 20259 Summary: Shorter JS and CSS rewrite rule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 20187 has changed the JS and CSS rewrite rules to : RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L] RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L] This can be written more short with one rule and [0-9]{N}. And the dot in extension needs to be escaped : \.js \.css -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 [Bug 20187] New rewrite rules can break custom css -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 72014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72014&action=edit Bug 20259: Shorter JS and CSS rewrite rule Bug 20187 has changed the JS and CSS rewrite rules to : RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L] RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L] This patch changes this rules using [0-9]{N} and fusion in one rule. And espaces the dot in extension js and css. Test plan : 1) Go to intranet and opac 2) Check CSS and JS are doing well 3) Apply patch changes on our Apache configuration 4) Reload intranet and opac pages (Ctrl + F5) 5) Check CSS and JS are doing well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hum, I tried that and it did not work. Will try again later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20187 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- It works for me. (Apache was restarted, double checked that) Also tried the test plan from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187#c8 And checked the login pages. Tested with Apache 2.4.18 on Ubuntu 16.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com --- Comment #4 from Charles Farmer <charles.farmer@inlibro.com> --- Only seeing 200's on my station. Looks good. Tested with: Server version: Apache/2.4.18 (Ubuntu) Server built: 2018-04-18T14:53:04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72014|0 |1 is obsolete| | --- Comment #5 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 76111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76111&action=edit Bug 20259: Shorter JS and CSS rewrite rule Bug 20187 has changed the JS and CSS rewrite rules to : RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L] RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L] This patch changes this rules using [0-9]{N} and fusion in one rule. And espaces the dot in extension js and css. Test plan : 1) Go to intranet and opac 2) Check CSS and JS are doing well 3) Apply patch changes on our Apache configuration 4) Reload intranet and opac pages (Ctrl + F5) 5) Check CSS and JS are doing well Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76111|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76147&action=edit Bug 20259: Shorter JS and CSS rewrite rule Bug 20187 has changed the JS and CSS rewrite rules to : RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L] RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L] This patch changes this rules using [0-9]{N} and fusion in one rule. And espaces the dot in extension js and css. Test plan : 1) Go to intranet and opac 2) Check CSS and JS are doing well 3) Apply patch changes on our Apache configuration 4) Reload intranet and opac pages (Ctrl + F5) 5) Check CSS and JS are doing well Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 --- Comment #8 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- If I understand correctly: The good thing is that people can keep the old rule without issue so they won't have to change the RewriteRules for 18.05 and 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #8)
If I understand correctly: The good thing is that people can keep the old rule without issue so they won't have to change the RewriteRules for 18.05 and 18.11
Yes, they are similar but one is easier to read. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not going to backport this to 18.05.x, save surprising users having to intervene during package upgrades, especially as the rule change is a cosmetic one for server administrators only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #10)
I'm not going to backport this to 18.05.x, save surprising users having to intervene during package upgrades, especially as the rule change is a cosmetic one for server administrators only.
Indeed, server administrators love makeup ;) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org