http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11719&action=edit opac display -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12069&action=edit Bug 8661 - break out additional authors in opac like in staff This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12069|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12073&action=edit [SIGNED-OFF] Bug 8661 - break out additional authors in opac like in staff This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- This patch does not apply on current master. it seems the commit that updated master was a long time ago (30f4b815, in february). Was the patch made against 3.8 ? Anyway, please rebase & resubmit. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12073|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13025&action=edit Bug 8661 - break out additional authors in opac like in staff This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13025|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 13054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13054&action=edit [SIGNED-OFF] Bug 8661 - break out additional authors in opac like in staff This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 QA Contact| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13772|0 |1 is obsolete| | --- Comment #10 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13804&action=edit [Signed off] Bug 8661 [Revised] break out additional authors in opac like in staff This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. Revision moves the position of the authority detail icon so that it falls inside delimiting punctuation. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13816&action=edit screenshot Hi Owen, I think the space between relator code ($4) and the author's name is missing. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Added a space. I hope it's okay that I've left it as 'signed-off.' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I am sorry, the patch does no longer apply :( Could you please rebase? I was also wondering about the HTML entities in those 2 lines: <xsl:choose> <xsl:when test="position()>1"/> <xsl:when test="@tag<700">Author(s): </xsl:when> Please switch back to signed off after rebasing. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14056|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15146&action=edit Bug 8661 [Revised] break out additional authors in opac like This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. Revision moves the position of the authority detail icon so that it falls inside delimiting punctuation. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A few notes about this feature: 1) I am not a big fan about the punctuation at the end, I think for the normal OPAC user this does not look right (given you don't know about MARC and all that). Plus: they are explicitly added and not in my data. + <xsl:when test="position()=last()"><xsl:text>.</xsl:text></xsl:when><xsl:otherwise 2) Author(s) - the way we indicate plural/singular here is not used for any other label. For the other labels we just use plural form or singular. So this is a bit inconsistent. 3) I would love if it would be possible to hide the [edt] and similar from display. The codes are not translatable and a lot of them are not an easy guess for a normal user. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #21 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Bad news. I think I need to fail this patch pending a follow-up that addresses Katrin's point 3 (repeated below, with some commentary). (In reply to comment #19)

2) Author(s) - the way we indicate plural/singular here is not used for any other label. For the other labels we just use plural form or singular. So this is a bit inconsistent.

I agree with Katrin, and since there will only ever be one Author, I think at the very least we could change that to Author instead of Author(s). I would favor changing "Additional author(s)" to "Additional authors," too, but that's open for argument.

3) I would love if it would be possible to hide the [edt] and similar from display. The codes are not translatable and a lot of them are not an easy guess for a normal user.

Without this patch we have a span to make this possible: <a href="/cgi-bin/koha/opac-search.pl?q=au:Fernandes,%20Eugenie,">Fernandes, Eugenie<span class="relatorcode"> [ill.]</span></a> The span should be kept when breaking out the authors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Sorry, I give up on this. I can't untangle the necessary changes now that the OPAC version has had so many revisions. I hope someone else can solve this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.