[Bug 11674] New: Configuration for MARC field doc URLs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Bug ID: 11674 Summary: Configuration for MARC field doc URLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr When adding a MARC record, the MARC21 field documentation is hard-coded to go to www.loc.gov - The URL(s) should be configurable, to allow non-English documentation. Same applies to UNIMARC field docs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@pttk.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@pttk.fi> --- Created attachment 26894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26894&action=edit Add syspref MarcFieldDocURL to config the MARC format documentation URL for marc edit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #2 from paxed <pasi.kallinen@pttk.fi> --- Add a new system preference MarcFieldDocURL. Setting it to some URL will make all the MARC documentation links point to that in the MARC edit UI. Leaving the value empty will use the old defaults (http://loc.gov for MARC21 and http://archive.ifla.org for UNIMARC). There are some possible substitutions usable in the URL: - {MARC} is replaced with either "MARC21" or "UNIMARC" - {FIELD} is replaced by the MARC field number, eg. "000", "048", ... - {LANG} is replaced by the UI language, eg. "en", or "fi-FI" To test: 1) Install Koha 2) Go to Cataloguing > New record 3) Clicking on the question mark links in the MARC edit will open a window to either loc.gov or archive.ifla.org 4) Install patch 5) Redo parts 1, 2, and 3. 6) Set the value of MarcFieldDocURL to http://example.com/?field={FIELD}&marc={MARC}&lang={LANG} 7) Redo parts 1 and 2 8) Clicking on the question mark links in the MARC edit will open a window to example.com, with the proper substitutions in the URL for the field, marc flavour and language. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10941 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #3 from Pablo AB <pablo.bianchi@gmail.com> --- There is another parameter asociated with MARC documentation links: If the user want to see concise or full version (please see bug #10940). So we could add to {MARC}, {FIELD} and {LANG}: - {FLAVOR} is replaced by the MARC "flavor" of the manual, either "concise" or "full" BTW, we have too much sysprefs, perhaps we need to consider something like Firefox's "about:config" to all the less used ones... or perhaps (also) wizards. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26894|0 |1 is obsolete| | --- Comment #4 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40432&action=edit (rebased) Config for MARC field doc URLs Rebased from 3.15 to 3.21. other changes made. Test plans as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40432|0 |1 is obsolete| | --- Comment #5 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40433&action=edit (rebased) Config for MARC field doc URLs Rebased from 3.15 to 3.21. no other changes made. Test plans as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- 2 small things found: 1/ sysprefs.sql should be kept ordered 2/ You can use the TT plugin to access the syspref value -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #7 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40506&action=edit (qa fix) sysprefs order and TT plugin access Addresses the QA comments from Jonathan Druart in comment #6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Indranil, could you please recreate the first patch and let the authorship to paxed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40433|0 |1 is obsolete| | --- Comment #9 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40515&action=edit (rebased) Config for MARC field doc URLs Rebased from 3.15 to 3.21. no other changes made. Test plans as before. http://bugs.koha-community.org/show_bug.cgi?id=11674 Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Author: paxed <pasi.kallinen@pttk.fi> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40515|0 |1 is obsolete| | --- Comment #10 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40516&action=edit (rebased) Config for MARC field doc URLs Rebased from 3.15 to 3.21. no other changes made. Test plans as before. http://bugs.koha-community.org/show_bug.cgi?id=11674 Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #11 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40517&action=edit (qa fix) sysprefs order and TT plugin access -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #12 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40519&action=edit (qa followup) added missing IGNORE to INSERT added missing IGNORE to INSERT statement in updatedatabase.pl for compliance with Bug 9071 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #13 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40541&action=edit (qa fix) sysprefs order and TT plugin access Addresses the QA comments from Jonathan Druart in comment #6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #14 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40542&action=edit (qa followup) added missing IGNORE to INSERT added missing IGNORE to INSERT statement in updatedatabase.pl for compliance with Bug 9071 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40516|0 |1 is obsolete| | --- Comment #15 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40605&action=edit (rebased) Config for MARC field doc URLs Rebased from 3.15 to 3.21. no other changes made. Test plans as before. http://bugs.koha-community.org/show_bug.cgi?id=11674 Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #16 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40606&action=edit (squashed commits) qa fix and followup 1/ the qa fix addresses the QA comments from Jonathan Druart in comment #6. 2/ qa followup added missing IGNORE to INSERT statement in updatedatabase.pl for compliance with Bug 9071 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- Indranil or paxed, could you please remove the addbiblio.pl change? Everything tests fine, but: marcfielddocurl => C4::Context->preference("MarcFieldDocURL"), is no longer needed, since Indranil grabs it with Koha.Preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #18 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40638&action=edit (followup) removed C4::Context->preference removed redundant reference based on comment #17 above. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 40606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40606 (squashed commits) qa fix and followup Review of attachment 40606: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11674&attachment=40606) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt @@ +144,1 @@
var docurl = "[% marcfielddocurl.replace('"','"') %]";
Oops. This is not pulling the same data, particularly if we remove the parameter like I requested. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com Status|Needs Signoff |Failed QA --- Comment #20 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- Sorry, It doesn't work for me. Did I miss something? * I applied the 3 patches on an up-to-date master and then run updatedatabase.pl * I set up "MarcFieldDocURL" with the value : www.marc21.ca/MaJ/BIB/B{FIELD}.pdf * I went to the cataloguing module and add a new biblio,click on the ? shortcut for the 245. A new blank tab opened and that's it. I should have had this page opened : http://www.marc21.ca/MaJ/BIB/B245.pdf -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org