[Bug 30318] New: Cannot override default patron messaging preferences when creating a patron in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Bug ID: 30318 Summary: Cannot override default patron messaging preferences when creating a patron in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The issue appears to be in C4/Form/MessagingPreferences.pm 73 sub handle_form_action { ... 104 if (! $prefs_set && $insert){ 105 # this is new borrower, and we have no preferences set, use the defaults 106 $target_params->{categorycode} = $categorycode; 107 C4::Members::Messaging::SetMessagingPreferencesFromDefaults( $target_params ); 108 } ... To recreate: 1 - Enable EnhancedMessagingPreferences system preference 2 - Set some defaults for a category 3 - Create a new patron in this category 4 - Uncheck all messages before saving 5 - Note patron is created with the defaults set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid, but you have to remove all settings, if you only remove some, the settings are saved correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 olivia.sperry@citruslibraries.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olivia.sperry@citruslibrari | |es.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot override default |Cannot override default |patron messaging |patron messaging |preferences when creating a |preferences when creating a |patron in staff client |patron in staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 26520 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Bug and nuances described in Christopher and George's koha-US The Terrific Every-Other-Thursday Training Video (19 January 2024): https://www.youtube.com/watch?v=vtjWbfQhHCU -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #4 from Kristi <kkrueger@cuyahogalibrary.org> --- This is a much needed fix for us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chanel.wheeler@yavapaiaz.go | |v --- Comment #5 from Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> --- We really need this too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165170&action=edit Bug 30318: Don't reset messaging preferences when form is empty In testing, the messaging preferences are set in the form when EnhancedMessagingPreferences is enabled. Switching categories silently updates the preferences unless you have made changes, in which case the user is warned and can confirm if they want to reset or not. The code only applies to patron creatoin, and does not seem to be taken into account during OPAC self-registration. It seems the silent defaulting when saving can be removed in favor of the current updates/warns in the actual form. To test: 1 - Set some messaging preferences for at least two categories 2 - Enter a new patron 3 - Confirm switching categories correctly defaults the messaging preferences 4 - Edit the preferences and switch to another category with defaults 5 - Confirm the warning appears, and preferences are set if confirmed and ignored if not 6 - Set to a category with defaults, uncheck all, and save 7 - Ooof, patron is defaulted 8 - Apply patch 9 - Repeat 1-5 and confirm nothing has changed 10 - Set to a category with defaults, uncheck all, save 11 - Confirm patron is saved with no preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165170|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 165217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165217&action=edit Bug 30318: Don't reset messaging preferences when form is empty In testing, the messaging preferences are set in the form when EnhancedMessagingPreferences is enabled. Switching categories silently updates the preferences unless you have made changes, in which case the user is warned and can confirm if they want to reset or not. The code only applies to patron creatoin, and does not seem to be taken into account during OPAC self-registration. It seems the silent defaulting when saving can be removed in favor of the current updates/warns in the actual form. To test: 1 - Set some messaging preferences for at least two categories 2 - Enter a new patron 3 - Confirm switching categories correctly defaults the messaging preferences 4 - Edit the preferences and switch to another category with defaults 5 - Confirm the warning appears, and preferences are set if confirmed and ignored if not 6 - Set to a category with defaults, uncheck all, and save 7 - Ooof, patron is defaulted 8 - Apply patch 9 - Repeat 1-5 and confirm nothing has changed 10 - Set to a category with defaults, uncheck all, save 11 - Confirm patron is saved with no preferences Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 --- Comment #8 from David Nind <david@davidnind.com> --- It looks like Andrew has signed this one off, but the status hasn't been changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to David Nind from comment #8)
It looks like Andrew has signed this one off, but the status hasn't been changed.
So I did, thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165217|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165359&action=edit Bug 30318: Don't reset messaging preferences when form is empty In testing, the messaging preferences are set in the form when EnhancedMessagingPreferences is enabled. Switching categories silently updates the preferences unless you have made changes, in which case the user is warned and can confirm if they want to reset or not. The code only applies to patron creatoin, and does not seem to be taken into account during OPAC self-registration. It seems the silent defaulting when saving can be removed in favor of the current updates/warns in the actual form. To test: 1 - Set some messaging preferences for at least two categories 2 - Enter a new patron 3 - Confirm switching categories correctly defaults the messaging preferences 4 - Edit the preferences and switch to another category with defaults 5 - Confirm the warning appears, and preferences are set if confirmed and ignored if not 6 - Set to a category with defaults, uncheck all, and save 7 - Ooof, patron is defaulted 8 - Apply patch 9 - Repeat 1-5 and confirm nothing has changed 10 - Set to a category with defaults, uncheck all, save 11 - Confirm patron is saved with no preferences Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The change makes sense, QA scripts are happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37339 CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37339 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37339 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37339 [Bug 37339] Default messaging preferences are not applied when self registering in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org