[Bug 22824] New: We depend on both YAML and YAML::Syck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Bug ID: 22824 Summary: We depend on both YAML and YAML::Syck Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- We should settle on a single YAML implementation rather than requiring two. I would advocate YAML::XS as it's the defacto recommended module by the perl community at the moment (and has been for some time now) and it's available packaged on debian back to our oldest supported release at the time of this comment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |dependency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27673 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27673 | Summary|We depend on both YAML and |Replace YAML::Syck with |YAML::Syck |YAML::XS Keywords|dependency | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |27673 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 [Bug 27673] Replace YAML with YAML::XS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676 [Bug 27676] finesMode=off not correctly handled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116722&action=edit Bug 22824: Add tests Writing some tests to see how things are working currently -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116723&action=edit Bug 22824: Replace YAML::Syck with YAML::XS in tests In order to understand how things will work after the changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116724&action=edit Bug 22824: Fixing first error in tests There was an encoding issue. The parent bug report have been fixed, see bug 27673 and patches related to Encode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116725&action=edit Bug 22824: Replace YAML::Syck with YAML::XS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116726&action=edit Bug 22824: Fix searching.pref One .pref file make YAML::XS fails. The correct display must be, before and after this patchset: If "Unescape escaped" is selected this will allow writing regular expressions "\/like this\/" while "/this/", "or/this" will be escaped and interpreted as regular strings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116727&action=edit Bug 22824: Correct on/off behaviour Here things are starting to be a bit tricky. IMO we don't want to replicate the ImplicitTyping behaviour from YAML::Syck but handle correctly the different value. We have the list of available values in the .pref file, the values in DB must match them. We want 1 or 0 in DB. 2 more occurrences: finesMode => Dealt on bug 27676 ('off' is ok here) itemBarcodeInputFilter => 'OFF' is correct here Note that we don't use ~ or true/false in *.pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116728&action=edit Bug 22824: Fix yes/no vs 1/0 Patch generated with: perl -p -i -e 's# no: # 0: #' **/*.pref perl -p -i -e 's# yes: # 1: #' **/*.pref no must be 0 and yes must be 1! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116729&action=edit Bug 22824: Replace wrong auto replacement This must be "no", it has been caught by the previous sed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116730&action=edit Bug 22824: Remove C4::Boolean, true_p, boolean_preference, etc. It seems that we don't really need all this overhead. YesNo must be a boolean and contain 1 or 0. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116731&action=edit Bug 22824: Fix default values for YesNo select variable, value from systempreferences where type="YesNo" and ( ( value <>'1' and value <>'0' ) or value is null ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116732&action=edit Bug 22824: Atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116733&action=edit Bug 22824: Add warning to the about page Just in case, add a warning to the about page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116734&action=edit Bug 22824: Remove YAML::Syck dependency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116735&action=edit Bug 22824: Adjust tests to match final behaviours Finally we diverge quite a lot with how it worked prior to this patch set. Reflect the changes in the tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116736&action=edit Bug 22824: Fix ES reindex koha-elastic --rebuild was failing with Unable to update mappings for index "koha_kohadev_biblios". Reason was: "Could not convert [marc_data.index] to boolean" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |julian.maurice@biblibre.com | |, | |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am sorry, I lost myself! This was supposed to be a quite trivial patch and it ended up huge! I think the move is interesting and going into the right direction. But I have the feeling that it's not finished and some tricky checks need to be done on the syspref table/.pref. This patch set is dealing with the yes/no, on/off weird options we have, historically I bet, in our table and .pref files. In this patch we are removing all of that and expect a boolean to be 1 or 0 (wow!), and it removes the C4::Boolean weirdness. So far the prefs, installer and translate scripts seem to be working correctly. The edge cases may be hard to catch! Don't be afraid by the number of patches, they are all very trivial! What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116722|0 |1 is obsolete| | Attachment #116723|0 |1 is obsolete| | Attachment #116724|0 |1 is obsolete| | Attachment #116725|0 |1 is obsolete| | Attachment #116726|0 |1 is obsolete| | Attachment #116727|0 |1 is obsolete| | Attachment #116728|0 |1 is obsolete| | Attachment #116729|0 |1 is obsolete| | Attachment #116730|0 |1 is obsolete| | Attachment #116731|0 |1 is obsolete| | Attachment #116732|0 |1 is obsolete| | Attachment #116733|0 |1 is obsolete| | Attachment #116734|0 |1 is obsolete| | Attachment #116735|0 |1 is obsolete| | Attachment #116736|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116741&action=edit Bug 22824: Add tests Writing some tests to see how things are working currently Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116741|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116742&action=edit Bug 22824: Add tests Writing some tests to see how things are working currently Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116743&action=edit Bug 22824: Replace YAML::Syck with YAML::XS in tests In order to understand how things will work after the changes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116744&action=edit Bug 22824: Fixing first error in tests There was an encoding issue. The parent bug report have been fixed, see bug 27673 and patches related to Encode Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116745&action=edit Bug 22824: Replace YAML::Syck with YAML::XS Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116746&action=edit Bug 22824: Fix searching.pref One .pref file make YAML::XS fails. The correct display must be, before and after this patchset: If "Unescape escaped" is selected this will allow writing regular expressions "\/like this\/" while "/this/", "or/this" will be escaped and interpreted as regular strings. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116747&action=edit Bug 22824: Correct on/off behaviour Here things are starting to be a bit tricky. IMO we don't want to replicate the ImplicitTyping behaviour from YAML::Syck but handle correctly the different value. We have the list of available values in the .pref file, the values in DB must match them. We want 1 or 0 in DB. 2 more occurrences: finesMode => Dealt on bug 27676 ('off' is ok here) itemBarcodeInputFilter => 'OFF' is correct here Note that we don't use ~ or true/false in *.pref Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116748&action=edit Bug 22824: Fix yes/no vs 1/0 Patch generated with: perl -p -i -e 's# no: # 0: #' **/*.pref perl -p -i -e 's# yes: # 1: #' **/*.pref no must be 0 and yes must be 1! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116749&action=edit Bug 22824: Replace wrong auto replacement This must be "no", it has been caught by the previous sed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116750&action=edit Bug 22824: Remove C4::Boolean, true_p, boolean_preference, etc. It seems that we don't really need all this overhead. YesNo must be a boolean and contain 1 or 0. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116751&action=edit Bug 22824: Fix default values for YesNo select variable, value from systempreferences where type="YesNo" and ( ( value <>'1' and value <>'0' ) or value is null ); Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116752&action=edit Bug 22824: Atomic update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116753&action=edit Bug 22824: Add warning to the about page Just in case, add a warning to the about page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116754&action=edit Bug 22824: Remove YAML::Syck dependency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116755&action=edit Bug 22824: Adjust tests to match final behaviours Finally we diverge quite a lot with how it worked prior to this patch set. Reflect the changes in the tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116756&action=edit Bug 22824: Fix ES reindex koha-elastic --rebuild was failing with Unable to update mappings for index "koha_kohadev_biblios". Reason was: "Could not convert [marc_data.index] to boolean" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #16)
What do you think?
Looks great to me! We've plenty of time before release in case there are any more edge cases that need catching, but I can't think of any! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Kyle M Hall from comment #33)
(In reply to Jonathan Druart from comment #16)
What do you think?
Looks great to me! We've plenty of time before release in case there are any more edge cases that need catching, but I can't think of any!
Indeed.. I've been down this path once before with another app.. I think this looks like a really solid start and covers all the cases that caused me issues in my last experience. I'll happily kick the wheels with what we've got with a view to QAing; I'm confident I won't find every issue, but feel we're still early enough in the cycle to push if we push soon and sort out any fallout... I think devs' should quickly spot potential issues once it's in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- misc/admin/koha-preferences -$YAML::Syck::SortKeys = 1; => This line needs attention. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Julian Maurice <julian.maurice@biblibre.com> --- There are some issues in misc/admin/koha-preferences: - It now allows to set any value for boolean (YesNo) preferences. In master there is a warning message and value is set to 0 when an invalid value is given - documentation probably needs an update ("If the syspref is YesNo, will accept only a boolean value, but the syntax for these is fairly lax (yes/no, on/off, 1/0, n/y, true/false are all accepted).") - 'dump' subcommand does not work, it just prints 'HASH(0x12345)'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116881&action=edit Bug 22824: Adjust POD for koha-preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116882&action=edit Bug 22824: Fix koha-preferences dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Julian Maurice from comment #36)
There are some issues in misc/admin/koha-preferences: - It now allows to set any value for boolean (YesNo) preferences. In master there is a warning message and value is set to 0 when an invalid value is given
I think we are good with the warning I added on the about page, don't you think? I don't really want to reintroduce the C4::Boolean module (or equivalent code) only for this script.
- documentation probably needs an update ("If the syspref is YesNo, will accept only a boolean value, but the syntax for these is fairly lax (yes/no, on/off, 1/0, n/y, true/false are all accepted).")
Adjusted.
- 'dump' subcommand does not work, it just prints 'HASH(0x12345)'.
Oops, fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #39)
(In reply to Julian Maurice from comment #36)
There are some issues in misc/admin/koha-preferences: - It now allows to set any value for boolean (YesNo) preferences. In master there is a warning message and value is set to 0 when an invalid value is given
I think we are good with the warning I added on the about page, don't you think? I don't really want to reintroduce the C4::Boolean module (or equivalent code) only for this script.
I think the script should prevent to set wrong value for those sysprefs. It could at least check that the value given is either "0" or "1". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116883&action=edit Bug 22824: Prevent YesNo to be filled with invalid values This patch prevents koha-preferences to set other values than 1/0 to be used for YesNo prefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #41)
Created attachment 116883 [details] [review] Bug 22824: Prevent YesNo to be filled with invalid values
This patch prevents koha-preferences to set other values than 1/0 to be used for YesNo prefs
This patch does not work. If I execute misc/admin/koha-preferences set viewMARC 2 it warns "System preference viewMARC is YesNo and expects 1 or 0. '2' was given, using '0' (OK) but the value is set to '2'. (NOT OK) And the dump subcommand output is different from master. On master it prints a serie of <sysprefName>: <sysprefValue> but with the patches it prints <sysprefName>: type: <sysprefType> value: <sysprefValue> variable: <sysprefName> which prevents to do things like: koha-preferences dump | koha-preferences load -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116883|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116884&action=edit Bug 22824: Prevent YesNo to be filled with invalid values This patch prevents koha-preferences to set other values than 1/0 to be used for YesNo prefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Julian Maurice from comment #42)
(In reply to Jonathan Druart from comment #41)
Created attachment 116883 [details] [review] [review] Bug 22824: Prevent YesNo to be filled with invalid values
This patch prevents koha-preferences to set other values than 1/0 to be used for YesNo prefs
This patch does not work. If I execute misc/admin/koha-preferences set viewMARC 2 it warns "System preference viewMARC is YesNo and expects 1 or 0. '2' was given, using '0' (OK) but the value is set to '2'. (NOT OK)
Right, I tested it very poorly, sorry about that. Should work now.
And the dump subcommand output is different from master. On master it prints a serie of <sysprefName>: <sysprefValue> but with the patches it prints <sysprefName>: type: <sysprefType> value: <sysprefValue> variable: <sysprefName>
which prevents to do things like:
koha-preferences dump | koha-preferences load
The dump|load actually worked, but not using a dump generated from master. I restored the current behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #45 from Julian Maurice <julian.maurice@biblibre.com> --- Sorry, but I think there is still a problem with dump/load If I do koha-preferences dump | koha-preferences load I get an error YAML::XS::Load Error: The problem: invalid trailing UTF-8 octet was found at document: 1 If I do koha-preferences dump > prefs && file prefs I get prefs: ISO-8859 text, with very long lines but If I do koha-preferences dump -o prefs && file prefs I get prefs: UTF-8 Unicode text, with very long lines If I remove the call to decode_utf8 in dump subcommand, it works (ie. I get UTF-8 Unicode in both cases, and dump|load seems to work) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hum $ perl misc/admin/koha-preferences dump | perl misc/admin/koha-preferences load It works $ perl misc/admin/koha-preferences dump > prefs && file prefs prefs: ASCII text indeed, but edit URLLinkText, set "✔ ❤️ ★" $ perl misc/admin/koha-preferences dump > prefs && file prefs prefs: UTF-8 Unicode text $ perl misc/admin/koha-preferences dump | perl misc/admin/koha-preferences load Still works Edit URLLinkText, it contains the characters in the correct encoding. Can you try adding binmode STDOUT, ':encoding(UTF-8)'; before Dump? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Switching back to NSO hoping to get other feedbacks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #48 from Julian Maurice <julian.maurice@biblibre.com> --- If I set "✔ ❤️ ★" to a syspref, `dump > prefs` give me a "wide-char-in-print" warning. I think I found a fix and will attach the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #49 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117037&action=edit Bug 22824: Fix encoding of misc/admin/koha-preferences output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117037|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117039&action=edit Bug 22824: Fix encoding of misc/admin/koha-preferences output Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116742|0 |1 is obsolete| | --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117040&action=edit Bug 22824: Add tests Writing some tests to see how things are working currently Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116743|0 |1 is obsolete| | --- Comment #52 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117041&action=edit Bug 22824: Replace YAML::Syck with YAML::XS in tests In order to understand how things will work after the changes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116744|0 |1 is obsolete| | --- Comment #53 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117042&action=edit Bug 22824: Fixing first error in tests There was an encoding issue. The parent bug report have been fixed, see bug 27673 and patches related to Encode Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116745|0 |1 is obsolete| | --- Comment #54 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117043&action=edit Bug 22824: Replace YAML::Syck with YAML::XS Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116746|0 |1 is obsolete| | --- Comment #55 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117044&action=edit Bug 22824: Fix searching.pref One .pref file make YAML::XS fails. The correct display must be, before and after this patchset: If "Unescape escaped" is selected this will allow writing regular expressions "\/like this\/" while "/this/", "or/this" will be escaped and interpreted as regular strings. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116747|0 |1 is obsolete| | --- Comment #56 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117045&action=edit Bug 22824: Correct on/off behaviour Here things are starting to be a bit tricky. IMO we don't want to replicate the ImplicitTyping behaviour from YAML::Syck but handle correctly the different value. We have the list of available values in the .pref file, the values in DB must match them. We want 1 or 0 in DB. 2 more occurrences: finesMode => Dealt on bug 27676 ('off' is ok here) itemBarcodeInputFilter => 'OFF' is correct here Note that we don't use ~ or true/false in *.pref Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116748|0 |1 is obsolete| | --- Comment #57 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117046&action=edit Bug 22824: Fix yes/no vs 1/0 Patch generated with: perl -p -i -e 's# no: # 0: #' **/*.pref perl -p -i -e 's# yes: # 1: #' **/*.pref no must be 0 and yes must be 1! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116749|0 |1 is obsolete| | --- Comment #58 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117047&action=edit Bug 22824: Replace wrong auto replacement This must be "no", it has been caught by the previous sed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116750|0 |1 is obsolete| | --- Comment #59 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117048&action=edit Bug 22824: Remove C4::Boolean, true_p, boolean_preference, etc. It seems that we don't really need all this overhead. YesNo must be a boolean and contain 1 or 0. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116751|0 |1 is obsolete| | --- Comment #60 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117049&action=edit Bug 22824: Fix default values for YesNo select variable, value from systempreferences where type="YesNo" and ( ( value <>'1' and value <>'0' ) or value is null ); Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116752|0 |1 is obsolete| | --- Comment #61 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117050&action=edit Bug 22824: Atomic update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116753|0 |1 is obsolete| | --- Comment #62 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117051&action=edit Bug 22824: Add warning to the about page Just in case, add a warning to the about page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116754|0 |1 is obsolete| | --- Comment #63 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117052&action=edit Bug 22824: Remove YAML::Syck dependency Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116755|0 |1 is obsolete| | --- Comment #64 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117053&action=edit Bug 22824: Adjust tests to match final behaviours Finally we diverge quite a lot with how it worked prior to this patch set. Reflect the changes in the tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116756|0 |1 is obsolete| | --- Comment #65 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117054&action=edit Bug 22824: Fix ES reindex koha-elastic --rebuild was failing with Unable to update mappings for index "koha_kohadev_biblios". Reason was: "Could not convert [marc_data.index] to boolean" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116881|0 |1 is obsolete| | --- Comment #66 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117055&action=edit Bug 22824: Adjust POD for koha-preferences Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116882|0 |1 is obsolete| | --- Comment #67 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117056&action=edit Bug 22824: Fix koha-preferences dump Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116884|0 |1 is obsolete| | --- Comment #68 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117057&action=edit Bug 22824: Prevent YesNo to be filled with invalid values This patch prevents koha-preferences to set other values than 1/0 to be used for YesNo prefs Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117039|0 |1 is obsolete| | --- Comment #69 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 117058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117058&action=edit Bug 22824: Fix encoding of misc/admin/koha-preferences output Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117040|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117636&action=edit Bug 22824: Add tests Writing some tests to see how things are working currently Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117041|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117637&action=edit Bug 22824: Replace YAML::Syck with YAML::XS in tests In order to understand how things will work after the changes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117042|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117638&action=edit Bug 22824: Fixing first error in tests There was an encoding issue. The parent bug report have been fixed, see bug 27673 and patches related to Encode Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117043|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117639&action=edit Bug 22824: Replace YAML::Syck with YAML::XS Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117044|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117640&action=edit Bug 22824: Fix searching.pref One .pref file make YAML::XS fails. The correct display must be, before and after this patchset: If "Unescape escaped" is selected this will allow writing regular expressions "\/like this\/" while "/this/", "or/this" will be escaped and interpreted as regular strings. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117045|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117641&action=edit Bug 22824: Correct on/off behaviour Here things are starting to be a bit tricky. IMO we don't want to replicate the ImplicitTyping behaviour from YAML::Syck but handle correctly the different value. We have the list of available values in the .pref file, the values in DB must match them. We want 1 or 0 in DB. 2 more occurrences: finesMode => Dealt on bug 27676 ('off' is ok here) itemBarcodeInputFilter => 'OFF' is correct here Note that we don't use ~ or true/false in *.pref Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117046|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117642&action=edit Bug 22824: Fix yes/no vs 1/0 Patch generated with: perl -p -i -e 's# no: # 0: #' **/*.pref perl -p -i -e 's# yes: # 1: #' **/*.pref no must be 0 and yes must be 1! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117047|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117643&action=edit Bug 22824: Replace wrong auto replacement This must be "no", it has been caught by the previous sed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117048|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117644&action=edit Bug 22824: Remove C4::Boolean, true_p, boolean_preference, etc. It seems that we don't really need all this overhead. YesNo must be a boolean and contain 1 or 0. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117049|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117645&action=edit Bug 22824: Fix default values for YesNo select variable, value from systempreferences where type="YesNo" and ( ( value <>'1' and value <>'0' ) or value is null ); Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117050|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117646&action=edit Bug 22824: Atomic update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117051|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117647&action=edit Bug 22824: Add warning to the about page Just in case, add a warning to the about page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117053|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117648&action=edit Bug 22824: Adjust tests to match final behaviours Finally we diverge quite a lot with how it worked prior to this patch set. Reflect the changes in the tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117054|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117649&action=edit Bug 22824: Fix ES reindex koha-elastic --rebuild was failing with Unable to update mappings for index "koha_kohadev_biblios". Reason was: "Could not convert [marc_data.index] to boolean" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117055|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117650&action=edit Bug 22824: Adjust POD for koha-preferences Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117056|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117651&action=edit Bug 22824: Fix koha-preferences dump Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117057|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117652&action=edit Bug 22824: Prevent YesNo to be filled with invalid values This patch prevents koha-preferences to set other values than 1/0 to be used for YesNo prefs Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117058|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117653&action=edit Bug 22824: Fix encoding of misc/admin/koha-preferences output Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Manual testing and I can't find any issues.. this is a great patchset and covers all the usual cases I've come across when making similar moves elsewhere. Couple of QA script failures.. the first one has me confused: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/about.tt FAIL valid_template parse error - /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt line 210: unexpected token ( warnNoActiveCurrency) [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || invalid_yesn o.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationship s || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker %] The second one is a false positive and can be ignored: FAIL t/db_dependent/yaml.t FAIL spelling dont ==> don't -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117052|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also.. I dropped a patch during rebase (the removal of YAML::Syck from cpanfile as it's already done in a followup to bug 27673) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #90 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Martin Renvoize from comment #88)
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/about.tt FAIL valid_template I saw this one too. There is a space that is not really a space, probably a non-breaking space. I don't why know it breaks the tests whereas the template works fine otherwise.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117647|0 |1 is obsolete| | --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117664&action=edit Bug 22824: Add warning to the about page Just in case, add a warning to the about page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD amended patch: there was a "bad space" between "warnNoActiveCurrency" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #92 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #91)
Created attachment 117664 [details] [review] Bug 22824: Add warning to the about page
Just in case, add a warning to the about page.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
JD amended patch: there was a "bad space" between "warnNoActiveCurrency"
^between^before^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117664|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117666&action=edit Bug 22824: Add warning to the about page Just in case, add a warning to the about page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD amended patch: there was a "bad space" between "warnNoActiveCurrency" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, that final patch squashed the warn in the QA script. Going for PQA here. It wouldn't surprise me if there's something we've missed somewhere, but I don't think we're going to spot it here and now and we're better off pushing now and fixing an issue down the line during this cycle when/if we spot it.. with all the devs running this branch I'm sure it'll "come out in the wash if there is anything lurking" Great work Jonathan, Koha's really moving forward at the moment, modernising and cleaning code.. great to see! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27874 [Bug 27874] OPAC is broken "Can't locate C4/Boolean.pm" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham@catalyst.net.n | |z --- Comment #96 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Hi all, When I went to master in my devbox, I got this error when restarting services and my sites wouldn't load: BEGIN failed--compilation aborted at /etc/koha/sites/kohadev/plack.psgi line 29. Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't locate C4/Boolean.pm in @INC (you may need to install the C4::Boolean module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /etc/koha/sites/kohadev/plack.psgi line 29. I removed the use line in /etc/koha/sites/kohadev/plack.psgi, but is there something else I should have done? And will this happen for other Kohas? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #97 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Hayley Pelham from comment #96)
Hi all,
When I went to master in my devbox, I got this error when restarting services and my sites wouldn't load:
BEGIN failed--compilation aborted at /etc/koha/sites/kohadev/plack.psgi line 29. Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't locate C4/Boolean.pm in @INC (you may need to install the C4::Boolean module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /etc/koha/sites/kohadev/plack.psgi line 29.
I removed the use line in /etc/koha/sites/kohadev/plack.psgi, but is there something else I should have done? And will this happen for other Kohas?
Cheers, Hayley
reset_all should do the job of replacing the old plack.psgi. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #98 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- (In reply to Tomás Cohen Arazi from comment #97)
(In reply to Hayley Pelham from comment #96)
Hi all,
When I went to master in my devbox, I got this error when restarting services and my sites wouldn't load:
BEGIN failed--compilation aborted at /etc/koha/sites/kohadev/plack.psgi line 29. Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't locate C4/Boolean.pm in @INC (you may need to install the C4::Boolean module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /etc/koha/sites/kohadev/plack.psgi line 29.
I removed the use line in /etc/koha/sites/kohadev/plack.psgi, but is there something else I should have done? And will this happen for other Kohas?
Cheers, Hayley
reset_all should do the job of replacing the old plack.psgi.
Ah, of course! Gracias :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #99 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 [Bug 28154] Translate script faces encoding issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28230 [Bug 28230] Renewing/Checking out record with Ä or Ö letter in title can make Koha totally unfunctional -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28317 [Bug 28317] CGI::Session::Serialize::yaml needs either YAML::Syck or YAML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |To bring consistency to the release notes| |codebase, improve | |performance and reduce | |dependencies it was decided | |we should converge on a | |single YAML parsing | |library... we opted for | |YAML::XS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29138 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138 [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 --- Comment #100 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- @@ -78,14 +78,14 @@ Web services: choices: persistent: will never be emptied or truncated (persistent) transient: might be emptied or truncated at some point (transient) - no: will never have any data in it (no) + 0: will never have any data in it (no) Isn't this replacement wrong? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9125 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org