[Bug 24486] New: Account Wording Information is duplicated in Patron's Fines Tab on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Bug ID: 24486 Summary: Account Wording Information is duplicated in Patron's Fines Tab on OPAC Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 97749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97749&action=edit duplicate language When a patron is logged into the OPAC and views their Fines tab- they will see a description of the Fine duplicated. For example: Credit (Voided) (Voided) Fine (Accruing) (Acrruing) Payment (Voided) (Voided) Attaching a screenshot. It is not necessary and could be confusing to the patron to have this duplicated per line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23115 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit efc21e6f47801503e55e3ba709a48c3f426f90ac Bug 23115: (follow-up) Move switches to a TT block Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115 [Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and charges' screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Version|19.05 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97883&action=edit Bug 24486: Remove duplicated account information at the OPAC commit efc21e6f47801503e55e3ba709a48c3f426f90ac Bug 23115: (follow-up) Move switches to a TT block Duplicated the following line: + [% PROCESS account_type_description account=ACCOUNT_LINE %] [%- PROCESS account_status_description account=ACCOUNT_LINE -%] Which cause the info to appear twice Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Hi Jonathan, Yes I only see one one "(Voided)" but in some cases (when payment has not been voided) I see nothing at all. I could be wrong but shouldn't it be 'account_status_description' that is deleted and 'account_type_description' that should stay? Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97883|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97894&action=edit Bug 24486: Remove duplicated account information at the OPAC commit efc21e6f47801503e55e3ba709a48c3f426f90ac Bug 23115: (follow-up) Move switches to a TT block Duplicated the following line: + [% PROCESS account_type_description account=ACCOUNT_LINE %] [%- PROCESS account_status_description account=ACCOUNT_LINE -%] Which cause the info to appear twice Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)" Signed-off-by: Christofer Zorn <christofer.zorn@ajaxlibrary.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Christofer Zorn <christofer.zorn@ajaxlibrary.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |christofer.zorn@ajaxlibrary | |.ca --- Comment #5 from Christofer Zorn <christofer.zorn@ajaxlibrary.ca> --- Followed test plan and was able to duplicate the error. After applying the patch, the duplication of text was no longer there. Christofer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |oleonard@myacpl.org |ommunity.org | Status|Signed Off |ASSIGNED CC| |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lucas Gass from comment #3)
Hi Jonathan,
Yes I only see one one "(Voided)" but in some cases (when payment has not been voided) I see nothing at all.
I could be wrong but shouldn't it be 'account_status_description' that is deleted and 'account_type_description' that should stay?
Thank you.
Ho you are right Lucas, the lines are not the same! Then I do not know how to correctly fix this issue. Martin or Nick may know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97894|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97961&action=edit Bug 24486: Remove duplicated account information at the OPAC Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think I finally found the proper fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97961|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97971&action=edit Bug 24486: Remove duplicated account information at the OPAC Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, trivial fix.. works as expected, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97973&action=edit Bug 24486: Alternate Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #15 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Dependency not in 18.11.x, not backporting to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org