[Bug 36067] New: Inconsistencies in --commit, --confirm for command line scrips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Bug ID: 36067 Summary: Inconsistencies in --commit, --confirm for command line scrips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Our scripts have a mix of --commit and --confirm to 'actually do the job'. I think we should try to be consistent here.. with the most backward compatible option being to make them synonyms in each script. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr Summary|Inconsistencies in |Inconsistencies in |--commit, --confirm for |--commit, --confirm for |command line scrips |command line scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 manvisharma1006@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 --- Comment #1 from manvisharma1006@gmail.com --- Created attachment 191738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191738&action=edit Bug 36067: changed 'commit' to 'confirm' across files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Catalyst list of Sponsors| | Assignee|koha-bugs@lists.koha-commun |manvisharma1006@gmail.com |ity.org | Sponsorship status|--- |Sponsored CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191738|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 191740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191740&action=edit Bug 36067: Use '--confirm' across commandline scripts This patch changes commandline scripts using --commit to use --confirm instead, to be more consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates several release notes| |scripts, cron jobs, and | |files so that they use | |--confirm instead of | |--commit, for consistency | |with other scripts. | | | |Scripts, cron jobs, package | |commands, and files updated | |are: | |- koha-elasticsearch | |- | |misc/cronjobs/crontab.examp | |le | |- | |misc/cronjobs/delete_items. | |pl | |- | |misc/cronjobs/longoverdue.p | |l | |- | |misc/cronjobs/patron_emaile | |r.pl | |- | |misc/link_bibs_to_authoriti | |es.pl | |- | |misc/search_tools/rebuild_e | |lasticsearch.pl | | | |**Important note for | |existing installations**: | |You will need to update | |your crontab files if any | |entries include --commit as | |an option. CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Thanks for the patch! The author is currently showing as "John Doe <you@example.com>". If you can let me know the correct details, I'll update the patch author. I think these details are also used for what is shown on More > About Koha > Timeline for new Koha developers (and looks good on your CV!). David Testing notes (using koha-testing-docker): 1. I didn't test the actual scripts to see if they still work - looks like a straight-forward string change to me. 2. Before the patch: git grep "\--commit" 3. Several occurrences. 4. After the patch: only one occurrence left in misc/migration_tools/bulkmarcimport.pl (others are historical release notes) 5. To get `koha-elasticsearch -h` to show the updated help information, do a reset_all after applying the patch. Does misc/migration_tools/bulkmarcimport.pl need updating as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 --- Comment #4 from manvisharma1006@gmail.com --- It would be great if you could put it under Manvi <manvisharma1006@gmail.com> David! And you're welcome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191740|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 191880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191880&action=edit Bug 36067: Use '--confirm' across commandline scripts This patch changes commandline scripts using --commit to use --confirm instead, to be more consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to manvisharma1006 from comment #4)
It would be great if you could put it under Manvi <manvisharma1006@gmail.com> David! And you're welcome!
Thanks Manvi! Now signed off. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36067 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The test plan for this bug needs to include actually running all the impacted scripts with both --commmit and --confirm to ensure they both work after the patch is applied. With this patch applied, delete_items.pl works with --commit but not with --confirm. kohadev-koha@kohadevbox:koha(main)$ perl misc/cronjobs/delete_items.pl --where "withdrawn=1" --confirm -v Unknown option: confirm Where statement: withdrawn=1 Test run only! No data will be deleted. Would have deleted item 756 (1 items remain on record) Looking at the code, you've added --confirm to the list of options shown to the user when using --help or --manual, but not actually implemented it in the GetOptions section (https://github.com/Koha-Community/Koha/blob/c3169205eced4a862be39120ea7db82b...) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org