[Bug 19758] New: Move template JavaScript to the footer: Serials, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Bug ID: 19758 Summary: Move template JavaScript to the footer: Serials, part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 19754 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some of the serials templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19754 |17858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69570&action=edit Bug 19758: Move template JavaScript to the footer: Serials, part 1 This patch modifies some staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Search for a vendor - "Choose" link and "Cancel" button should work correctly - Search for record - "Choose" link and "Cancel" button should word correctly - Serials -> Add subscription fields - Datatable, delete confirmation - Edit - Form validation (submit both authorised value and MARC field) - Serials -> Check expiration - Date picker in search form - Search - Renew button triggers popup - Serials -> Claims -> Search results - Date picker, datatable, form validation - Select all/none; Download claims -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69570|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69604&action=edit Bug 19758: Move template JavaScript to the footer: Serials, part 1 This patch modifies some staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Search for a vendor - "Choose" link and "Cancel" button should work correctly - Search for record - "Choose" link and "Cancel" button should word correctly - Serials -> Add subscription fields - Datatable, delete confirmation - Edit - Form validation (submit both authorised value and MARC field) - Serials -> Check expiration - Date picker in search form - Search - Renew button triggers popup - Serials -> Claims -> Search results - Date picker, datatable, form validation - Select all/none; Download claims Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69604|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69788&action=edit Bug 19758: Move template JavaScript to the footer: Serials, part 1 This patch modifies some staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Search for a vendor - "Choose" link and "Cancel" button should work correctly - Search for record - "Choose" link and "Cancel" button should word correctly - Serials -> Add subscription fields - Datatable, delete confirmation - Edit - Form validation (submit both authorised value and MARC field) - Serials -> Check expiration - Date picker in search form - Search - Renew button triggers popup - Serials -> Claims -> Search results - Date picker, datatable, form validation - Select all/none; Download claims Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |FIXED --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backporting for 17.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org