[Bug 9663] New: Individual bibliographic record "Save" option requires export permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Bug ID: 9663 Summary: Individual bibliographic record "Save" option requires export permission Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org CC: gmcharlt@gmail.com If you are viewing a bibliographic record in the staff client (detail.pl, MARCdetail.pl, etc) and want to use the "Save" option to download the record in specific format (MODS, MARCXML, MARC etc.) the operation requires "export_catalog" permission. Since this operation is identical to one which OPAC users can perform without any privileges this must be incorrect. I believe the "export_catalog" permission only applies to tools/export.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15555&action=edit Bug 9663 - Individual bibliographic record "Save" option requires export permission This patch corrects permission on the export option available on catalogue pages in the staff client (detail.pl, MARCdetail.pl, etc) so that users no longer require "export_catalogue" permission. "export_catalogue" permission is required only for tools/export.pl. This patch also corrects some crazy nearby indentation. Sorry, couldn't resist. To test, visit a page like detail.pl with and without "export_catalogue" permission. It should be possible to save the record as MODS, MARCXML, MARC, etc. without error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Blocks| |9665 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Comment on attachment 15555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15555 Bug 9663 - Individual bibliographic record "Save" option requires export permission Review of attachment 15555: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9663&attachment=15555) ----------------------------------------------------------------- Correcting indentation is fine, the -w switch lets us ignore whitespace changes (for git diff and git blame etc) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15555|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15652&action=edit Bug 9663 - Individual bibliographic record "Save" option requires export permission This patch corrects permission on the export option available on catalogue pages in the staff client (detail.pl, MARCdetail.pl, etc) so that users no longer require "export_catalogue" permission. "export_catalogue" permission is required only for tools/export.pl. This patch also corrects some crazy nearby indentation. Sorry, couldn't resist. To test, visit a page like detail.pl with and without "export_catalogue" permission. It should be possible to save the record as MODS, MARCXML, MARC, etc. without error. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Since this export script is only accessible from the catalogue/detail.pl page (which has the catalogue permission), I see no reason not to accept this patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15652|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15756&action=edit Bug 9663 - Individual bibliographic record "Save" option requires export permission This patch corrects permission on the export option available on catalogue pages in the staff client (detail.pl, MARCdetail.pl, etc) so that users no longer require "export_catalogue" permission. "export_catalogue" permission is required only for tools/export.pl. This patch also corrects some crazy nearby indentation. Sorry, couldn't resist. To test, visit a page like detail.pl with and without "export_catalogue" permission. It should be possible to save the record as MODS, MARCXML, MARC, etc. without error. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org