[Bug 25540] New: Biblio.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Bug ID: 25540 Summary: Biblio.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Master_DO #874 11:37:04 koha_1 | # Failed test 'ReservesControlBranch: ItemHomeLibrary, biblio1, patron1 should return 6 but returns 7' 11:37:04 koha_1 | # at t/db_dependent/Koha/Biblio.t line 408. 11:37:04 koha_1 | 11:37:04 koha_1 | # Failed test 'ReservesControlBranch: PatronLibrary, biblio1, patron1 should return 6 but returns 7' 11:37:04 koha_1 | # at t/db_dependent/Koha/Biblio.t line 408. 11:37:05 koha_1 | # Looks like you planned 29 tests but ran 31. 11:37:05 koha_1 | # Looks like you failed 2 tests of 31 run. 11:37:05 koha_1 | 11:37:05 koha_1 | # Failed test 'pickup_locations' 11:37:05 koha_1 | # at t/db_dependent/Koha/Biblio.t line 435. 11:37:06 koha_1 | # Looks like you failed 1 test of 12. 11:37:06 koha_1 | [09:37:06] t/db_dependent/Koha/Biblio.t Was failing earlier on D10 as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Add ability to defined groups of locations for hold pickup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105093&action=edit Bug 25540: Use build_sample_item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105094&action=edit Bug 25540: DO NOT PUSH - diag statement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have no idea what's going in here. There is a library that is picked from... somewhere? See second patch. Run the tests several times and it will fail at some point (before 30th run usually) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustin.moyano@gmail.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Again, Master_U18 #796 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- IMO This needs to be addressed for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target |rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Related test in t/db_dependent/Template/Plugin/Branches.t is failing as well: 14:31:13 koha_1 | # Failed test 'Libraries count is correct' 14:31:13 koha_1 | # at t/db_dependent/Template/Plugin/Branches.t line 176. 14:31:13 koha_1 | # got: '4' 14:31:13 koha_1 | # expected: '3' 14:31:13 koha_1 | 14:31:13 koha_1 | # Failed test 'Libraries count is correct' 14:31:13 koha_1 | # at t/db_dependent/Template/Plugin/Branches.t line 184. 14:31:13 koha_1 | # got: '4' 14:31:13 koha_1 | # expected: '3' 14:31:13 koha_1 | # Looks like you failed 2 tests of 4. 14:31:13 koha_1 | 14:31:13 koha_1 | # Failed test 'selected tests' 14:31:13 koha_1 | # at t/db_dependent/Template/Plugin/Branches.t line 189. 14:31:13 koha_1 | # Looks like you failed 1 test of 8. 14:31:13 koha_1 | 14:31:13 koha_1 | # Failed test 'pickup_locations() tests' 14:31:13 koha_1 | # at t/db_dependent/Template/Plugin/Branches.t line 192. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105266&action=edit Bug 25540: Default for branches.pickup_location must be 0 This is a try to fix failures in both t/db_dependent/Template/Plugin/Branches.t t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chris@bigballofwax.co.nz |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105266|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105093|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105094|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105290&action=edit Bug 25540: Use build_sample_item Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105291&action=edit Bug 25540: DO NOT PUSH - diag statement Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105292&action=edit Bug 25540: Default for branches.pickup_location must be 0 This is a try to fix failures in both t/db_dependent/Template/Plugin/Branches.t t/db_dependent/Koha/Biblio.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Tha changes 'make sense'. But the Biblio.t tests explicitly delete all libraries and the added ones are totally controlled in terms of the pickup_location flag. I certainly reproduced the failure in t/db_dependent/Template/Plugin/Branches.t with a loop calling the test 30 times, and couldn't reproduce it after applying the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks guys.. Passing QA on this one too, changes make sense and tests now pass consistently for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105290|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105296&action=edit Bug 25540: Use build_sample_item Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105292|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105297&action=edit Bug 25540: Default for branches.pickup_location must be 0 This is a try to fix failures in both t/db_dependent/Template/Plugin/Branches.t t/db_dependent/Koha/Biblio.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- tests not failing on 19.11.x so not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Still failing https://jenkins.koha-community.org/job/Koha_Master_U18/954/consoleFull https://jenkins.koha-community.org/job/Koha_Master_U16/134/consoleFull -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27062 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #17)
Still failing
https://jenkins.koha-community.org/job/Koha_Master_U18/954/consoleFull https://jenkins.koha-community.org/job/Koha_Master_U16/134/consoleFull
See bug 27062. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115204&action=edit Bug 25540: (follow-up) Test defined not true To test: prove -v t/db_dependent/Koha/Biblio.t it succeeds (maybe) add a library that is not a pickup_location prove the test it fails apply the patch prove! it passes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115204|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115205&action=edit Bug 22284: (QA follow-up) Fix test failures Only libraries that are a pickup location will be returned as a pickup location To test: prove -v t/db_dependent/Koha/Biblio.t it succeeds (maybe) add a library that is not a pickup_location prove the test it fails apply the patch prove! it passes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Follow up pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org