[Bug 21078] New: Overdrive JS breaks when window opened from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Bug ID: 21078 Summary: Overdrive JS breaks when window opened from another site Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries use a homepage outside of koha and a widget to open the catalog. When doing this the overdrive.js is unable to access the window.opener properties and dies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76965&action=edit Bug 21078: ovedrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From an source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76965|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79327&action=edit Bug 21078: ovedrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From an source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79544&action=edit Bug 21078: overdrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From a source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org