[Bug 29686] New: Adapt OverDrive for new fulfillment API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Bug ID: 29686 Summary: Adapt OverDrive for new fulfillment API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Background: http://developer.overdrive.com/overdrive-api-notices/01-sep-2021-coming-soon... Basically, once a title is checked out, we need to make a call to get the 'fulfillment' URL The new API endpoint returns a redirect request, but we can also get the URL back and refer the patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128457&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128457|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128481&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128481|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128514&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128514|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 128628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128628&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can't test this with Overdrive, but trusting Nick, Andrew and Owen have tested this. Code changes pass QA tools and are limited to the Overdrive files so there should be no side-effects on other parts of the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128628|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129233&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org