[Bug 5634] New: ordering branches cas independant
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Summary: ordering branches cas independant Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: PATCH-Sent Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 Some libraries use lower case & upper case in branch description. The list is ordered case sensitively, it's hard to read. The patch will order the list case insensively. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-01-20 01:19:27 UTC --- Created attachment 3006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3006 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed Summary|ordering branches cas |ordering branches case |independant |independant --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-20 07:23:35 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-02-06 11:13:49 UTC --- This bug is mentioned in: Bug 5634: BZ5634 order branch list alphabetically, without taking care of uc/lc http://lists.koha-community.org/pipermail/koha-patches/2011-January/013676.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ordering branches case |Ordering branches should be |independant |case independent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-02-24 21:11:58 UTC --- Created attachment 3213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3213 Screenshot of incorrect sort -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-02-24 21:14:03 UTC --- Created attachment 3214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3214 Screenshot of correct sort The accepted patch fixes instances where the branch list is generated by GetBranchesLoop. Other branch lists are unaffected and will still show an incorrect sort. I think this bug should remain open until all instances are consistent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-02-24 21:17:43 UTC --- Created attachment 3215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3215 Branch order on login page still incorrect The order of branches on the login page is not only sorted incorrectly with regard to case but is ordered by branchcode instead of branch name (ALB, APL, COV, CPL, GPL, NPL, PPL, and goodwin in the example screenshot). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2011-02-24 21:19:30 UTC --- Created attachment 3216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3216 Branch sort on patron entry screen still incorrect -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #8 from Nadia Nicolaides <nanunic@gmail.com> --- Created attachment 14200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14200&action=edit Follow-up Bug 5634: Ordering branches should be case independent This patch fix the order of branches in the log-in page, on Branch.pm we added the variable branchcode to the hash returned by GetBranchesLoop, and this function is used on Auth.pm to get a list of branches ordered by branchname To test 1) Use an installation with some branches 2) On login screen the branches are ordered by branchcode 3) apply the patch 4) On login screen the branches are now ordered by branchname -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14201&action=edit Follow-up Bug 5634: Ordering branches should be case independent This patch fix the order of branches in the log-in page, on Branch.pm we added the variable branchcode to the hash returned by GetBranchesLoop, and this function is used on Auth.pm to get a list of branches ordered by branchname To test 1) Use an installation with some branches 2) On login screen the branches are ordered by branchcode 3) apply the patch 4) On login screen the branches are now ordered by branchname Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3006|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14200|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: The odications in C4/Branch.pm are just in order to not use the default variable ($_). On the login page we call the GetBranchesLoop routine. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14201|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14220&action=edit Follow-up Bug 5634: Ordering branches should be case independent This patch fix the order of branches in the log-in page, on Branch.pm we added the variable branchcode to the hash returned by GetBranchesLoop, and this function is used on Auth.pm to get a list of branches ordered by branchname To test 1) Use an installation with some branches 2) On login screen the branches are ordered by branchcode 3) apply the patch 4) On login screen the branches are now ordered by branchname Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch works as expected. Before applying the patch the branches with lower case was at the end of the list. Now they are well ordered. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14505&action=edit Bug 5634 - Followup - Ordering branches should be case independent This followup replace use of CGI::scroll_list() to show list of branches. In two files, marc21_linking_section.pl and unimarc_field_4XX.pl, the scrolling list is created but not used in the template file, so the code is removed. Also minor renaming/normalizing of variables. To test: 1) Install with some branches, records and patrons 2.1) Select a record, click 'Place hold', select user, there is a pull-down next to 'Pickup at:', list is ordered case sensitive 2.2) Go to Reports > Average loan time, next to Library is a pull-down, list without order 2.3) Go to Reports > Catalog by item type, next to 'Select a library' is a pull-down, list is ordered case sensitive 2.4) This is tricky, go to Reports home, change last part of URL 'reports-home.pl' with 'manager.pl?report_name=issues_by_borrower_category' (can't find a direct link), next to 'Select a library' is a library pull-down, list without order 2.5) Edit/Add a patron, on section 'Library management' there is a library pull-down, case sensitive 2.6) OPAC, as logged user, make a suggestion or hold, there is library pull-down, correct order 3) Apply the patch 4.1) Repeat 2.1), correctly ordered list 4.2) Repeat 2.2), correctly ordered list 4.3) Repeat 2.3), correctly ordered list 4.4) Repeat 2.4), correctly ordered list 4.5) This is a bit more work There are 3 possible situations to test: A) No branches, must show a message that are no libraries defined B) New patron, must show a correctly ordered list of branches, current branch selected C) Edit patron, must show a correctly ordered list of branches, patron branch selected 4.6) Small changes on variable names, so retest 2.6) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Bernardo, Could you create a new bug and submit your patch in it please? Since this patch has been pushed to master, all new followups must be proposed in a new bug. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Ok, no problem for me. A new bug is cleaner, but this patch do not solve all cases. So, have to be several patches and/or bugs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14505|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Works on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9457 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patch submitted on bug 9457 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org